The first full 8-worker run surfaced 52 failures, 28 of them "Failed to log out"
(UITestHelpers:86) — forcing a profile-navigation logout between every test (each
test = new account) is fragile, and 8 parallel simulator clones thrashed the
machine (the remaining failures were UI timeouts under that load).
- AuthenticatedUITestCase: relaunchBetweenTests = true. A fresh app launch with
--reset-state lands on the login screen, so each test logs in as its own account
with NO UI logout between tests. Removed the ensureLoggedOut call.
- run_ui_tests.sh: default workers 8 -> 4 (reliable on a Mac mini; each test now
relaunches + creates an account, so the bottleneck is CPU/simulator).
Verified: ContractorUITests (was ~15 logout failures) now passes at 4 workers,
0 leaked accounts.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Migrate the XCUITest suite off the legacy shared-account model (and the
prior Django-style auth assumptions) to a parallel-safe, domain-organized
architecture, validated end-to-end against the live Kratos stack.
Isolation (parallel-safe by construction):
- Core/Fixtures/TestAccount.swift: each test mints its own pre-verified
Kratos identity (uit_<domain>_<uuid>@test.honeydue.local), logs in, seeds
under its own token, and deletes the identity in teardown (cascading all
data + clearing Kratos). No shared testuser; parallel workers no longer race.
- AuthenticatedUITestCase rewritten to that model (member surface preserved);
adds requiresResidence / seedAccountPreconditions to seed UI-gated data
BEFORE login (a fresh account is empty at login).
Organization (255 tests preserved, none dropped):
- 21 domain suites under Auth/ Onboarding/ Residence/ Task/ Contractor/
Document/ Sharing/ Navigation/ Smoke/ CrossCutting/ E2E/, consistent
<Domain>UITests naming. Removes the Suite1..11 / AAA_ / ZZ_ / Tests/Rebuild
naming chaos and the overlapping task/residence/auth suites.
Runner + test plans:
- run_ui_tests.sh: Smoke gate -> Seed -> Parallel(8 workers) -> Sweep. The
parallel phase runs the whole target minus phase-managed suites via
-skip-testing, so new suites auto-include (no hand-maintained list to drift).
Drops the 2-worker cap and Suite6 isolation (isolation made them moot).
- HoneyDueUITests.xctestplan skips the 4 phase-managed suites; adds Smoke.xctestplan.
Kratos auth fixes folded in (login/verify/reset endpoints removed under Kratos):
real Mailpit verification codes replace the obsolete fixed "123456"; teardown
deletes Kratos identities; admin-panel login uses the correct seeded password.
Build green; isolation, parallelism, and the precondition/sharing migrations
validated against the live stack (0 leaked accounts).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Default is `false` (current session-reuse behaviour) so tests reuse the
existing logged-in session — fast, and resilient to suites where the
current screen lacks a logout affordance (`UITestHelpers.ensureLoggedOut`
times out → tests fail before their bodies run).
Override to `true` in suites that observe transient `Invalid token` 401s
on POST/PATCH while reads continue to work. Recipe added after a 2026-05
incident where the API container was rebuilt mid-suite and in-memory
JWT tokens went stale; the diagnostic value is having an explicit lever
to reach for next time, not flipping the default.
Net effect on a clean simulator + stable API: 244/253 → 244/253 (no
behaviour change in the default path).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Fix root causes uncovered across repeated parallel runs:
- Admin seed password "test1234" failed backend complexity (needs
uppercase). Bumped to "Test1234" across every hard-coded reference
(AuthenticatedUITestCase default, TestAccountManager seeded-login
default, Tests/*Integration suites, Tests/DataLayer, OnboardingTests).
- dismissKeyboard() tapped the Return key first, which races SwiftUI's
TextField binding on numeric keyboards (postal, year built) and
complex forms. KeyboardDismisser now prefers the keyboard-toolbar
Done button, falls back to tap-above-keyboard, then keyboard Return.
BaseUITestCase.clearAndEnterText uses the same helper.
- Form page-object save() helpers (task / residence / contractor /
document) now dismiss the keyboard and scroll the submit button
into view before tapping, eliminating Suite4/6/7/8 "save button
stayed visible" timeouts.
- Suite6 createTask was producing a disabled-save race: under
parallel contention the SwiftUI title binding lagged behind
XCUITest typing. Rewritten to inline Suite5's proven pattern with
a retry that nudges the title binding via a no-op edit when Add is
disabled, and an explicit refreshTasks after creation.
- Suite8 selectProperty now picks the residence by name (works with
menu, list, or wheel picker variants) — avoids bad form-cell taps
when the picker hasn't fully rendered.
- run_ui_tests.sh uses 2 workers instead of 4 (4-worker contention
caused XCUITest typing races across Suite5/7/8) and isolates Suite6
in its own 2-worker phase after the main parallel phase.
- Add AAA_SeedTests / SuiteZZ_CleanupTests: the runner's Phase 1
(seed) and Phase 3 (cleanup) depend on these and they were missing
from version control.
- Fix registration flow dismiss cascade: chain fullScreenCover → sheet onDismiss
so auth state is set only after all UIKit presentations are removed, preventing
RootView from swapping LoginView→MainTabView behind a stale sheet
- Fix onboarding reset: set hasCompletedOnboarding directly instead of calling
completeOnboarding() which has an auth guard that fails after DataManager.clear()
- Stabilize Suite1 registration tests, Suite6 task tests, Suite7 contractor tests
- Add clean-slate-per-suite via AuthenticatedUITestCase reset state
- Improve test account seeding and screen object reliability
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Major infrastructure changes:
- BaseUITestCase: per-suite app termination via class setUp() prevents
stale state when parallel clones share simulators
- relaunchBetweenTests override for suites that modify login/onboarding state
- focusAndType: dedicated SecureTextField path handles iOS strong password
autofill suggestions (Choose My Own Password / Not Now dialogs)
- LoginScreenObject: tapSignUp/tapForgotPassword use scrollIntoView for
offscreen buttons instead of simple swipeUp
- Removed all coordinate taps from ForgotPasswordScreen, VerifyResetCodeScreen,
ResetPasswordScreen (Rule 3 compliance)
- Removed all usleep calls from screen objects (Rule 14 compliance)
App fixes exposed by tests:
- ContractorsListView: added onDismiss to sheet for list refresh after save
- AllTasksView: added Task.RefreshButton accessibility identifier
- AccessibilityIdentifiers: added Task.refreshButton
- DocumentsWarrantiesView: onDismiss handler for document list refresh
- Various form views: textContentType, submitLabel, onSubmit for keyboard flow
Test fixes:
- PasswordResetTests: handle auto-login after reset (app skips success screen)
- AuthenticatedUITestCase: refreshTasks() helper for kanban toolbar button
- All pre-login suites use relaunchBetweenTests for test independence
- Deleted dead code: AuthenticatedTestCase, SeededTestData, SeedTests,
CleanupTests, old Suite0/2/3, Suite1_RegistrationRebuildTests
10 remaining failures: 5 iOS strong password autofill (simulator env),
3 pull-to-refresh gesture on empty lists, 2 feature coverage edge cases.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Trey T