- Fix registration flow dismiss cascade: chain fullScreenCover → sheet onDismiss so auth state is set only after all UIKit presentations are removed, preventing RootView from swapping LoginView→MainTabView behind a stale sheet - Fix onboarding reset: set hasCompletedOnboarding directly instead of calling completeOnboarding() which has an auth guard that fails after DataManager.clear() - Stabilize Suite1 registration tests, Suite6 task tests, Suite7 contractor tests - Add clean-slate-per-suite via AuthenticatedUITestCase reset state - Improve test account seeding and screen object reliability Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
226 lines
8.6 KiB
Swift
226 lines
8.6 KiB
Swift
import XCTest
|
|
|
|
/// Base class for all tests that require a logged-in user.
|
|
class AuthenticatedUITestCase: BaseUITestCase {
|
|
|
|
// MARK: - Configuration (override in subclasses)
|
|
|
|
var testCredentials: (username: String, password: String) {
|
|
("testuser", "TestPass123!")
|
|
}
|
|
|
|
var needsAPISession: Bool { false }
|
|
|
|
var apiCredentials: (username: String, password: String) {
|
|
("admin", "test1234")
|
|
}
|
|
|
|
// MARK: - API Session
|
|
|
|
private(set) var session: TestSession!
|
|
private(set) var cleaner: TestDataCleaner!
|
|
|
|
// MARK: - Lifecycle
|
|
|
|
override class func setUp() {
|
|
super.setUp()
|
|
guard TestAccountAPIClient.isBackendReachable() else { return }
|
|
// Ensure both known test accounts exist (covers all subclass credential overrides)
|
|
if TestAccountAPIClient.login(username: "testuser", password: "TestPass123!") == nil {
|
|
_ = TestAccountAPIClient.createVerifiedAccount(username: "testuser", email: "testuser@honeydue.com", password: "TestPass123!")
|
|
}
|
|
if TestAccountAPIClient.login(username: "admin", password: "test1234") == nil {
|
|
_ = TestAccountAPIClient.createVerifiedAccount(username: "admin", email: "admin@honeydue.com", password: "test1234")
|
|
}
|
|
}
|
|
|
|
override func setUpWithError() throws {
|
|
guard TestAccountAPIClient.isBackendReachable() else {
|
|
throw XCTSkip("Backend not reachable at \(TestAccountAPIClient.baseURL)")
|
|
}
|
|
|
|
try super.setUpWithError()
|
|
|
|
// If already logged in (tab bar visible), skip the login flow
|
|
let tabBar = app.tabBars.firstMatch
|
|
if tabBar.waitForExistence(timeout: defaultTimeout) {
|
|
// Already logged in — just set up API session if needed
|
|
if needsAPISession {
|
|
guard let apiSession = TestAccountManager.loginSeededAccount(
|
|
username: apiCredentials.username,
|
|
password: apiCredentials.password
|
|
) else {
|
|
XCTFail("Could not login API account '\(apiCredentials.username)'")
|
|
return
|
|
}
|
|
session = apiSession
|
|
cleaner = TestDataCleaner(token: apiSession.token)
|
|
}
|
|
return
|
|
}
|
|
|
|
// Not logged in — do the full login flow
|
|
UITestHelpers.ensureLoggedOut(app: app)
|
|
loginToMainApp()
|
|
|
|
if needsAPISession {
|
|
guard let apiSession = TestAccountManager.loginSeededAccount(
|
|
username: apiCredentials.username,
|
|
password: apiCredentials.password
|
|
) else {
|
|
XCTFail("Could not login API account '\(apiCredentials.username)'")
|
|
return
|
|
}
|
|
session = apiSession
|
|
cleaner = TestDataCleaner(token: apiSession.token)
|
|
}
|
|
}
|
|
|
|
override func tearDownWithError() throws {
|
|
cleaner?.cleanAll()
|
|
try super.tearDownWithError()
|
|
}
|
|
|
|
// MARK: - Login
|
|
|
|
func loginToMainApp() {
|
|
let creds = testCredentials
|
|
|
|
UITestHelpers.ensureOnLoginScreen(app: app)
|
|
|
|
let login = LoginScreenObject(app: app)
|
|
login.waitForLoad(timeout: loginTimeout)
|
|
login.enterUsername(creds.username)
|
|
login.enterPassword(creds.password)
|
|
|
|
let loginButton = app.buttons[AccessibilityIdentifiers.Authentication.loginButton]
|
|
loginButton.waitForExistenceOrFail(timeout: defaultTimeout)
|
|
loginButton.tap()
|
|
|
|
waitForMainApp()
|
|
}
|
|
|
|
func waitForMainApp() {
|
|
let tabBar = app.tabBars.firstMatch
|
|
let verification = VerificationScreen(app: app)
|
|
|
|
let deadline = Date().addingTimeInterval(loginTimeout)
|
|
while Date() < deadline {
|
|
if tabBar.exists { break }
|
|
if verification.codeField.exists {
|
|
verification.enterCode(TestAccountAPIClient.debugVerificationCode)
|
|
verification.submitCode()
|
|
_ = tabBar.waitForExistence(timeout: loginTimeout)
|
|
break
|
|
}
|
|
RunLoop.current.run(until: Date().addingTimeInterval(0.5))
|
|
}
|
|
|
|
XCTAssertTrue(tabBar.exists, "Expected tab bar after login with '\(testCredentials.username)'")
|
|
}
|
|
|
|
// MARK: - Tab Navigation
|
|
|
|
func navigateToTab(_ label: String) {
|
|
let tabBar = app.tabBars.firstMatch
|
|
tabBar.waitForExistenceOrFail(timeout: navigationTimeout)
|
|
|
|
let tab = tabBar.buttons.containing(
|
|
NSPredicate(format: "label CONTAINS[c] %@", label)
|
|
).firstMatch
|
|
tab.waitForExistenceOrFail(timeout: navigationTimeout)
|
|
tab.tap()
|
|
|
|
// Verify navigation happened — wait for isSelected (best effort, won't fail)
|
|
// sidebarAdaptable tabs sometimes need a moment
|
|
let selected = NSPredicate(format: "isSelected == true")
|
|
let exp = XCTNSPredicateExpectation(predicate: selected, object: tab)
|
|
let result = XCTWaiter().wait(for: [exp], timeout: navigationTimeout)
|
|
|
|
// If first tap didn't register, tap again
|
|
if result != .completed {
|
|
tab.tap()
|
|
_ = XCTWaiter().wait(for: [XCTNSPredicateExpectation(predicate: selected, object: tab)], timeout: navigationTimeout)
|
|
}
|
|
}
|
|
|
|
func navigateToResidences() { navigateToTab("Residences") }
|
|
func navigateToTasks() { navigateToTab("Tasks") }
|
|
func navigateToContractors() { navigateToTab("Contractors") }
|
|
func navigateToDocuments() { navigateToTab("Doc") }
|
|
func navigateToProfile() { navigateToTab("Profile") }
|
|
|
|
// MARK: - Pull to Refresh
|
|
|
|
func pullToRefresh() {
|
|
let scrollable = app.collectionViews.firstMatch.exists
|
|
? app.collectionViews.firstMatch
|
|
: app.scrollViews.firstMatch
|
|
guard scrollable.waitForExistence(timeout: defaultTimeout) else { return }
|
|
|
|
let start = scrollable.coordinate(withNormalizedOffset: CGVector(dx: 0.5, dy: 0.15))
|
|
let end = scrollable.coordinate(withNormalizedOffset: CGVector(dx: 0.5, dy: 0.85))
|
|
start.press(forDuration: 0.3, thenDragTo: end)
|
|
|
|
_ = app.activityIndicators.firstMatch.waitForNonExistence(timeout: navigationTimeout)
|
|
}
|
|
|
|
func pullToRefreshUntilVisible(_ element: XCUIElement, maxRetries: Int = 3) {
|
|
for _ in 0..<maxRetries {
|
|
if element.waitForExistence(timeout: defaultTimeout) { return }
|
|
pullToRefresh()
|
|
}
|
|
}
|
|
|
|
/// Tap the refresh button on the Tasks/Kanban screen (no pull-to-refresh on kanban).
|
|
func refreshTasks() {
|
|
let refreshButton = app.buttons[AccessibilityIdentifiers.Task.refreshButton]
|
|
if refreshButton.waitForExistence(timeout: defaultTimeout) && refreshButton.isEnabled {
|
|
refreshButton.tap()
|
|
_ = app.activityIndicators.firstMatch.waitForNonExistence(timeout: navigationTimeout)
|
|
}
|
|
}
|
|
|
|
// MARK: - Preconditions (Rule 17: validate assumptions via API before tests run)
|
|
|
|
/// Ensure at least one residence exists for the current user.
|
|
/// Required precondition for: task creation, document creation.
|
|
func ensureResidenceExists() {
|
|
guard let token = session?.token else { return }
|
|
if let residences = TestAccountAPIClient.listResidences(token: token),
|
|
!residences.isEmpty { return }
|
|
// No residence — create one via API
|
|
let _ = TestDataSeeder.createResidence(token: token, name: "Precondition Home \(Int(Date().timeIntervalSince1970))")
|
|
}
|
|
|
|
/// Ensure the current user has a specific minimum of residences.
|
|
func ensureResidenceCount(minimum: Int) {
|
|
guard let token = session?.token else { return }
|
|
let existing = TestAccountAPIClient.listResidences(token: token) ?? []
|
|
for i in existing.count..<minimum {
|
|
let _ = TestDataSeeder.createResidence(token: token, name: "Precondition Home \(i) \(Int(Date().timeIntervalSince1970))")
|
|
}
|
|
}
|
|
|
|
// MARK: - Shared Helpers
|
|
|
|
/// Fill a text field by accessibility identifier. The ONE way to type into fields.
|
|
func fillTextField(identifier: String, text: String, file: StaticString = #filePath, line: UInt = #line) {
|
|
let field = app.textFields[identifier].firstMatch
|
|
field.waitForExistenceOrFail(timeout: defaultTimeout, file: file, line: line)
|
|
field.focusAndType(text, app: app, file: file, line: line)
|
|
}
|
|
|
|
/// Dismiss keyboard using the Return key or toolbar Done button.
|
|
func dismissKeyboard() {
|
|
let returnKey = app.keyboards.buttons["return"]
|
|
let doneKey = app.keyboards.buttons["Done"]
|
|
if returnKey.exists {
|
|
returnKey.tap()
|
|
} else if doneKey.exists {
|
|
doneKey.tap()
|
|
}
|
|
_ = app.keyboards.firstMatch.waitForNonExistence(timeout: defaultTimeout)
|
|
}
|
|
}
|