42a5533a56
Security: - Replace all binding: tags with validate: + c.Validate() in admin handlers - Add rate limiting to auth endpoints (login, register, password reset) - Add security headers (HSTS, XSS protection, nosniff, frame options) - Wire Google Pub/Sub token verification into webhook handler - Replace ParseUnverified with proper OIDC/JWKS key verification - Verify inner Apple JWS signatures in webhook handler - Add io.LimitReader (1MB) to all webhook body reads - Add ownership verification to file deletion - Move hardcoded admin credentials to env vars - Add uniqueIndex to User.Email - Hide ConfirmationCode from JSON serialization - Mask confirmation codes in admin responses - Use http.DetectContentType for upload validation - Fix path traversal in storage service - Replace os.Getenv with Viper in stripe service - Sanitize Redis URLs before logging - Separate DEBUG_FIXED_CODES from DEBUG flag - Reject weak SECRET_KEY in production - Add host check on /_next/* proxy routes - Use explicit localhost CORS origins in debug mode - Replace err.Error() with generic messages in all admin error responses Critical fixes: - Rewrite FCM to HTTP v1 API with OAuth 2.0 service account auth - Fix user_customuser -> auth_user table names in raw SQL - Fix dashboard verified query to use UserProfile model - Add escapeLikeWildcards() to prevent SQL wildcard injection Bug fixes: - Add bounds checks for days/expiring_soon query params (1-3650) - Add receipt_data/transaction_id empty-check to RestoreSubscription - Change Active bool -> *bool in device handler - Check all unchecked GORM/FindByIDWithProfile errors - Add validation for notification hour fields (0-23) - Add max=10000 validation on task description updates Transactions & data integrity: - Wrap registration flow in transaction - Wrap QuickComplete in transaction - Move image creation inside completion transaction - Wrap SetSpecialties in transaction - Wrap GetOrCreateToken in transaction - Wrap completion+image deletion in transaction Performance: - Batch completion summaries (2 queries vs 2N) - Reuse single http.Client in IAP validation - Cache dashboard counts (30s TTL) - Batch COUNT queries in admin user list - Add Limit(500) to document queries - Add reminder_stage+due_date filters to reminder queries - Parse AllowedTypes once at init - In-memory user cache in auth middleware (30s TTL) - Timezone change detection cache - Optimize P95 with per-endpoint sorted buffers - Replace crypto/md5 with hash/fnv for ETags Code quality: - Add sync.Once to all monitoring Stop()/Close() methods - Replace 8 fmt.Printf with zerolog in auth service - Log previously discarded errors - Standardize delete response shapes - Route hardcoded English through i18n - Remove FileURL from DocumentResponse (keep MediaURL only) - Thread user timezone through kanban board responses - Initialize empty slices to prevent null JSON - Extract shared field map for task Update/UpdateTx - Delete unused SoftDeleteModel, min(), formatCron, legacy handlers Worker & jobs: - Wire Asynq email infrastructure into worker - Register HandleReminderLogCleanup with daily 3AM cron - Use per-user timezone in HandleSmartReminder - Replace direct DB queries with repository calls - Delete legacy reminder handlers (~200 lines) - Delete unused task type constants Dependencies: - Replace archived jung-kurt/gofpdf with go-pdf/fpdf - Replace unmaintained gomail.v2 with wneessen/go-mail - Add TODO for Echo jwt v3 transitive dep removal Test infrastructure: - Fix MakeRequest/SeedLookupData error handling - Replace os.Exit(0) with t.Skip() in scope/consistency tests - Add 11 new FCM v1 tests Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
69 lines
2.2 KiB
Go
69 lines
2.2 KiB
Go
package middleware
|
|
|
|
import (
|
|
"net/http"
|
|
"time"
|
|
|
|
"github.com/labstack/echo/v4"
|
|
"github.com/labstack/echo/v4/middleware"
|
|
"golang.org/x/time/rate"
|
|
|
|
"github.com/treytartt/honeydue-api/internal/dto/responses"
|
|
)
|
|
|
|
// AuthRateLimiter returns rate-limiting middleware tuned for authentication
|
|
// endpoints. It uses Echo's built-in in-memory rate limiter keyed by client
|
|
// IP address.
|
|
//
|
|
// Parameters:
|
|
// - ratePerSecond: sustained request rate (e.g., 10/60.0 for ~10 per minute)
|
|
// - burst: maximum burst size above the sustained rate
|
|
func AuthRateLimiter(ratePerSecond rate.Limit, burst int) echo.MiddlewareFunc {
|
|
store := middleware.NewRateLimiterMemoryStoreWithConfig(
|
|
middleware.RateLimiterMemoryStoreConfig{
|
|
Rate: ratePerSecond,
|
|
Burst: burst,
|
|
ExpiresIn: 5 * time.Minute,
|
|
},
|
|
)
|
|
|
|
return middleware.RateLimiterWithConfig(middleware.RateLimiterConfig{
|
|
Skipper: middleware.DefaultSkipper,
|
|
IdentifierExtractor: func(c echo.Context) (string, error) {
|
|
return c.RealIP(), nil
|
|
},
|
|
Store: store,
|
|
DenyHandler: func(c echo.Context, _ string, _ error) error {
|
|
return c.JSON(http.StatusTooManyRequests, responses.ErrorResponse{
|
|
Error: "Too many requests. Please try again later.",
|
|
})
|
|
},
|
|
ErrorHandler: func(c echo.Context, err error) error {
|
|
return c.JSON(http.StatusForbidden, responses.ErrorResponse{
|
|
Error: "Unable to process request.",
|
|
})
|
|
},
|
|
})
|
|
}
|
|
|
|
// LoginRateLimiter returns rate-limiting middleware for login endpoints.
|
|
// Allows 10 requests per minute with a burst of 5.
|
|
func LoginRateLimiter() echo.MiddlewareFunc {
|
|
// 10 requests per 60 seconds = ~0.167 req/s, burst 5
|
|
return AuthRateLimiter(rate.Limit(10.0/60.0), 5)
|
|
}
|
|
|
|
// RegistrationRateLimiter returns rate-limiting middleware for registration
|
|
// endpoints. Allows 5 requests per minute with a burst of 3.
|
|
func RegistrationRateLimiter() echo.MiddlewareFunc {
|
|
// 5 requests per 60 seconds = ~0.083 req/s, burst 3
|
|
return AuthRateLimiter(rate.Limit(5.0/60.0), 3)
|
|
}
|
|
|
|
// PasswordResetRateLimiter returns rate-limiting middleware for password
|
|
// reset endpoints. Allows 3 requests per minute with a burst of 2.
|
|
func PasswordResetRateLimiter() echo.MiddlewareFunc {
|
|
// 3 requests per 60 seconds = 0.05 req/s, burst 2
|
|
return AuthRateLimiter(rate.Limit(3.0/60.0), 2)
|
|
}
|