Security: - Replace all binding: tags with validate: + c.Validate() in admin handlers - Add rate limiting to auth endpoints (login, register, password reset) - Add security headers (HSTS, XSS protection, nosniff, frame options) - Wire Google Pub/Sub token verification into webhook handler - Replace ParseUnverified with proper OIDC/JWKS key verification - Verify inner Apple JWS signatures in webhook handler - Add io.LimitReader (1MB) to all webhook body reads - Add ownership verification to file deletion - Move hardcoded admin credentials to env vars - Add uniqueIndex to User.Email - Hide ConfirmationCode from JSON serialization - Mask confirmation codes in admin responses - Use http.DetectContentType for upload validation - Fix path traversal in storage service - Replace os.Getenv with Viper in stripe service - Sanitize Redis URLs before logging - Separate DEBUG_FIXED_CODES from DEBUG flag - Reject weak SECRET_KEY in production - Add host check on /_next/* proxy routes - Use explicit localhost CORS origins in debug mode - Replace err.Error() with generic messages in all admin error responses Critical fixes: - Rewrite FCM to HTTP v1 API with OAuth 2.0 service account auth - Fix user_customuser -> auth_user table names in raw SQL - Fix dashboard verified query to use UserProfile model - Add escapeLikeWildcards() to prevent SQL wildcard injection Bug fixes: - Add bounds checks for days/expiring_soon query params (1-3650) - Add receipt_data/transaction_id empty-check to RestoreSubscription - Change Active bool -> *bool in device handler - Check all unchecked GORM/FindByIDWithProfile errors - Add validation for notification hour fields (0-23) - Add max=10000 validation on task description updates Transactions & data integrity: - Wrap registration flow in transaction - Wrap QuickComplete in transaction - Move image creation inside completion transaction - Wrap SetSpecialties in transaction - Wrap GetOrCreateToken in transaction - Wrap completion+image deletion in transaction Performance: - Batch completion summaries (2 queries vs 2N) - Reuse single http.Client in IAP validation - Cache dashboard counts (30s TTL) - Batch COUNT queries in admin user list - Add Limit(500) to document queries - Add reminder_stage+due_date filters to reminder queries - Parse AllowedTypes once at init - In-memory user cache in auth middleware (30s TTL) - Timezone change detection cache - Optimize P95 with per-endpoint sorted buffers - Replace crypto/md5 with hash/fnv for ETags Code quality: - Add sync.Once to all monitoring Stop()/Close() methods - Replace 8 fmt.Printf with zerolog in auth service - Log previously discarded errors - Standardize delete response shapes - Route hardcoded English through i18n - Remove FileURL from DocumentResponse (keep MediaURL only) - Thread user timezone through kanban board responses - Initialize empty slices to prevent null JSON - Extract shared field map for task Update/UpdateTx - Delete unused SoftDeleteModel, min(), formatCron, legacy handlers Worker & jobs: - Wire Asynq email infrastructure into worker - Register HandleReminderLogCleanup with daily 3AM cron - Use per-user timezone in HandleSmartReminder - Replace direct DB queries with repository calls - Delete legacy reminder handlers (~200 lines) - Delete unused task type constants Dependencies: - Replace archived jung-kurt/gofpdf with go-pdf/fpdf - Replace unmaintained gomail.v2 with wneessen/go-mail - Add TODO for Echo jwt v3 transitive dep removal Test infrastructure: - Fix MakeRequest/SeedLookupData error handling - Replace os.Exit(0) with t.Skip() in scope/consistency tests - Add 11 new FCM v1 tests Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
158 lines
4.7 KiB
Go
158 lines
4.7 KiB
Go
package push
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/rs/zerolog/log"
|
|
|
|
"github.com/treytartt/honeydue-api/internal/config"
|
|
)
|
|
|
|
// Platform constants
|
|
const (
|
|
PlatformIOS = "ios"
|
|
PlatformAndroid = "android"
|
|
)
|
|
|
|
// Client provides a unified interface for sending push notifications
|
|
type Client struct {
|
|
apns *APNsClient
|
|
fcm *FCMClient
|
|
enabled bool
|
|
}
|
|
|
|
// NewClient creates a new unified push notification client
|
|
func NewClient(cfg *config.PushConfig, enabled bool) (*Client, error) {
|
|
client := &Client{enabled: enabled}
|
|
|
|
// Initialize APNs client (iOS)
|
|
if cfg.APNSKeyPath != "" && cfg.APNSKeyID != "" && cfg.APNSTeamID != "" {
|
|
apnsClient, err := NewAPNsClient(cfg)
|
|
if err != nil {
|
|
log.Warn().Err(err).Msg("Failed to initialize APNs client - iOS push disabled")
|
|
} else {
|
|
client.apns = apnsClient
|
|
log.Info().Msg("APNs client initialized successfully")
|
|
}
|
|
} else {
|
|
log.Warn().Msg("APNs not configured - iOS push disabled")
|
|
}
|
|
|
|
// Initialize FCM client (Android) - requires project ID + service account credentials
|
|
if cfg.FCMProjectID != "" && (cfg.FCMServiceAccountPath != "" || cfg.FCMServiceAccountJSON != "") {
|
|
fcmClient, err := NewFCMClient(cfg)
|
|
if err != nil {
|
|
log.Warn().Err(err).Msg("Failed to initialize FCM v1 client - Android push disabled")
|
|
} else {
|
|
client.fcm = fcmClient
|
|
log.Info().Msg("FCM v1 client initialized successfully")
|
|
}
|
|
} else {
|
|
log.Warn().Msg("FCM not configured (need FCM_PROJECT_ID + FCM_SERVICE_ACCOUNT_PATH or FCM_SERVICE_ACCOUNT_JSON) - Android push disabled")
|
|
}
|
|
|
|
return client, nil
|
|
}
|
|
|
|
// SendToIOS sends a push notification to iOS devices
|
|
func (c *Client) SendToIOS(ctx context.Context, tokens []string, title, message string, data map[string]string) error {
|
|
if !c.enabled {
|
|
log.Debug().Msg("Push notifications disabled by feature flag")
|
|
return nil
|
|
}
|
|
if c.apns == nil {
|
|
log.Warn().Msg("APNs client not initialized, skipping iOS push")
|
|
return nil
|
|
}
|
|
return c.apns.Send(ctx, tokens, title, message, data)
|
|
}
|
|
|
|
// SendToAndroid sends a push notification to Android devices
|
|
func (c *Client) SendToAndroid(ctx context.Context, tokens []string, title, message string, data map[string]string) error {
|
|
if !c.enabled {
|
|
log.Debug().Msg("Push notifications disabled by feature flag")
|
|
return nil
|
|
}
|
|
if c.fcm == nil {
|
|
log.Warn().Msg("FCM client not initialized, skipping Android push")
|
|
return nil
|
|
}
|
|
return c.fcm.Send(ctx, tokens, title, message, data)
|
|
}
|
|
|
|
// SendToAll sends a push notification to both iOS and Android devices
|
|
func (c *Client) SendToAll(ctx context.Context, iosTokens, androidTokens []string, title, message string, data map[string]string) error {
|
|
if !c.enabled {
|
|
log.Debug().Msg("Push notifications disabled by feature flag")
|
|
return nil
|
|
}
|
|
var lastErr error
|
|
|
|
if len(iosTokens) > 0 {
|
|
if err := c.SendToIOS(ctx, iosTokens, title, message, data); err != nil {
|
|
log.Error().Err(err).Msg("Failed to send iOS notifications")
|
|
lastErr = err
|
|
}
|
|
}
|
|
|
|
if len(androidTokens) > 0 {
|
|
if err := c.SendToAndroid(ctx, androidTokens, title, message, data); err != nil {
|
|
log.Error().Err(err).Msg("Failed to send Android notifications")
|
|
lastErr = err
|
|
}
|
|
}
|
|
|
|
return lastErr
|
|
}
|
|
|
|
// IsIOSEnabled returns true if iOS push is configured
|
|
func (c *Client) IsIOSEnabled() bool {
|
|
return c.apns != nil
|
|
}
|
|
|
|
// IsAndroidEnabled returns true if Android push is configured
|
|
func (c *Client) IsAndroidEnabled() bool {
|
|
return c.fcm != nil
|
|
}
|
|
|
|
// SendActionableNotification sends notifications with action button support
|
|
// iOS receives a category for actionable notifications, Android handles actions via data payload
|
|
func (c *Client) SendActionableNotification(ctx context.Context, iosTokens, androidTokens []string, title, message string, data map[string]string, iosCategoryID string) error {
|
|
if !c.enabled {
|
|
log.Debug().Msg("Push notifications disabled by feature flag")
|
|
return nil
|
|
}
|
|
var lastErr error
|
|
|
|
if len(iosTokens) > 0 {
|
|
if c.apns == nil {
|
|
log.Warn().Msg("APNs client not initialized, skipping iOS actionable push")
|
|
} else {
|
|
if err := c.apns.SendWithCategory(ctx, iosTokens, title, message, data, iosCategoryID); err != nil {
|
|
log.Error().Err(err).Msg("Failed to send iOS actionable notifications")
|
|
lastErr = err
|
|
}
|
|
}
|
|
}
|
|
|
|
if len(androidTokens) > 0 {
|
|
// Android handles actions via data payload - existing send works
|
|
if err := c.SendToAndroid(ctx, androidTokens, title, message, data); err != nil {
|
|
log.Error().Err(err).Msg("Failed to send Android notifications")
|
|
lastErr = err
|
|
}
|
|
}
|
|
|
|
return lastErr
|
|
}
|
|
|
|
// HealthCheck checks if the push services are available
|
|
func (c *Client) HealthCheck(ctx context.Context) error {
|
|
// For direct clients, we can't easily health check without sending a notification
|
|
// Return nil if at least one platform is configured
|
|
if c.apns != nil || c.fcm != nil {
|
|
return nil
|
|
}
|
|
return nil
|
|
}
|