Security: - Replace all binding: tags with validate: + c.Validate() in admin handlers - Add rate limiting to auth endpoints (login, register, password reset) - Add security headers (HSTS, XSS protection, nosniff, frame options) - Wire Google Pub/Sub token verification into webhook handler - Replace ParseUnverified with proper OIDC/JWKS key verification - Verify inner Apple JWS signatures in webhook handler - Add io.LimitReader (1MB) to all webhook body reads - Add ownership verification to file deletion - Move hardcoded admin credentials to env vars - Add uniqueIndex to User.Email - Hide ConfirmationCode from JSON serialization - Mask confirmation codes in admin responses - Use http.DetectContentType for upload validation - Fix path traversal in storage service - Replace os.Getenv with Viper in stripe service - Sanitize Redis URLs before logging - Separate DEBUG_FIXED_CODES from DEBUG flag - Reject weak SECRET_KEY in production - Add host check on /_next/* proxy routes - Use explicit localhost CORS origins in debug mode - Replace err.Error() with generic messages in all admin error responses Critical fixes: - Rewrite FCM to HTTP v1 API with OAuth 2.0 service account auth - Fix user_customuser -> auth_user table names in raw SQL - Fix dashboard verified query to use UserProfile model - Add escapeLikeWildcards() to prevent SQL wildcard injection Bug fixes: - Add bounds checks for days/expiring_soon query params (1-3650) - Add receipt_data/transaction_id empty-check to RestoreSubscription - Change Active bool -> *bool in device handler - Check all unchecked GORM/FindByIDWithProfile errors - Add validation for notification hour fields (0-23) - Add max=10000 validation on task description updates Transactions & data integrity: - Wrap registration flow in transaction - Wrap QuickComplete in transaction - Move image creation inside completion transaction - Wrap SetSpecialties in transaction - Wrap GetOrCreateToken in transaction - Wrap completion+image deletion in transaction Performance: - Batch completion summaries (2 queries vs 2N) - Reuse single http.Client in IAP validation - Cache dashboard counts (30s TTL) - Batch COUNT queries in admin user list - Add Limit(500) to document queries - Add reminder_stage+due_date filters to reminder queries - Parse AllowedTypes once at init - In-memory user cache in auth middleware (30s TTL) - Timezone change detection cache - Optimize P95 with per-endpoint sorted buffers - Replace crypto/md5 with hash/fnv for ETags Code quality: - Add sync.Once to all monitoring Stop()/Close() methods - Replace 8 fmt.Printf with zerolog in auth service - Log previously discarded errors - Standardize delete response shapes - Route hardcoded English through i18n - Remove FileURL from DocumentResponse (keep MediaURL only) - Thread user timezone through kanban board responses - Initialize empty slices to prevent null JSON - Extract shared field map for task Update/UpdateTx - Delete unused SoftDeleteModel, min(), formatCron, legacy handlers Worker & jobs: - Wire Asynq email infrastructure into worker - Register HandleReminderLogCleanup with daily 3AM cron - Use per-user timezone in HandleSmartReminder - Replace direct DB queries with repository calls - Delete legacy reminder handlers (~200 lines) - Delete unused task type constants Dependencies: - Replace archived jung-kurt/gofpdf with go-pdf/fpdf - Replace unmaintained gomail.v2 with wneessen/go-mail - Add TODO for Echo jwt v3 transitive dep removal Test infrastructure: - Fix MakeRequest/SeedLookupData error handling - Replace os.Exit(0) with t.Skip() in scope/consistency tests - Add 11 new FCM v1 tests Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
141 lines
4.4 KiB
Go
141 lines
4.4 KiB
Go
package handlers
|
|
|
|
import (
|
|
"net/http"
|
|
|
|
"github.com/labstack/echo/v4"
|
|
|
|
"github.com/treytartt/honeydue-api/internal/config"
|
|
"github.com/treytartt/honeydue-api/internal/middleware"
|
|
"github.com/treytartt/honeydue-api/internal/models"
|
|
"github.com/treytartt/honeydue-api/internal/repositories"
|
|
)
|
|
|
|
// AdminAuthHandler handles admin authentication endpoints
|
|
type AdminAuthHandler struct {
|
|
adminRepo *repositories.AdminRepository
|
|
cfg *config.Config
|
|
}
|
|
|
|
// NewAdminAuthHandler creates a new admin auth handler
|
|
func NewAdminAuthHandler(adminRepo *repositories.AdminRepository, cfg *config.Config) *AdminAuthHandler {
|
|
return &AdminAuthHandler{
|
|
adminRepo: adminRepo,
|
|
cfg: cfg,
|
|
}
|
|
}
|
|
|
|
// LoginRequest represents the admin login request
|
|
type LoginRequest struct {
|
|
Email string `json:"email" validate:"required,email"`
|
|
Password string `json:"password" validate:"required"`
|
|
}
|
|
|
|
// LoginResponse represents the admin login response
|
|
type LoginResponse struct {
|
|
Token string `json:"token"`
|
|
Admin AdminUserResponse `json:"admin"`
|
|
}
|
|
|
|
// AdminUserResponse represents an admin user in API responses
|
|
type AdminUserResponse struct {
|
|
ID uint `json:"id"`
|
|
Email string `json:"email"`
|
|
FirstName string `json:"first_name"`
|
|
LastName string `json:"last_name"`
|
|
Role models.AdminRole `json:"role"`
|
|
IsActive bool `json:"is_active"`
|
|
LastLogin *string `json:"last_login,omitempty"`
|
|
CreatedAt string `json:"created_at"`
|
|
}
|
|
|
|
// NewAdminUserResponse creates an AdminUserResponse from an AdminUser model
|
|
func NewAdminUserResponse(admin *models.AdminUser) AdminUserResponse {
|
|
resp := AdminUserResponse{
|
|
ID: admin.ID,
|
|
Email: admin.Email,
|
|
FirstName: admin.FirstName,
|
|
LastName: admin.LastName,
|
|
Role: admin.Role,
|
|
IsActive: admin.IsActive,
|
|
CreatedAt: admin.CreatedAt.Format("2006-01-02T15:04:05Z"),
|
|
}
|
|
if admin.LastLogin != nil {
|
|
lastLogin := admin.LastLogin.Format("2006-01-02T15:04:05Z")
|
|
resp.LastLogin = &lastLogin
|
|
}
|
|
return resp
|
|
}
|
|
|
|
// Login handles POST /api/admin/auth/login
|
|
func (h *AdminAuthHandler) Login(c echo.Context) error {
|
|
var req LoginRequest
|
|
if err := c.Bind(&req); err != nil {
|
|
return c.JSON(http.StatusBadRequest, map[string]interface{}{"error": "Invalid request body"})
|
|
}
|
|
if err := c.Validate(&req); err != nil {
|
|
return err
|
|
}
|
|
|
|
// Find admin by email
|
|
admin, err := h.adminRepo.FindByEmail(req.Email)
|
|
if err != nil {
|
|
return c.JSON(http.StatusUnauthorized, map[string]interface{}{"error": "Invalid email or password"})
|
|
}
|
|
|
|
// Check password
|
|
if !admin.CheckPassword(req.Password) {
|
|
return c.JSON(http.StatusUnauthorized, map[string]interface{}{"error": "Invalid email or password"})
|
|
}
|
|
|
|
// Check if admin is active
|
|
if !admin.IsActive {
|
|
return c.JSON(http.StatusUnauthorized, map[string]interface{}{"error": "Account is disabled"})
|
|
}
|
|
|
|
// Generate JWT token
|
|
token, err := middleware.GenerateAdminToken(admin, h.cfg)
|
|
if err != nil {
|
|
return c.JSON(http.StatusInternalServerError, map[string]interface{}{"error": "Failed to generate token"})
|
|
}
|
|
|
|
// Update last login
|
|
_ = h.adminRepo.UpdateLastLogin(admin.ID)
|
|
|
|
// Refresh admin data after updating last login
|
|
admin, err = h.adminRepo.FindByID(admin.ID)
|
|
if err != nil {
|
|
return c.JSON(http.StatusInternalServerError, map[string]interface{}{"error": "Failed to refresh admin data"})
|
|
}
|
|
|
|
return c.JSON(http.StatusOK, LoginResponse{
|
|
Token: token,
|
|
Admin: NewAdminUserResponse(admin),
|
|
})
|
|
}
|
|
|
|
// Logout handles POST /api/admin/auth/logout
|
|
// Note: JWT tokens are stateless, so logout is handled client-side by removing the token
|
|
func (h *AdminAuthHandler) Logout(c echo.Context) error {
|
|
return c.JSON(http.StatusOK, map[string]interface{}{"message": "Logged out successfully"})
|
|
}
|
|
|
|
// Me handles GET /api/admin/auth/me
|
|
func (h *AdminAuthHandler) Me(c echo.Context) error {
|
|
admin := c.Get(middleware.AdminUserKey).(*models.AdminUser)
|
|
return c.JSON(http.StatusOK, NewAdminUserResponse(admin))
|
|
}
|
|
|
|
// RefreshToken handles POST /api/admin/auth/refresh
|
|
func (h *AdminAuthHandler) RefreshToken(c echo.Context) error {
|
|
admin := c.Get(middleware.AdminUserKey).(*models.AdminUser)
|
|
|
|
// Generate new token
|
|
token, err := middleware.GenerateAdminToken(admin, h.cfg)
|
|
if err != nil {
|
|
return c.JSON(http.StatusInternalServerError, map[string]interface{}{"error": "Failed to generate token"})
|
|
}
|
|
|
|
return c.JSON(http.StatusOK, map[string]interface{}{"token": token})
|
|
}
|