Security: - Replace all binding: tags with validate: + c.Validate() in admin handlers - Add rate limiting to auth endpoints (login, register, password reset) - Add security headers (HSTS, XSS protection, nosniff, frame options) - Wire Google Pub/Sub token verification into webhook handler - Replace ParseUnverified with proper OIDC/JWKS key verification - Verify inner Apple JWS signatures in webhook handler - Add io.LimitReader (1MB) to all webhook body reads - Add ownership verification to file deletion - Move hardcoded admin credentials to env vars - Add uniqueIndex to User.Email - Hide ConfirmationCode from JSON serialization - Mask confirmation codes in admin responses - Use http.DetectContentType for upload validation - Fix path traversal in storage service - Replace os.Getenv with Viper in stripe service - Sanitize Redis URLs before logging - Separate DEBUG_FIXED_CODES from DEBUG flag - Reject weak SECRET_KEY in production - Add host check on /_next/* proxy routes - Use explicit localhost CORS origins in debug mode - Replace err.Error() with generic messages in all admin error responses Critical fixes: - Rewrite FCM to HTTP v1 API with OAuth 2.0 service account auth - Fix user_customuser -> auth_user table names in raw SQL - Fix dashboard verified query to use UserProfile model - Add escapeLikeWildcards() to prevent SQL wildcard injection Bug fixes: - Add bounds checks for days/expiring_soon query params (1-3650) - Add receipt_data/transaction_id empty-check to RestoreSubscription - Change Active bool -> *bool in device handler - Check all unchecked GORM/FindByIDWithProfile errors - Add validation for notification hour fields (0-23) - Add max=10000 validation on task description updates Transactions & data integrity: - Wrap registration flow in transaction - Wrap QuickComplete in transaction - Move image creation inside completion transaction - Wrap SetSpecialties in transaction - Wrap GetOrCreateToken in transaction - Wrap completion+image deletion in transaction Performance: - Batch completion summaries (2 queries vs 2N) - Reuse single http.Client in IAP validation - Cache dashboard counts (30s TTL) - Batch COUNT queries in admin user list - Add Limit(500) to document queries - Add reminder_stage+due_date filters to reminder queries - Parse AllowedTypes once at init - In-memory user cache in auth middleware (30s TTL) - Timezone change detection cache - Optimize P95 with per-endpoint sorted buffers - Replace crypto/md5 with hash/fnv for ETags Code quality: - Add sync.Once to all monitoring Stop()/Close() methods - Replace 8 fmt.Printf with zerolog in auth service - Log previously discarded errors - Standardize delete response shapes - Route hardcoded English through i18n - Remove FileURL from DocumentResponse (keep MediaURL only) - Thread user timezone through kanban board responses - Initialize empty slices to prevent null JSON - Extract shared field map for task Update/UpdateTx - Delete unused SoftDeleteModel, min(), formatCron, legacy handlers Worker & jobs: - Wire Asynq email infrastructure into worker - Register HandleReminderLogCleanup with daily 3AM cron - Use per-user timezone in HandleSmartReminder - Replace direct DB queries with repository calls - Delete legacy reminder handlers (~200 lines) - Delete unused task type constants Dependencies: - Replace archived jung-kurt/gofpdf with go-pdf/fpdf - Replace unmaintained gomail.v2 with wneessen/go-mail - Add TODO for Echo jwt v3 transitive dep removal Test infrastructure: - Fix MakeRequest/SeedLookupData error handling - Replace os.Exit(0) with t.Skip() in scope/consistency tests - Add 11 new FCM v1 tests Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
139 lines
3.2 KiB
Go
139 lines
3.2 KiB
Go
package utils
|
|
|
|
import (
|
|
"io"
|
|
"net/http"
|
|
"os"
|
|
"runtime/debug"
|
|
"time"
|
|
|
|
"github.com/labstack/echo/v4"
|
|
"github.com/rs/zerolog"
|
|
"github.com/rs/zerolog/log"
|
|
|
|
"github.com/treytartt/honeydue-api/internal/dto/responses"
|
|
)
|
|
|
|
// InitLogger initializes the zerolog logger
|
|
func InitLogger(debug bool) {
|
|
InitLoggerWithWriter(debug, nil)
|
|
}
|
|
|
|
// InitLoggerWithWriter initializes the zerolog logger with an optional additional writer
|
|
// The additional writer receives JSON formatted logs (useful for monitoring)
|
|
func InitLoggerWithWriter(debug bool, additionalWriter io.Writer) {
|
|
zerolog.TimeFieldFormat = time.RFC3339
|
|
|
|
if debug {
|
|
zerolog.SetGlobalLevel(zerolog.DebugLevel)
|
|
} else {
|
|
zerolog.SetGlobalLevel(zerolog.InfoLevel)
|
|
}
|
|
|
|
// Build the output writer(s)
|
|
var output io.Writer
|
|
|
|
if additionalWriter != nil {
|
|
// Always write JSON to additional writer for monitoring
|
|
// The additional writer parses JSON to extract log entries
|
|
if debug {
|
|
// In debug mode: pretty console to stdout + JSON to additional writer
|
|
consoleOutput := zerolog.ConsoleWriter{
|
|
Out: os.Stdout,
|
|
TimeFormat: "15:04:05",
|
|
}
|
|
output = io.MultiWriter(consoleOutput, additionalWriter)
|
|
} else {
|
|
// In production: JSON to both stdout and additional writer
|
|
output = io.MultiWriter(os.Stdout, additionalWriter)
|
|
}
|
|
} else {
|
|
if debug {
|
|
output = zerolog.ConsoleWriter{
|
|
Out: os.Stdout,
|
|
TimeFormat: "15:04:05",
|
|
}
|
|
} else {
|
|
output = os.Stdout
|
|
}
|
|
}
|
|
|
|
log.Logger = zerolog.New(output).With().Timestamp().Caller().Logger()
|
|
}
|
|
|
|
// EchoLogger returns an Echo middleware for request logging
|
|
func EchoLogger() echo.MiddlewareFunc {
|
|
return func(next echo.HandlerFunc) echo.HandlerFunc {
|
|
return func(c echo.Context) error {
|
|
start := time.Now()
|
|
req := c.Request()
|
|
path := req.URL.Path
|
|
raw := req.URL.RawQuery
|
|
|
|
// Process request
|
|
err := next(c)
|
|
|
|
// Log after request
|
|
end := time.Now()
|
|
latency := end.Sub(start)
|
|
|
|
if raw != "" {
|
|
path = path + "?" + raw
|
|
}
|
|
|
|
res := c.Response()
|
|
statusCode := res.Status
|
|
|
|
msg := "Request"
|
|
if err != nil {
|
|
msg = err.Error()
|
|
}
|
|
|
|
event := log.Info()
|
|
|
|
if statusCode >= 400 && statusCode < 500 {
|
|
event = log.Warn()
|
|
} else if statusCode >= 500 {
|
|
event = log.Error()
|
|
}
|
|
|
|
event.
|
|
Str("method", req.Method).
|
|
Str("path", path).
|
|
Int("status", statusCode).
|
|
Str("ip", c.RealIP()).
|
|
Dur("latency", latency).
|
|
Str("user-agent", req.UserAgent()).
|
|
Msg(msg)
|
|
|
|
return err
|
|
}
|
|
}
|
|
}
|
|
|
|
// EchoRecovery returns an Echo middleware for panic recovery
|
|
func EchoRecovery() echo.MiddlewareFunc {
|
|
return func(next echo.HandlerFunc) echo.HandlerFunc {
|
|
return func(c echo.Context) error {
|
|
defer func() {
|
|
if err := recover(); err != nil {
|
|
// F-14: Include full stack trace for debugging
|
|
log.Error().
|
|
Interface("error", err).
|
|
Str("path", c.Request().URL.Path).
|
|
Str("method", c.Request().Method).
|
|
Str("stack", string(debug.Stack())).
|
|
Msg("Panic recovered")
|
|
|
|
// F-15: Use the project's standard ErrorResponse struct
|
|
c.JSON(http.StatusInternalServerError, responses.ErrorResponse{
|
|
Error: "Internal server error",
|
|
})
|
|
}
|
|
}()
|
|
|
|
return next(c)
|
|
}
|
|
}
|
|
}
|