c80c66c2e5
Deep audit identified 106 findings; 102 fixed, 4 deferred. Covers 8 areas: - Settings & deploy: env-gated DEBUG/SECRET_KEY, HTTPS headers, gunicorn, celery worker - Auth (registered_user): password write_only, request.data fixes, transaction safety, proper HTTP status codes - Workout app: IDOR protection, get_object_or_404, prefetch_related N+1 fixes, transaction.atomic - Video/scripts: path traversal sanitization, HLS trigger guard, auth on cache wipe - Models (exercise/equipment/muscle/superset): null-safe __str__, stable IDs, prefetch support - Generator views: helper for registered_user lookup, logger.exception, bulk_update, transaction wrapping - Generator core (rules/selector/generator): push-pull ratio, type affinity normalization, modality checks, side-pair exact match, word-boundary regex, equipment cache clearing - Generator services (plan_builder/analyzer/normalizer): transaction.atomic, muscle cache, bulk_update, glutes classification fix Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
39 lines
1.7 KiB
Python
39 lines
1.7 KiB
Python
from rest_framework import serializers
|
|
from .models import *
|
|
from muscle.models import ExerciseMuscle
|
|
from equipment.models import WorkoutEquipment
|
|
from equipment.serializers import WorkoutEquipmentSerializer
|
|
|
|
class ExerciseMuscleSerializer(serializers.ModelSerializer):
|
|
name = serializers.SerializerMethodField()
|
|
|
|
class Meta:
|
|
model = ExerciseMuscle
|
|
fields = '__all__'
|
|
|
|
def get_name(self, obj):
|
|
return obj.muscle.name
|
|
|
|
class ExerciseSerializer(serializers.ModelSerializer):
|
|
muscles = serializers.SerializerMethodField()
|
|
equipment = serializers.SerializerMethodField()
|
|
audio_url = serializers.ReadOnlyField()
|
|
video_url = serializers.ReadOnlyField()
|
|
transition_url = serializers.ReadOnlyField()
|
|
|
|
class Meta:
|
|
model = Exercise
|
|
fields = '__all__'
|
|
|
|
def get_muscles(self, obj):
|
|
# Use prefetched data if available, avoiding N+1 queries
|
|
if hasattr(obj, '_prefetched_objects_cache') and 'exercise_muscle_exercise' in obj._prefetched_objects_cache:
|
|
return [{'muscle': em.muscle_id, 'name': em.muscle.name} for em in obj.exercise_muscle_exercise.all()]
|
|
return list(obj.exercise_muscle_exercise.values('muscle', name=models.F('muscle__name')))
|
|
|
|
def get_equipment(self, obj):
|
|
# Use prefetched data if available, avoiding N+1 queries
|
|
if hasattr(obj, '_prefetched_objects_cache') and 'workout_exercise_workout' in obj._prefetched_objects_cache:
|
|
return [{'equipment': we.equipment_id, 'name': we.equipment.name} for we in obj.workout_exercise_workout.all()]
|
|
return list(obj.workout_exercise_workout.values('equipment', name=models.F('equipment__name')))
|