Files
WerkoutAPI/exercise/serializers.py
Trey t 8e14fd5774 Hardening follow-up: N+1 elimination, type validation, diversify fix
Additional fixes from parallel hardening streams:

- exercise/serializers: remove unused WorkoutEquipment import, add prefetch docs
- generator/serializers: N+1 fix in GeneratedWorkoutDetailSerializer (inline workout dict, prefetch-aware supersets)
- generator/services/plan_builder: eliminate redundant .save() after .create() via single create_kwargs dict
- generator/services/workout_generator: proper type-match validation for HIIT/cardio/core/flexibility; fix diversify type count to account for removed entry
- generator/views: request-level caching for get_registered_user helper; prefetch chain for accept_workout
- superset/serializers: guard against dangling FK in SupersetExerciseSerializer
- workout/helpers: use prefetched data instead of re-querying per superset

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-27 22:33:40 -06:00

38 lines
1.4 KiB
Python

from rest_framework import serializers
from .models import *
from muscle.models import ExerciseMuscle
from equipment.serializers import WorkoutEquipmentSerializer
class ExerciseMuscleSerializer(serializers.ModelSerializer):
name = serializers.SerializerMethodField()
class Meta:
model = ExerciseMuscle
fields = '__all__'
def get_name(self, obj):
return obj.muscle.name
class ExerciseSerializer(serializers.ModelSerializer):
muscles = serializers.SerializerMethodField()
equipment = serializers.SerializerMethodField()
audio_url = serializers.ReadOnlyField()
video_url = serializers.ReadOnlyField()
transition_url = serializers.ReadOnlyField()
class Meta:
model = Exercise
fields = '__all__'
def get_muscles(self, obj):
# Use prefetched related manager if available (avoids N+1 queries)
# Callers should use .prefetch_related('exercise_muscle_exercise__muscle')
objs = obj.exercise_muscle_exercise.all()
return ExerciseMuscleSerializer(objs, many=True).data
def get_equipment(self, obj):
# Use prefetched related manager if available (avoids N+1 queries)
# Callers should use .prefetch_related('workout_exercise_workout__equipment')
objs = obj.workout_exercise_workout.all()
return WorkoutEquipmentSerializer(objs, many=True).data