Refactor travel segments and simplify trip options

Travel segment architecture:
- Remove departureTime/arrivalTime from TravelSegment (location-based, not date-based)
- Fix travel sections appearing after destination instead of between cities
- Fix missing travel segments when revisiting same city (consecutive grouping)
- Remove unwanted rest day at end of trip

Planning engine fixes:
- All three planners now group only consecutive games at same stadium
- Visiting A → B → A creates 3 stops with proper travel between

UI simplification:
- Remove redundant sort options (mostDriving/leastDriving, mostCities/leastCities)
- Remove unused "Find Other Sports Along Route" toggle (was dead code)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Trey t
2026-01-07 19:39:53 -06:00
parent 40a6f879e3
commit 4184af60b5
29 changed files with 140675 additions and 144310 deletions

View File

@@ -244,10 +244,10 @@ enum TimelineItem: Identifiable {
}
}
var date: Date {
var date: Date? {
switch self {
case .stop(let stop): return stop.arrivalDate
case .travel(let segment): return segment.departureTime
case .travel: return nil // Travel is location-based, not date-based
case .rest(let rest): return rest.date
}
}
@@ -337,16 +337,9 @@ extension ItineraryOption {
// Add travel segment to next stop (if not last stop)
if index < travelSegments.count {
let segment = travelSegments[index]
// Check if travel spans multiple days
let travelDays = calculateTravelDays(for: segment, calendar: calendar)
if travelDays.count > 1 {
// Multi-day travel: could split into daily segments or keep as one
// For now, keep as single segment with multi-day indicator
timeline.append(.travel(segment))
} else {
timeline.append(.travel(segment))
}
// Travel is location-based - just add the segment
// Multi-day travel indicated by durationHours > 8
timeline.append(.travel(segment))
}
}
@@ -391,31 +384,16 @@ extension ItineraryOption {
return restDays
}
/// Calculates which calendar days a travel segment spans.
private func calculateTravelDays(
for segment: TravelSegment,
calendar: Calendar
) -> [Date] {
var days: [Date] = []
let startDay = calendar.startOfDay(for: segment.departureTime)
let endDay = calendar.startOfDay(for: segment.arrivalTime)
var currentDay = startDay
while currentDay <= endDay {
days.append(currentDay)
currentDay = calendar.date(byAdding: .day, value: 1, to: currentDay) ?? currentDay
}
return days
}
/// Timeline organized by date for calendar-style display.
/// Note: Travel segments are excluded as they are location-based, not date-based.
func timelineByDate() -> [Date: [TimelineItem]] {
let calendar = Calendar.current
var byDate: [Date: [TimelineItem]] = [:]
for item in generateTimeline() {
let day = calendar.startOfDay(for: item.date)
// Skip travel items - they don't have dates
guard let itemDate = item.date else { continue }
let day = calendar.startOfDay(for: itemDate)
byDate[day, default: []].append(item)
}