Files
Reflect/Tests iOS/OnboardingTests.swift
Trey T d97db4910e Rewrite all UI tests following fail-fast TEST_RULES patterns
Rewrote 60+ test files to follow honeydue-style test guidelines:
- defaultTimeout=2s, navigationTimeout=5s — fail fast, no long waits
- No coordinate taps (except onboarding paged TabView swipes)
- No sleep(), no retry loops
- No guard...else { return } silent passes — XCTFail everywhere
- All elements by accessibility ID via UITestID constants
- Screen objects for all navigation/actions/assertions
- One logical assertion per test method

Added missing accessibility identifiers to app views:
- MonthView.swift: added AccessibilityID.MonthView.grid to ScrollView
- YearView.swift: added AccessibilityID.YearView.heatmap to ScrollView

Framework rewrites:
- BaseUITestCase: added session ID, localeArguments, extraLaunchArguments
- WaitHelpers: waitForExistenceOrFail, waitUntilHittableOrFail,
  waitForNonExistence, scrollIntoView, forceTap
- All 7 screen objects rewritten with fail-fast semantics
- TEST_RULES.md added with non-negotiable rules

Known remaining issues:
- OnboardingTests: paged TabView swipes unreliable on iOS 26 simulator
- SettingsLegalLinksTests: EULA/Privacy buttons too deep in DEBUG scroll
- Customization horizontal picker scrolling needs further tuning

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-24 17:00:30 -05:00

51 lines
1.5 KiB
Swift

//
// OnboardingTests.swift
// Tests iOS
//
// Onboarding flow completion and non-repetition tests.
//
import XCTest
final class OnboardingTests: BaseUITestCase {
override var seedFixture: String? { "empty" }
override var skipOnboarding: Bool { false }
/// TC-120: Complete the full onboarding flow.
func testOnboarding_CompleteFlow() {
let onboarding = OnboardingScreen(app: app)
onboarding.assertVisible()
captureScreenshot(name: "onboarding_welcome")
onboarding.completeOnboarding()
onboarding.assertDismissed()
captureScreenshot(name: "onboarding_complete")
}
/// TC-121: After completing onboarding, relaunch should go directly to Day view.
func testOnboarding_DoesNotRepeatAfterCompletion() {
let onboarding = OnboardingScreen(app: app)
onboarding.assertVisible()
onboarding.completeOnboarding()
onboarding.assertDismissed()
// Relaunch preserving state -- onboarding should not repeat
relaunchPreservingState()
// Tab bar should appear immediately (no onboarding)
let tabBar = TabBarScreen(app: app)
tabBar.assertVisible()
// Welcome screen should NOT appear
let welcomeAgain = app.element(UITestID.Onboarding.welcome)
XCTAssertFalse(
welcomeAgain.waitForExistence(timeout: defaultTimeout),
"Onboarding should not appear on second launch"
)
captureScreenshot(name: "no_onboarding_on_relaunch")
}
}