Merge pull request 'fix: completed tasks reappearing as overdue (#2)' (#4) from fix/issue-2-task-completion-persistence into master

Reviewed-on: #4

PlantGuide/Presentation/Scenes/Identification/IdentificationView.swift

@@ -19,6 +19,11 @@ struct IdentificationView: View {
     /// Tracks whether we've announced results to avoid duplicate announcements
     @State private var hasAnnouncedResults = false
 
+    /// Local state to reliably drive the save button's enabled/disabled state.
+    /// Works around an @Observable + @State tracking issue where computed
+    /// properties in view modifiers don't always trigger re-renders.
+    @State private var saveEnabled = false
+
     // MARK: - Scaled Metrics for Dynamic Type
 
     @ScaledMetric(relativeTo: .body) private var closeIconSize: CGFloat = 16
@@ -76,8 +81,10 @@ struct IdentificationView: View {
                 announceStateChange(from: oldValue, to: newValue)
             }
             .onChange(of: viewModel.selectedPrediction?.id) { _, _ in
-                // Force view update when selection changes
-                // This ensures SwiftUI tracks @Observable property changes correctly
+                saveEnabled = viewModel.canSaveToCollection
+            }
+            .onChange(of: viewModel.saveState) { _, _ in
+                saveEnabled = viewModel.canSaveToCollection
             }
             .accessibilityIdentifier(AccessibilityIdentifiers.Identification.identificationView)
             .alert("Plant Saved!", isPresented: .init(
@@ -406,12 +413,12 @@ struct IdentificationView: View {
                     .padding(.vertical, 14)
                     .background(
                         RoundedRectangle(cornerRadius: 12)
-                            .fill(viewModel.canSaveToCollection ? Color.accentColor : Color.gray)
+                            .fill(saveEnabled ? Color.accentColor : Color.gray)
                     )
                 }
-                .disabled(!viewModel.canSaveToCollection)
+                .disabled(!saveEnabled)
                 .accessibilityLabel(viewModel.saveState == .saving ? "Saving plant" : "Save to Collection")
-                .accessibilityHint(viewModel.canSaveToCollection ? "Saves the selected plant to your collection" : "Select a plant first")
+                .accessibilityHint(saveEnabled ? "Saves the selected plant to your collection" : "Select a plant first")
                 .accessibilityIdentifier(AccessibilityIdentifiers.Identification.saveToCollectionButton)
             }
             .padding(.horizontal, 20)

PlantGuide/Presentation/Scenes/PlantDetail/PlantDetailView.swift

@@ -116,6 +116,14 @@ struct PlantDetailView: View {
         .task {
             await viewModel.loadCareInfo()
         }
+        .onAppear {
+            // Reload schedule from Core Data every time the view appears.
+            // .task only runs on first appearance; this ensures task completion
+            // states are always current when navigating back to this view.
+            Task {
+                await viewModel.refreshSchedule()
+            }
+        }
         .refreshable {
             await viewModel.refresh()
         }

PlantGuide/Presentation/Scenes/PlantDetail/PlantDetailViewModel.swift

@@ -144,6 +144,12 @@ final class PlantDetailViewModel {
         isLoading = false
     }
 
+    /// Reloads the care schedule from the repository.
+    /// Call on view reappearance to pick up persisted task completions.
+    func refreshSchedule() async {
+        await loadExistingSchedule()
+    }
+
     /// Loads an existing care schedule from the repository
     private func loadExistingSchedule() async {
         do {