4df8707b92
Major infrastructure changes: - BaseUITestCase: per-suite app termination via class setUp() prevents stale state when parallel clones share simulators - relaunchBetweenTests override for suites that modify login/onboarding state - focusAndType: dedicated SecureTextField path handles iOS strong password autofill suggestions (Choose My Own Password / Not Now dialogs) - LoginScreenObject: tapSignUp/tapForgotPassword use scrollIntoView for offscreen buttons instead of simple swipeUp - Removed all coordinate taps from ForgotPasswordScreen, VerifyResetCodeScreen, ResetPasswordScreen (Rule 3 compliance) - Removed all usleep calls from screen objects (Rule 14 compliance) App fixes exposed by tests: - ContractorsListView: added onDismiss to sheet for list refresh after save - AllTasksView: added Task.RefreshButton accessibility identifier - AccessibilityIdentifiers: added Task.refreshButton - DocumentsWarrantiesView: onDismiss handler for document list refresh - Various form views: textContentType, submitLabel, onSubmit for keyboard flow Test fixes: - PasswordResetTests: handle auto-login after reset (app skips success screen) - AuthenticatedUITestCase: refreshTasks() helper for kanban toolbar button - All pre-login suites use relaunchBetweenTests for test independence - Deleted dead code: AuthenticatedTestCase, SeededTestData, SeedTests, CleanupTests, old Suite0/2/3, Suite1_RegistrationRebuildTests 10 remaining failures: 5 iOS strong password autofill (simulator env), 3 pull-to-refresh gesture on empty lists, 2 feature coverage edge cases. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
99 lines
4.5 KiB
Swift
99 lines
4.5 KiB
Swift
import XCTest
|
|
|
|
/// Smoke tests - run on every PR. Must complete in <2 minutes.
|
|
///
|
|
/// Tests that the app launches successfully, the auth screen renders correctly,
|
|
/// and core navigation is functional. These are the minimum-viability tests
|
|
/// that must pass before any PR can merge.
|
|
///
|
|
/// Zero sleep() calls -- all waits are condition-based.
|
|
final class SmokeTests: AuthenticatedUITestCase {
|
|
|
|
// MARK: - App Launch
|
|
|
|
func testAppLaunches() {
|
|
let tabBar = app.tabBars.firstMatch
|
|
let residencesTab = app.tabBars.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Residences'")).firstMatch
|
|
let onboarding = app.descendants(matching: .any)
|
|
.matching(identifier: UITestID.Onboarding.startFreshButton).firstMatch
|
|
let loginField = app.textFields[UITestID.Auth.usernameField]
|
|
|
|
let mainAppeared = residencesTab.waitForExistence(timeout: 10)
|
|
let loginAppeared = loginField.waitForExistence(timeout: 3)
|
|
let onboardingAppeared = onboarding.waitForExistence(timeout: 3)
|
|
|
|
XCTAssertTrue(loginAppeared || mainAppeared || onboardingAppeared, "App should show login, main, or onboarding screen on launch")
|
|
}
|
|
|
|
// MARK: - Login Screen Elements
|
|
|
|
func testLoginScreenElements() {
|
|
let tabBar = app.tabBars.firstMatch
|
|
if tabBar.exists {
|
|
return // Already logged in, skip login screen element checks
|
|
}
|
|
|
|
let emailField = app.textFields[UITestID.Auth.usernameField]
|
|
let passwordField = app.secureTextFields[UITestID.Auth.passwordField].exists
|
|
? app.secureTextFields[UITestID.Auth.passwordField]
|
|
: app.textFields[UITestID.Auth.passwordField]
|
|
let loginButton = app.buttons[UITestID.Auth.loginButton]
|
|
|
|
guard emailField.exists else {
|
|
return // Already logged in, skip
|
|
}
|
|
|
|
XCTAssertTrue(emailField.exists, "Email field should exist")
|
|
XCTAssertTrue(passwordField.exists, "Password field should exist")
|
|
XCTAssertTrue(loginButton.exists, "Login button should exist")
|
|
}
|
|
|
|
// MARK: - Login Flow
|
|
|
|
func testLoginWithExistingCredentials() {
|
|
let residencesTab = app.tabBars.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Residences'")).firstMatch
|
|
XCTAssertTrue(residencesTab.waitForExistence(timeout: 15), "Should be on main screen after login")
|
|
}
|
|
|
|
// MARK: - Tab Navigation
|
|
|
|
func testMainTabsExistAfterLogin() {
|
|
let residencesTab = app.tabBars.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Residences'")).firstMatch
|
|
guard residencesTab.waitForExistence(timeout: 15) else {
|
|
XCTFail("Main screen did not appear")
|
|
return
|
|
}
|
|
|
|
let tasksTab = app.tabBars.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Tasks'")).firstMatch
|
|
let contractorsTab = app.tabBars.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Contractors'")).firstMatch
|
|
let documentsTab = app.tabBars.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Doc'")).firstMatch
|
|
|
|
XCTAssertTrue(residencesTab.exists, "Residences tab should exist")
|
|
XCTAssertTrue(tasksTab.exists, "Tasks tab should exist")
|
|
XCTAssertTrue(contractorsTab.exists, "Contractors tab should exist")
|
|
XCTAssertTrue(documentsTab.exists, "Documents tab should exist")
|
|
}
|
|
|
|
func testTabNavigation() {
|
|
let residencesTab = app.tabBars.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Residences'")).firstMatch
|
|
guard residencesTab.waitForExistence(timeout: 15) else {
|
|
XCTFail("Main screen did not appear")
|
|
return
|
|
}
|
|
|
|
// Navigate through all tabs — verify each by checking that navigation didn't crash
|
|
// and the tab bar remains visible (proving the screen loaded)
|
|
navigateToTasks()
|
|
XCTAssertTrue(app.tabBars.firstMatch.waitForExistence(timeout: navigationTimeout), "Tab bar should remain after navigating to Tasks")
|
|
|
|
navigateToContractors()
|
|
XCTAssertTrue(app.tabBars.firstMatch.waitForExistence(timeout: navigationTimeout), "Tab bar should remain after navigating to Contractors")
|
|
|
|
navigateToDocuments()
|
|
XCTAssertTrue(app.tabBars.firstMatch.waitForExistence(timeout: navigationTimeout), "Tab bar should remain after navigating to Documents")
|
|
|
|
navigateToResidences()
|
|
XCTAssertTrue(app.tabBars.firstMatch.waitForExistence(timeout: navigationTimeout), "Tab bar should remain after navigating to Residences")
|
|
}
|
|
}
|