Files
honeyDueKMP/iosApp/HoneyDueUITests/Suite9_IntegrationE2ETests.swift
treyt 5c360a2796 Rearchitect UI test suite for complete, non-flaky coverage against live API
- Migrate Suite4-10, SmokeTests, NavigationCriticalPathTests to AuthenticatedTestCase
  with seeded admin account and real backend login
- Add 34 accessibility identifiers across 11 app views (task completion, profile,
  notifications, theme, join residence, manage users, forms)
- Create FeatureCoverageTests (14 tests) covering previously untested features:
  profile edit, theme selection, notification prefs, task completion, manage users,
  join residence, task templates
- Create MultiUserSharingTests (18 API tests) and MultiUserSharingUITests (8 XCUI
  tests) for full cross-user residence sharing lifecycle
- Add cleanup infrastructure: SuiteZZ_CleanupTests auto-wipes test data after runs,
  cleanup_test_data.sh script for manual reset via admin API
- Add share code API methods to TestAccountAPIClient (generateShareCode, joinWithCode,
  getShareCode, listResidenceUsers, removeUser)
- Fix app bugs found by tests:
  - ResidencesListView join callback now uses forceRefresh:true
  - APILayer invalidates task cache when residence count changes
  - AllTasksView auto-reloads tasks when residence list changes
- Fix test quality: keyboard focus waits, Save/Add button label matching,
  Documents tab label (Docs), remove API verification from UI tests
- DataLayerTests and PasswordResetTests now verify through UI, not API calls

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-15 17:32:13 -05:00

515 lines
20 KiB
Swift

import XCTest
/// Comprehensive End-to-End Integration Tests
/// Mirrors the backend integration tests in honeyDueAPI-go/internal/integration/integration_test.go
///
/// This test suite covers:
/// 1. Full authentication flow (register, login, logout)
/// 2. Residence CRUD operations
/// 3. Task lifecycle (create, update, mark-in-progress, complete, archive, cancel)
/// 4. Residence sharing between users
/// 5. Cross-user access control
///
/// IMPORTANT: These tests create real data and require network connectivity.
/// Run with a test server or dev environment (not production).
final class Suite9_IntegrationE2ETests: AuthenticatedTestCase {
// Test user credentials - unique per test run
private let timestamp = Int(Date().timeIntervalSince1970)
private var userAUsername: String { "e2e_usera_\(timestamp)" }
private var userAEmail: String { "e2e_usera_\(timestamp)@test.com" }
private var userAPassword: String { "TestPass123!" }
private var userBUsername: String { "e2e_userb_\(timestamp)" }
private var userBEmail: String { "e2e_userb_\(timestamp)@test.com" }
private var userBPassword: String { "TestPass456!" }
/// Fixed verification code used by Go API when DEBUG=true
private let verificationCode = "123456"
override func setUpWithError() throws {
try super.setUpWithError()
}
override func tearDownWithError() throws {
try super.tearDownWithError()
}
// MARK: - Helper Methods
private func ensureLoggedOut() {
UITestHelpers.ensureLoggedOut(app: app)
}
private func login(username: String, password: String) {
UITestHelpers.login(app: app, username: username, password: password)
}
/// Dismiss keyboard by tapping outside (doesn't submit forms)
private func dismissKeyboard() {
let coordinate = app.coordinate(withNormalizedOffset: CGVector(dx: 0.5, dy: 0.1))
coordinate.tap()
Thread.sleep(forTimeInterval: 0.5)
}
/// Dismiss strong password suggestion if shown
private func dismissStrongPasswordSuggestion() {
let chooseOwnPassword = app.buttons["Choose My Own Password"]
if chooseOwnPassword.waitForExistence(timeout: 1) {
chooseOwnPassword.tap()
return
}
let notNow = app.buttons["Not Now"]
if notNow.exists && notNow.isHittable {
notNow.tap()
}
}
// MARK: - Test 1: Complete Authentication Flow
// Mirrors TestIntegration_AuthenticationFlow
func test01_authenticationFlow() {
// Phase 1: Start on login screen
let welcomeText = app.textFields[AccessibilityIdentifiers.Authentication.usernameField]
if !welcomeText.waitForExistence(timeout: 5) {
ensureLoggedOut()
}
XCTAssertTrue(welcomeText.waitForExistence(timeout: 10), "Should start on login screen")
// Phase 2: Navigate to registration
let signUpButton = app.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Sign Up'")).firstMatch
XCTAssertTrue(signUpButton.waitForExistence(timeout: 5), "Sign Up button should exist")
signUpButton.tap()
sleep(2)
// Phase 3: Fill registration form using proper accessibility identifiers
let usernameField = app.textFields[AccessibilityIdentifiers.Authentication.registerUsernameField]
XCTAssertTrue(usernameField.waitForExistence(timeout: 5), "Username field should exist")
usernameField.tap()
usernameField.typeText(userAUsername)
let emailField = app.textFields[AccessibilityIdentifiers.Authentication.registerEmailField]
XCTAssertTrue(emailField.waitForExistence(timeout: 3), "Email field should exist")
emailField.tap()
emailField.typeText(userAEmail)
// Password field - check both SecureField and TextField
var passwordField = app.secureTextFields[AccessibilityIdentifiers.Authentication.registerPasswordField]
if !passwordField.exists {
passwordField = app.textFields[AccessibilityIdentifiers.Authentication.registerPasswordField]
}
XCTAssertTrue(passwordField.waitForExistence(timeout: 3), "Password field should exist")
passwordField.tap()
dismissStrongPasswordSuggestion()
passwordField.typeText(userAPassword)
// Confirm password field
var confirmPasswordField = app.secureTextFields[AccessibilityIdentifiers.Authentication.registerConfirmPasswordField]
if !confirmPasswordField.exists {
confirmPasswordField = app.textFields[AccessibilityIdentifiers.Authentication.registerConfirmPasswordField]
}
XCTAssertTrue(confirmPasswordField.waitForExistence(timeout: 3), "Confirm password field should exist")
confirmPasswordField.tap()
dismissStrongPasswordSuggestion()
confirmPasswordField.typeText(userAPassword)
dismissKeyboard()
sleep(1)
// Phase 4: Submit registration
app.swipeUp()
sleep(1)
let registerButton = app.buttons[AccessibilityIdentifiers.Authentication.registerButton]
XCTAssertTrue(registerButton.waitForExistence(timeout: 5), "Register button should exist")
registerButton.tap()
sleep(3)
// Phase 5: Handle email verification
let verifyEmailTitle = app.staticTexts["Verify Your Email"]
XCTAssertTrue(verifyEmailTitle.waitForExistence(timeout: 10), "Verification screen must appear after registration")
sleep(3)
// Enter verification code - auto-submits when 6 digits entered
let codeField = app.textFields[AccessibilityIdentifiers.Authentication.verificationCodeField]
XCTAssertTrue(codeField.waitForExistence(timeout: 5), "Verification code field must exist")
codeField.tap()
codeField.typeText(verificationCode)
sleep(5)
// Phase 6: Verify logged in
let tabBar = app.tabBars.firstMatch
XCTAssertTrue(tabBar.waitForExistence(timeout: 15), "Should be logged in after registration")
// Phase 7: Logout
UITestHelpers.logout(app: app)
// Phase 8: Login with created credentials
XCTAssertTrue(welcomeText.waitForExistence(timeout: 10), "Should be on login screen after logout")
login(username: userAUsername, password: userAPassword)
// Phase 9: Verify logged in
XCTAssertTrue(tabBar.waitForExistence(timeout: 10), "Should be logged in after login")
// Phase 10: Final logout
UITestHelpers.logout(app: app)
XCTAssertTrue(welcomeText.waitForExistence(timeout: 10), "Should be logged out")
}
// MARK: - Test 2: Residence CRUD Flow
// Mirrors TestIntegration_ResidenceFlow
func test02_residenceCRUDFlow() {
// Ensure logged in as test user
UITestHelpers.ensureLoggedIn(app: app, username: userAUsername, password: userAPassword)
navigateToTab("Residences")
sleep(2)
let residenceName = "E2E Test Home \(timestamp)"
// Phase 1: Create residence
let addButton = app.buttons[AccessibilityIdentifiers.Residence.addButton].firstMatch
XCTAssertTrue(addButton.waitForExistence(timeout: 5), "Add residence button should exist")
addButton.tap()
sleep(2)
// Fill form - just tap and type, don't dismiss keyboard between fields
let nameField = app.textFields[AccessibilityIdentifiers.Residence.nameField]
XCTAssertTrue(nameField.waitForExistence(timeout: 5), "Name field should exist")
nameField.tap()
sleep(1)
nameField.typeText(residenceName)
// Use return key to move to next field or dismiss, then scroll
app.keyboards.buttons["return"].tap()
sleep(1)
// Scroll to show more fields
app.swipeUp()
sleep(1)
// Fill street field
let streetField = app.textFields[AccessibilityIdentifiers.Residence.streetAddressField]
if streetField.waitForExistence(timeout: 3) && streetField.isHittable {
streetField.tap()
sleep(1)
streetField.typeText("123 E2E Test St")
app.keyboards.buttons["return"].tap()
sleep(1)
}
// Fill city field
let cityField = app.textFields[AccessibilityIdentifiers.Residence.cityField]
if cityField.waitForExistence(timeout: 3) && cityField.isHittable {
cityField.tap()
sleep(1)
cityField.typeText("Austin")
app.keyboards.buttons["return"].tap()
sleep(1)
}
// Fill state field
let stateField = app.textFields[AccessibilityIdentifiers.Residence.stateProvinceField]
if stateField.waitForExistence(timeout: 3) && stateField.isHittable {
stateField.tap()
sleep(1)
stateField.typeText("TX")
app.keyboards.buttons["return"].tap()
sleep(1)
}
// Fill postal code field
let postalField = app.textFields[AccessibilityIdentifiers.Residence.postalCodeField]
if postalField.waitForExistence(timeout: 3) && postalField.isHittable {
postalField.tap()
sleep(1)
postalField.typeText("78701")
}
// Dismiss keyboard and scroll to save button
dismissKeyboard()
sleep(1)
app.swipeUp()
sleep(1)
// Save the residence
let saveButton = app.buttons[AccessibilityIdentifiers.Residence.saveButton]
if saveButton.waitForExistence(timeout: 5) && saveButton.isHittable {
saveButton.tap()
} else {
// Try finding by label as fallback
let saveByLabel = app.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Save'")).firstMatch
XCTAssertTrue(saveByLabel.waitForExistence(timeout: 5), "Save button should exist")
saveByLabel.tap()
}
sleep(3)
// Phase 2: Verify residence was created
navigateToTab("Residences")
sleep(2)
let residenceCard = app.staticTexts.containing(NSPredicate(format: "label CONTAINS '\(residenceName)'")).firstMatch
XCTAssertTrue(residenceCard.waitForExistence(timeout: 10), "Residence '\(residenceName)' should appear in list")
}
// MARK: - Test 3: Task Lifecycle Flow
// Mirrors TestIntegration_TaskFlow
func test03_taskLifecycleFlow() {
// Ensure logged in
UITestHelpers.ensureLoggedIn(app: app, username: userAUsername, password: userAPassword)
// Ensure residence exists first - create one if empty
navigateToTab("Residences")
sleep(2)
let residenceCards = app.cells
if residenceCards.count == 0 {
// No residences, create one first
createMinimalResidence(name: "Task Test Home \(timestamp)")
sleep(2)
}
// Navigate to Tasks
navigateToTab("Tasks")
sleep(3)
let taskTitle = "E2E Task Lifecycle \(timestamp)"
// Phase 1: Create task - use firstMatch to avoid multiple element issue
let addButton = app.buttons[AccessibilityIdentifiers.Task.addButton].firstMatch
guard addButton.waitForExistence(timeout: 5) else {
XCTFail("Add task button should exist")
return
}
// Check if button is enabled
guard addButton.isEnabled else {
XCTFail("Add task button should be enabled (requires at least one residence)")
return
}
addButton.tap()
sleep(2)
// Fill task form
let titleField = app.textFields[AccessibilityIdentifiers.Task.titleField].firstMatch
XCTAssertTrue(titleField.waitForExistence(timeout: 5), "Task title field should exist")
titleField.tap()
sleep(1)
titleField.typeText(taskTitle)
dismissKeyboard()
sleep(1)
app.swipeUp()
sleep(1)
// Save the task
let saveTaskButton = app.buttons[AccessibilityIdentifiers.Task.saveButton].firstMatch
if saveTaskButton.waitForExistence(timeout: 5) && saveTaskButton.isHittable {
saveTaskButton.tap()
} else {
let saveByLabel = app.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Save' OR label CONTAINS[c] 'Add Task' OR label CONTAINS[c] 'Create'")).firstMatch
XCTAssertTrue(saveByLabel.exists, "Save/Create button should exist")
saveByLabel.tap()
}
sleep(3)
// Phase 2: Verify task was created
navigateToTab("Tasks")
sleep(2)
let taskCard = app.staticTexts.containing(NSPredicate(format: "label CONTAINS '\(taskTitle)'")).firstMatch
XCTAssertTrue(taskCard.waitForExistence(timeout: 10), "Task '\(taskTitle)' should appear in task list")
}
// MARK: - Test 4: Kanban Column Distribution
// Mirrors TestIntegration_TasksByResidenceKanban
func test04_kanbanColumnDistribution() {
UITestHelpers.ensureLoggedIn(app: app, username: userAUsername, password: userAPassword)
navigateToTab("Tasks")
sleep(3)
// Verify tasks screen is showing
let tasksTitle = app.staticTexts.containing(NSPredicate(format: "label CONTAINS[c] 'Tasks'")).firstMatch
let kanbanExists = app.staticTexts.containing(NSPredicate(format: "label CONTAINS[c] 'Overdue' OR label CONTAINS[c] 'Upcoming' OR label CONTAINS[c] 'In Progress'")).firstMatch.exists
XCTAssertTrue(kanbanExists || tasksTitle.exists, "Tasks screen should be visible")
}
// MARK: - Test 5: Cross-User Access Control
// Mirrors TestIntegration_CrossUserAccessDenied
func test05_crossUserAccessControl() {
UITestHelpers.ensureLoggedIn(app: app, username: userAUsername, password: userAPassword)
// Verify user can access their residences tab
navigateToTab("Residences")
sleep(2)
let residencesVisible = app.tabBars.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Residences'")).firstMatch.isSelected
XCTAssertTrue(residencesVisible, "User should be able to access Residences tab")
// Verify user can access their tasks tab
navigateToTab("Tasks")
sleep(2)
let tasksAccessible = app.tabBars.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Tasks'")).firstMatch.isSelected
XCTAssertTrue(tasksAccessible, "User should be able to access Tasks tab")
}
// MARK: - Test 6: Lookup Data Endpoints
// Mirrors TestIntegration_LookupEndpoints
func test06_lookupDataAvailable() {
UITestHelpers.ensureLoggedIn(app: app, username: userAUsername, password: userAPassword)
// Navigate to add residence to check residence types are loaded
navigateToTab("Residences")
sleep(2)
let addButton = app.buttons[AccessibilityIdentifiers.Residence.addButton].firstMatch
if addButton.waitForExistence(timeout: 5) {
addButton.tap()
sleep(2)
// Check property type picker exists (indicates lookups loaded)
let propertyTypePicker = app.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Property Type' OR label CONTAINS[c] 'Type'")).firstMatch
let pickerExists = propertyTypePicker.exists
// Cancel form
let cancelButton = app.buttons[AccessibilityIdentifiers.Residence.formCancelButton]
if cancelButton.exists {
cancelButton.tap()
} else {
let cancelByLabel = app.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Cancel'")).firstMatch
if cancelByLabel.exists {
cancelByLabel.tap()
}
}
XCTAssertTrue(pickerExists, "Property type picker should exist (lookups loaded)")
}
}
// MARK: - Test 7: Residence Sharing Flow
// Mirrors TestIntegration_ResidenceSharingFlow
func test07_residenceSharingUIElements() {
UITestHelpers.ensureLoggedIn(app: app, username: userAUsername, password: userAPassword)
navigateToTab("Residences")
sleep(2)
// Find any residence to check sharing UI
let residenceCard = app.cells.firstMatch
if residenceCard.waitForExistence(timeout: 5) {
residenceCard.tap()
sleep(2)
// Look for share button in residence details
let shareButton = app.buttons[AccessibilityIdentifiers.Residence.shareButton]
let manageUsersButton = app.buttons[AccessibilityIdentifiers.Residence.manageUsersButton]
// Note: Share functionality may not be visible depending on user permissions
// This test just verifies we can navigate to residence details
// Navigate back
let backButton = app.navigationBars.buttons.element(boundBy: 0)
if backButton.exists && backButton.isHittable {
backButton.tap()
sleep(1)
}
}
}
// MARK: - Helper: Create Minimal Residence
private func createMinimalResidence(name: String) {
let addButton = app.buttons[AccessibilityIdentifiers.Residence.addButton].firstMatch
guard addButton.waitForExistence(timeout: 5) else { return }
addButton.tap()
sleep(2)
// Fill name field
let nameField = app.textFields[AccessibilityIdentifiers.Residence.nameField]
if nameField.waitForExistence(timeout: 5) {
nameField.tap()
sleep(1)
nameField.typeText(name)
app.keyboards.buttons["return"].tap()
sleep(1)
}
// Scroll to show address fields
app.swipeUp()
sleep(1)
// Fill street field
let streetField = app.textFields[AccessibilityIdentifiers.Residence.streetAddressField]
if streetField.waitForExistence(timeout: 3) && streetField.isHittable {
streetField.tap()
sleep(1)
streetField.typeText("123 Test St")
app.keyboards.buttons["return"].tap()
sleep(1)
}
// Fill city field
let cityField = app.textFields[AccessibilityIdentifiers.Residence.cityField]
if cityField.waitForExistence(timeout: 3) && cityField.isHittable {
cityField.tap()
sleep(1)
cityField.typeText("Austin")
app.keyboards.buttons["return"].tap()
sleep(1)
}
// Fill state field
let stateField = app.textFields[AccessibilityIdentifiers.Residence.stateProvinceField]
if stateField.waitForExistence(timeout: 3) && stateField.isHittable {
stateField.tap()
sleep(1)
stateField.typeText("TX")
app.keyboards.buttons["return"].tap()
sleep(1)
}
// Fill postal code field
let postalField = app.textFields[AccessibilityIdentifiers.Residence.postalCodeField]
if postalField.waitForExistence(timeout: 3) && postalField.isHittable {
postalField.tap()
sleep(1)
postalField.typeText("78701")
}
dismissKeyboard()
sleep(1)
app.swipeUp()
sleep(1)
// Save
let saveButton = app.buttons[AccessibilityIdentifiers.Residence.saveButton]
if saveButton.waitForExistence(timeout: 5) && saveButton.isHittable {
saveButton.tap()
} else {
let saveByLabel = app.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Save'")).firstMatch
if saveByLabel.exists {
saveByLabel.tap()
}
}
sleep(3)
}
// MARK: - Helper: Find Add Task Button
private func findAddTaskButton() -> XCUIElement {
let addButton = app.buttons[AccessibilityIdentifiers.Task.addButton].firstMatch
if addButton.exists {
return addButton
}
return app.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Add Task' OR label CONTAINS[c] 'New Task'")).firstMatch
}
}