Files
honeyDueKMP/iosApp/HoneyDueUITests/CriticalPath/SmokeTests.swift
treyt 5c360a2796 Rearchitect UI test suite for complete, non-flaky coverage against live API
- Migrate Suite4-10, SmokeTests, NavigationCriticalPathTests to AuthenticatedTestCase
  with seeded admin account and real backend login
- Add 34 accessibility identifiers across 11 app views (task completion, profile,
  notifications, theme, join residence, manage users, forms)
- Create FeatureCoverageTests (14 tests) covering previously untested features:
  profile edit, theme selection, notification prefs, task completion, manage users,
  join residence, task templates
- Create MultiUserSharingTests (18 API tests) and MultiUserSharingUITests (8 XCUI
  tests) for full cross-user residence sharing lifecycle
- Add cleanup infrastructure: SuiteZZ_CleanupTests auto-wipes test data after runs,
  cleanup_test_data.sh script for manual reset via admin API
- Add share code API methods to TestAccountAPIClient (generateShareCode, joinWithCode,
  getShareCode, listResidenceUsers, removeUser)
- Fix app bugs found by tests:
  - ResidencesListView join callback now uses forceRefresh:true
  - APILayer invalidates task cache when residence count changes
  - AllTasksView auto-reloads tasks when residence list changes
- Fix test quality: keyboard focus waits, Save/Add button label matching,
  Documents tab label (Docs), remove API verification from UI tests
- DataLayerTests and PasswordResetTests now verify through UI, not API calls

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-15 17:32:13 -05:00

106 lines
4.8 KiB
Swift

import XCTest
/// Smoke tests - run on every PR. Must complete in <2 minutes.
///
/// Tests that the app launches successfully, the auth screen renders correctly,
/// and core navigation is functional. These are the minimum-viability tests
/// that must pass before any PR can merge.
///
/// Zero sleep() calls all waits are condition-based.
final class SmokeTests: AuthenticatedTestCase {
override var useSeededAccount: Bool { true }
// MARK: - App Launch
func testAppLaunches() {
// App should show either login screen, main tab view, or onboarding
// Since AuthenticatedTestCase handles login, we should be on main screen
let tabBar = app.tabBars.firstMatch
let residencesTab = app.tabBars.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Residences'")).firstMatch
let onboarding = app.descendants(matching: .any)
.matching(identifier: UITestID.Onboarding.startFreshButton).firstMatch
let loginField = app.textFields[UITestID.Auth.usernameField]
let mainAppeared = residencesTab.waitForExistence(timeout: 10)
let loginAppeared = loginField.waitForExistence(timeout: 3)
let onboardingAppeared = onboarding.waitForExistence(timeout: 3)
XCTAssertTrue(loginAppeared || mainAppeared || onboardingAppeared, "App should show login, main, or onboarding screen on launch")
}
// MARK: - Login Screen Elements
func testLoginScreenElements() {
// AuthenticatedTestCase logs in automatically, so we may already be on main screen
let tabBar = app.tabBars.firstMatch
if tabBar.exists {
return // Already logged in, skip login screen element checks
}
let emailField = app.textFields[UITestID.Auth.usernameField]
let passwordField = app.secureTextFields[UITestID.Auth.passwordField].exists
? app.secureTextFields[UITestID.Auth.passwordField]
: app.textFields[UITestID.Auth.passwordField]
let loginButton = app.buttons[UITestID.Auth.loginButton]
guard emailField.exists else {
return // Already logged in, skip
}
XCTAssertTrue(emailField.exists, "Email field should exist")
XCTAssertTrue(passwordField.exists, "Password field should exist")
XCTAssertTrue(loginButton.exists, "Login button should exist")
}
// MARK: - Login Flow
func testLoginWithExistingCredentials() {
// AuthenticatedTestCase already handles login
// Verify we're on the main screen
let residencesTab = app.tabBars.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Residences'")).firstMatch
XCTAssertTrue(residencesTab.waitForExistence(timeout: 15), "Should be on main screen after login")
}
// MARK: - Tab Navigation
func testMainTabsExistAfterLogin() {
let residencesTab = app.tabBars.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Residences'")).firstMatch
guard residencesTab.waitForExistence(timeout: 15) else {
XCTFail("Main screen did not appear")
return
}
let tasksTab = app.tabBars.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Tasks'")).firstMatch
let contractorsTab = app.tabBars.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Contractors'")).firstMatch
let documentsTab = app.tabBars.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Doc'")).firstMatch
XCTAssertTrue(residencesTab.exists, "Residences tab should exist")
XCTAssertTrue(tasksTab.exists, "Tasks tab should exist")
XCTAssertTrue(contractorsTab.exists, "Contractors tab should exist")
XCTAssertTrue(documentsTab.exists, "Documents tab should exist")
}
func testTabNavigation() {
let residencesTab = app.tabBars.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Residences'")).firstMatch
guard residencesTab.waitForExistence(timeout: 15) else {
XCTFail("Main screen did not appear")
return
}
navigateToTasks()
let tasksTab = app.tabBars.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Tasks'")).firstMatch
XCTAssertTrue(tasksTab.isSelected, "Tasks tab should be selected")
navigateToContractors()
let contractorsTab = app.tabBars.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Contractors'")).firstMatch
XCTAssertTrue(contractorsTab.isSelected, "Contractors tab should be selected")
navigateToDocuments()
let documentsTab = app.tabBars.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Doc'")).firstMatch
XCTAssertTrue(documentsTab.isSelected, "Documents tab should be selected")
navigateToResidences()
XCTAssertTrue(residencesTab.isSelected, "Residences tab should be selected")
}
}