Anchor the empty-state icon/text boundary at the exact vertical center
in the shared OrganicEmptyScreen: the icon's bottom sits 8pt above center
and the text's top 8pt below, so the 16pt gap straddles 50% Y regardless
of icon size or title/subtitle length. Previously the block-center was
centered, so longer copy drifted the icon (~1.7% spread across tabs);
boundary spread is now ~0.1% (pixel-identical on all four tabs).
Supporting changes so each tab renders the empty state alone (full
content area, consistent nav-bar height):
- Tasks: keep toolbar buttons present (disabled) when empty so the inline
nav bar doesn't collapse and shift content up
- Contractors/Documents: hide search/filter chrome when truly empty
- Residences: restore original copy + frame-fill
Adds EmptyStateScreenshotUITests as a regression guard that captures the
empty state of all four tabs for a fresh verified no-data user.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- DataLayerTests -> DataLayer/DataLayerUITests (cache/ETag/persistence domain)
- FeatureCoverageTests -> CrossCutting/FeatureCoverageUITests (cross-cutting:
profile/theme/notifications/completion/sharing UI)
- Delete the dead HoneyDueUITests/AccessibilityIdentifiers.swift duplicate
(the target compiles the app's Helpers/AccessibilityIdentifiers.swift; this
copy was excluded and stale). Tests/ folder removed.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Migrate the XCUITest suite off the legacy shared-account model (and the
prior Django-style auth assumptions) to a parallel-safe, domain-organized
architecture, validated end-to-end against the live Kratos stack.
Isolation (parallel-safe by construction):
- Core/Fixtures/TestAccount.swift: each test mints its own pre-verified
Kratos identity (uit_<domain>_<uuid>@test.honeydue.local), logs in, seeds
under its own token, and deletes the identity in teardown (cascading all
data + clearing Kratos). No shared testuser; parallel workers no longer race.
- AuthenticatedUITestCase rewritten to that model (member surface preserved);
adds requiresResidence / seedAccountPreconditions to seed UI-gated data
BEFORE login (a fresh account is empty at login).
Organization (255 tests preserved, none dropped):
- 21 domain suites under Auth/ Onboarding/ Residence/ Task/ Contractor/
Document/ Sharing/ Navigation/ Smoke/ CrossCutting/ E2E/, consistent
<Domain>UITests naming. Removes the Suite1..11 / AAA_ / ZZ_ / Tests/Rebuild
naming chaos and the overlapping task/residence/auth suites.
Runner + test plans:
- run_ui_tests.sh: Smoke gate -> Seed -> Parallel(8 workers) -> Sweep. The
parallel phase runs the whole target minus phase-managed suites via
-skip-testing, so new suites auto-include (no hand-maintained list to drift).
Drops the 2-worker cap and Suite6 isolation (isolation made them moot).
- HoneyDueUITests.xctestplan skips the 4 phase-managed suites; adds Smoke.xctestplan.
Kratos auth fixes folded in (login/verify/reset endpoints removed under Kratos):
real Mailpit verification codes replace the obsolete fixed "123456"; teardown
deletes Kratos identities; admin-panel login uses the correct seeded password.
Build green; isolation, parallelism, and the precondition/sharing migrations
validated against the live stack (0 leaked accounts).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Trey T