Refactor iOS UI tests to blueprint architecture

2026-02-20 10:38:15 -06:00
parent 710a8bd1d6
commit fe28034f3d
28 changed files with 7354 additions and 83 deletions
--- a/iosApp/CaseraUITests/Tests/Rebuild/Suite0_OnboardingRebuildTests.swift
+++ b/iosApp/CaseraUITests/Tests/Rebuild/Suite0_OnboardingRebuildTests.swift
@@ -0,0 +1,31 @@
+import XCTest
+
+/// Rebuild plan for legacy: Suite0_OnboardingTests.test_onboarding
+/// Split into smaller tests to isolate focus/input/navigation failures.
+final class Suite0_OnboardingRebuildTests: BaseUITestCase {
+    func testR001_onboardingWelcomeLoadsAndCanNavigateToLoginEntry() {
+        let welcome = OnboardingWelcomeScreen(app: app)
+        welcome.waitForLoad(timeout: defaultTimeout)
+        welcome.tapAlreadyHaveAccount()
+
+        let login = LoginScreen(app: app)
+        login.waitForLoad(timeout: defaultTimeout)
+    }
+
+    func testR002_startFreshFlowReachesCreateAccount() {
+        let createAccount = TestFlows.navigateStartFreshToCreateAccount(app: app, residenceName: "Rebuild Home")
+        createAccount.waitForLoad(timeout: defaultTimeout)
+    }
+
+    func testR003_createAccountExpandedFormFieldsAreInteractable() throws {
+        throw XCTSkip("Skeleton: implement deterministic focus assertions for username/email/password fields")
+    }
+
+    func testR004_emailFieldCanFocusAndAcceptTyping() throws {
+        throw XCTSkip("Skeleton: implement replacement for legacy email focus failure")
+    }
+
+    func testR005_createAccountContinueOnlyAfterValidInputs() throws {
+        throw XCTSkip("Skeleton: validate disabled/enabled state transition for Create Account")
+    }
+}
--- a/iosApp/CaseraUITests/Tests/Rebuild/Suite1_RegistrationRebuildTests.swift
+++ b/iosApp/CaseraUITests/Tests/Rebuild/Suite1_RegistrationRebuildTests.swift
@@ -0,0 +1,72 @@
+import XCTest
+
+/// Rebuild plan for legacy failures in Suite1_RegistrationTests:
+/// - test07, test09, test10, test11, test12
+/// Coverage is split into smaller tests for easier isolation.
+final class Suite1_RegistrationRebuildTests: BaseUITestCase {
+    override var includeResetStateLaunchArgument: Bool { false }
+
+    func testR101_registerFormCanOpenFromLogin() {
+        UITestHelpers.ensureOnLoginScreen(app: app)
+        let register = TestFlows.openRegisterFromLogin(app: app)
+        register.waitForLoad(timeout: defaultTimeout)
+    }
+
+    func testR102_registerFormAcceptsValidInput() {
+        UITestHelpers.ensureOnLoginScreen(app: app)
+        let register = TestFlows.openRegisterFromLogin(app: app)
+        XCTAssertTrue(app.textFields[UITestID.Auth.registerUsernameField].exists)
+        XCTAssertTrue(app.textFields[UITestID.Auth.registerEmailField].exists)
+        XCTAssertTrue(app.secureTextFields[UITestID.Auth.registerPasswordField].exists)
+        XCTAssertTrue(app.secureTextFields[UITestID.Auth.registerConfirmPasswordField].exists)
+        XCTAssertTrue(app.buttons[UITestID.Auth.registerButton].exists)
+    }
+
+    func testR103_successfulRegistrationTransitionsToVerificationGate() throws {
+        throw XCTSkip("Skeleton: submit valid registration and assert verification gate")
+    }
+
+    func testR104_verificationGateBlocksMainAppBeforeCodeEntry() throws {
+        throw XCTSkip("Skeleton: assert no tab bar access while unverified")
+    }
+
+    func testR105_validVerificationCodeTransitionsToMainApp() throws {
+        throw XCTSkip("Skeleton: use deterministic verification code fixture and assert main app root")
+    }
+
+    func testR106_mainAppSessionAfterVerificationCanReachProfile() throws {
+        throw XCTSkip("Skeleton: assert verified user can navigate tab bar and profile")
+    }
+
+    func testR107_invalidVerificationCodeShowsErrorAndStaysBlocked() throws {
+        throw XCTSkip("Skeleton: replacement for legacy test09")
+    }
+
+    func testR108_incompleteVerificationCodeDoesNotCompleteVerification() throws {
+        throw XCTSkip("Skeleton: replacement for legacy test10")
+    }
+
+    func testR109_verifyButtonDisabledForIncompleteCode() throws {
+        throw XCTSkip("Skeleton: optional split from legacy test10 button state assertion")
+    }
+
+    func testR110_relaunchUnverifiedUserNeverLandsInMainApp() throws {
+        throw XCTSkip("Skeleton: replacement for legacy test11")
+    }
+
+    func testR111_relaunchUnverifiedUserResumesVerificationOrLoginGate() throws {
+        throw XCTSkip("Skeleton: acceptable states after relaunch")
+    }
+
+    func testR112_logoutFromVerificationReturnsToLogin() throws {
+        throw XCTSkip("Skeleton: replacement for legacy test12")
+    }
+
+    func testR113_verificationElementsDisappearAfterLogout() throws {
+        throw XCTSkip("Skeleton: split assertion from legacy test12")
+    }
+
+    func testR114_logoutFromVerifiedMainAppReturnsToLogin() throws {
+        throw XCTSkip("Skeleton: split assertion from legacy test07 cleanup")
+    }
+}
--- a/iosApp/CaseraUITests/Tests/Rebuild/Suite2_AuthenticationRebuildTests.swift
+++ b/iosApp/CaseraUITests/Tests/Rebuild/Suite2_AuthenticationRebuildTests.swift
@@ -0,0 +1,147 @@
+import XCTest
+
+/// Rebuild plan for legacy Suite2 failures:
+/// - test02_loginWithValidCredentials
+/// - test06_logout
+final class Suite2_AuthenticationRebuildTests: BaseUITestCase {
+    override var includeResetStateLaunchArgument: Bool { false }
+    override var additionalLaunchArguments: [String] { ["--ui-test-mock-auth"] }
+    private let validUser = RebuildTestUserFactory.seeded
+
+    private enum AuthLandingState {
+        case main
+        case verification
+    }
+
+    override func setUpWithError() throws {
+        try super.setUpWithError()
+        UITestHelpers.ensureLoggedOut(app: app)
+    }
+
+    private func loginFromLoginScreen(user: RebuildTestUser = RebuildTestUserFactory.seeded) {
+        UITestHelpers.ensureOnLoginScreen(app: app)
+        let login = LoginScreen(app: app)
+        login.waitForLoad(timeout: defaultTimeout)
+        login.enterUsername(user.username)
+        login.enterPassword(user.password)
+
+        let loginButton = app.buttons[AccessibilityIdentifiers.Authentication.loginButton]
+        loginButton.waitForExistenceOrFail(timeout: defaultTimeout)
+        loginButton.forceTap()
+    }
+
+    @discardableResult
+    private func loginAndWaitForAuthenticatedLanding(user: RebuildTestUser = RebuildTestUserFactory.seeded) -> AuthLandingState {
+        loginFromLoginScreen(user: user)
+
+        let mainRoot = app.otherElements[UITestID.Root.mainTabs]
+        if mainRoot.waitForExistence(timeout: longTimeout) || app.tabBars.firstMatch.waitForExistence(timeout: 2) {
+            return .main
+        }
+
+        let verification = VerificationScreen(app: app)
+        if verification.codeField.waitForExistence(timeout: defaultTimeout) || verification.verifyButton.waitForExistence(timeout: 2) {
+            return .verification
+        }
+
+        XCTFail("Expected authenticated landing on main tabs or verification screen")
+        return .verification
+    }
+
+    private func logoutFromVerificationIfNeeded() {
+        let verification = VerificationScreen(app: app)
+        verification.waitForLoad(timeout: defaultTimeout)
+        verification.tapLogoutIfAvailable()
+
+        let toolbarLogout = app.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Logout' OR label CONTAINS[c] 'Log Out'")).firstMatch
+        if toolbarLogout.waitForExistence(timeout: 3) {
+            toolbarLogout.forceTap()
+        }
+    }
+
+    private func logoutFromMainApp() {
+        UITestHelpers.logout(app: app)
+    }
+
+    func testR201_loginScreenLoadsFromOnboardingEntry() {
+        UITestHelpers.ensureOnLoginScreen(app: app)
+        let login = LoginScreen(app: app)
+        login.waitForLoad(timeout: defaultTimeout)
+    }
+
+    func testR202_validCredentialsSubmitFromLogin() {
+        UITestHelpers.ensureOnLoginScreen(app: app)
+        let login = LoginScreen(app: app)
+        login.waitForLoad(timeout: defaultTimeout)
+
+        login.enterUsername(validUser.username)
+        login.enterPassword(validUser.password)
+
+        let loginButton = app.buttons[AccessibilityIdentifiers.Authentication.loginButton]
+        XCTAssertTrue(loginButton.waitForExistence(timeout: defaultTimeout), "Login button must exist before submit")
+        XCTAssertTrue(loginButton.isHittable, "Login button must be tappable")
+    }
+
+    func testR203_validLoginTransitionsToMainAppRoot() {
+        let landing = loginAndWaitForAuthenticatedLanding(user: validUser)
+        switch landing {
+        case .main:
+            RebuildSessionAssertions.assertOnMainApp(app, timeout: longTimeout)
+        case .verification:
+            RebuildSessionAssertions.assertOnVerification(app, timeout: longTimeout)
+        }
+    }
+
+    func testR204_mainAppHasExpectedPrimaryTabsAfterLogin() {
+        let landing = loginAndWaitForAuthenticatedLanding(user: validUser)
+
+        switch landing {
+        case .main:
+            RebuildSessionAssertions.assertOnMainApp(app, timeout: longTimeout)
+
+            let tabBar = app.tabBars.firstMatch
+            if tabBar.waitForExistence(timeout: 5) {
+                let residences = tabBar.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Residences'")).firstMatch
+                let tasks = tabBar.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Tasks'")).firstMatch
+                let contractors = tabBar.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Contractors'")).firstMatch
+                let docs = tabBar.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Doc'")).firstMatch
+                XCTAssertTrue(residences.exists, "Residences tab should exist")
+                XCTAssertTrue(tasks.exists, "Tasks tab should exist")
+                XCTAssertTrue(contractors.exists, "Contractors tab should exist")
+                XCTAssertTrue(docs.exists, "Documents tab should exist")
+            } else {
+                XCTAssertTrue(app.otherElements[UITestID.Root.mainTabs].exists, "Main tabs root should exist")
+            }
+        case .verification:
+            let verify = VerificationScreen(app: app)
+            verify.waitForLoad(timeout: defaultTimeout)
+            XCTAssertTrue(verify.codeField.exists, "Verification code field should exist for unverified accounts")
+        }
+    }
+
+    func testR205_logoutFromMainAppReturnsToLoginRoot() {
+        let landing = loginAndWaitForAuthenticatedLanding(user: validUser)
+
+        switch landing {
+        case .main:
+            logoutFromMainApp()
+        case .verification:
+            logoutFromVerificationIfNeeded()
+        }
+        RebuildSessionAssertions.assertOnLogin(app, timeout: longTimeout)
+    }
+
+    func testR206_postLogoutMainAppIsNoLongerAccessible() {
+        let landing = loginAndWaitForAuthenticatedLanding(user: validUser)
+
+        switch landing {
+        case .main:
+            logoutFromMainApp()
+        case .verification:
+            logoutFromVerificationIfNeeded()
+        }
+        RebuildSessionAssertions.assertOnLogin(app, timeout: longTimeout)
+
+        XCTAssertFalse(app.otherElements[UITestID.Root.mainTabs].exists, "Main app root should not be visible after logout")
+    }
+}
--- a/iosApp/CaseraUITests/Tests/Rebuild/Suite3_ResidenceRebuildTests.swift
+++ b/iosApp/CaseraUITests/Tests/Rebuild/Suite3_ResidenceRebuildTests.swift
@@ -0,0 +1,137 @@
+import XCTest
+
+/// Rebuild plan for legacy Suite3 failures (all blocked at residences tab precondition).
+/// Old tests covered:
+/// - test01_viewResidencesList
+/// - test02_navigateToAddResidence
+/// - test03_navigationBetweenTabs
+/// - test04_cancelResidenceCreation
+/// - test05_createResidenceWithMinimalData
+/// - test06_viewResidenceDetails
+final class Suite3_ResidenceRebuildTests: BaseUITestCase {
+    override var includeResetStateLaunchArgument: Bool { false }
+    override var additionalLaunchArguments: [String] { ["--ui-test-mock-auth"] }
+
+    override func setUpWithError() throws {
+        try super.setUpWithError()
+        UITestHelpers.ensureLoggedOut(app: app)
+    }
+
+    private func loginAndOpenResidences() {
+        UITestHelpers.ensureOnLoginScreen(app: app)
+        let login = LoginScreen(app: app)
+        login.waitForLoad(timeout: defaultTimeout)
+        login.enterUsername("testuser")
+        login.enterPassword("TestPass123!")
+        app.buttons[AccessibilityIdentifiers.Authentication.loginButton].waitForExistenceOrFail(timeout: defaultTimeout).forceTap()
+
+        let main = MainTabScreen(app: app)
+        main.waitForLoad(timeout: longTimeout)
+        main.goToResidences()
+    }
+
+    @discardableResult
+    private func createResidence(name: String) -> String {
+        loginAndOpenResidences()
+
+        let list = ResidenceListScreen(app: app)
+        list.waitForLoad(timeout: defaultTimeout)
+        list.openCreateResidence()
+
+        let form = ResidenceFormScreen(app: app)
+        form.waitForLoad(timeout: defaultTimeout)
+        form.enterName(name)
+
+        form.save()
+        return name
+    }
+
+    func testR301_authenticatedPreconditionCanReachMainApp() throws {
+        loginAndOpenResidences()
+        RebuildSessionAssertions.assertOnMainApp(app, timeout: defaultTimeout)
+    }
+
+    func testR302_residencesTabIsPresentAndNavigable() throws {
+        loginAndOpenResidences()
+        let residencesTab = app.tabBars.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Residences'")).firstMatch
+        XCTAssertTrue(residencesTab.exists, "Residences tab should exist")
+    }
+
+    func testR303_residencesListLoadsAfterTabSelection() throws {
+        loginAndOpenResidences()
+        let list = ResidenceListScreen(app: app)
+        list.waitForLoad(timeout: defaultTimeout)
+        XCTAssertTrue(list.addButton.exists, "Add residence button should be visible")
+    }
+
+    func testR304_openAddResidenceFormFromResidencesList() throws {
+        loginAndOpenResidences()
+        let list = ResidenceListScreen(app: app)
+        list.waitForLoad(timeout: defaultTimeout)
+        list.openCreateResidence()
+
+        let form = ResidenceFormScreen(app: app)
+        form.waitForLoad(timeout: defaultTimeout)
+        XCTAssertTrue(form.saveButton.exists, "Residence save button should exist")
+    }
+
+    func testR305_cancelAddResidenceReturnsToResidenceList() throws {
+        loginAndOpenResidences()
+        let list = ResidenceListScreen(app: app)
+        list.openCreateResidence()
+
+        let form = ResidenceFormScreen(app: app)
+        form.waitForLoad(timeout: defaultTimeout)
+        form.cancel()
+
+        list.waitForLoad(timeout: defaultTimeout)
+    }
+
+    func testR306_createResidenceMinimalDataSubmitsSuccessfully() throws {
+        let name = "UITest Home \(Int(Date().timeIntervalSince1970))"
+        _ = createResidence(name: name)
+        let created = app.staticTexts.containing(NSPredicate(format: "label CONTAINS[c] %@", name)).firstMatch
+        XCTAssertTrue(created.waitForExistence(timeout: longTimeout), "Created residence should appear in list")
+    }
+
+    func testR307_newResidenceAppearsInResidenceList() throws {
+        let name = "UITest Verify \(Int(Date().timeIntervalSince1970))"
+        _ = createResidence(name: name)
+        let created = app.staticTexts.containing(NSPredicate(format: "label CONTAINS[c] %@", name)).firstMatch
+        XCTAssertTrue(created.waitForExistence(timeout: longTimeout), "New residence should be visible in residences list")
+    }
+
+    func testR308_openResidenceDetailsFromResidenceList() throws {
+        let name = "UITest Detail \(Int(Date().timeIntervalSince1970))"
+        _ = createResidence(name: name)
+
+        let row = app.staticTexts.containing(NSPredicate(format: "label CONTAINS[c] %@", name)).firstMatch
+        row.waitForExistenceOrFail(timeout: longTimeout).forceTap()
+
+        let edit = app.buttons[AccessibilityIdentifiers.Residence.editButton]
+        let delete = app.buttons[AccessibilityIdentifiers.Residence.deleteButton]
+        let loaded = edit.waitForExistence(timeout: defaultTimeout) || delete.waitForExistence(timeout: defaultTimeout)
+        XCTAssertTrue(loaded, "Residence details should expose edit or delete actions")
+    }
+
+    func testR309_navigationAcrossPrimaryTabsAndBackToResidences() throws {
+        loginAndOpenResidences()
+
+        let tabBar = app.tabBars.firstMatch
+        tabBar.waitForExistenceOrFail(timeout: defaultTimeout)
+
+        let tasksTab = tabBar.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Tasks'")).firstMatch
+        XCTAssertTrue(tasksTab.exists, "Tasks tab should exist")
+        tasksTab.forceTap()
+
+        let contractorsTab = tabBar.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Contractors'")).firstMatch
+        XCTAssertTrue(contractorsTab.exists, "Contractors tab should exist")
+        contractorsTab.forceTap()
+
+        let residencesTab = tabBar.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Residences'")).firstMatch
+        residencesTab.forceTap()
+
+        let list = ResidenceListScreen(app: app)
+        list.waitForLoad(timeout: defaultTimeout)
+    }
+}