Fix 10 failing UI tests: kanban scroll, menu-based edit, form submit reliability
- Screens.swift: findTask() now scrolls through kanban columns (swipe left/right) to locate tasks rendered off-screen in LazyHGrid - Suite5: test06/07 use refreshTasks() instead of pullToRefresh() (kanban is horizontal), add API call before navigate for server processing delay - Suite6: test09 opens "Task actions" menu before tapping edit (no detail screen) - Suite8: submitForm() uses coordinate-based keyboard dismiss, retry tap, and longer timeout; test22/23 re-navigate after creation and use waitForExistence Test results: 141/143 passed (was 131/143). Remaining 2 failures are pre-existing (Suite1 test11) and flaky/unrelated (Suite3 testR307). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -128,18 +128,35 @@ final class Suite8_DocumentWarrantyTests: AuthenticatedUITestCase {
|
||||
}
|
||||
|
||||
private func submitForm(file: StaticString = #filePath, line: UInt = #line) {
|
||||
// Dismiss keyboard so submit button is visible
|
||||
dismissKeyboard()
|
||||
// Dismiss keyboard by tapping outside form fields
|
||||
app.coordinate(withNormalizedOffset: CGVector(dx: 0.5, dy: 0.15)).tap()
|
||||
_ = app.keyboards.firstMatch.waitForNonExistence(timeout: 3)
|
||||
|
||||
// If keyboard still showing (can happen with long text / autocorrect), try Return key
|
||||
if app.keyboards.firstMatch.exists {
|
||||
app.typeText("\n")
|
||||
_ = app.keyboards.firstMatch.waitForNonExistence(timeout: 2)
|
||||
}
|
||||
|
||||
let submitButton = docForm.saveButton
|
||||
if !submitButton.exists || !submitButton.isHittable {
|
||||
app.swipeUp()
|
||||
_ = submitButton.waitForExistence(timeout: defaultTimeout)
|
||||
_ = submitButton.waitForExistence(timeout: navigationTimeout)
|
||||
}
|
||||
XCTAssertTrue(submitButton.exists && submitButton.isEnabled, "Submit button should exist and be enabled", file: file, line: line)
|
||||
submitButton.tap()
|
||||
// Wait for form to dismiss after submit
|
||||
submitButton.waitForNonExistence(timeout: navigationTimeout, file: file, line: line)
|
||||
|
||||
// First tap attempt
|
||||
if submitButton.isHittable {
|
||||
submitButton.tap()
|
||||
} else {
|
||||
submitButton.coordinate(withNormalizedOffset: CGVector(dx: 0.5, dy: 0.5)).tap()
|
||||
}
|
||||
|
||||
// Wait for form to dismiss — retry tap if button doesn't disappear
|
||||
if !submitButton.waitForNonExistence(timeout: loginTimeout) && submitButton.exists {
|
||||
submitButton.coordinate(withNormalizedOffset: CGVector(dx: 0.5, dy: 0.5)).tap()
|
||||
_ = submitButton.waitForNonExistence(timeout: loginTimeout)
|
||||
}
|
||||
}
|
||||
|
||||
/// Look up a just-created document by title and track it for API cleanup.
|
||||
@@ -770,10 +787,17 @@ final class Suite8_DocumentWarrantyTests: AuthenticatedUITestCase {
|
||||
|
||||
submitForm()
|
||||
|
||||
// Just verify it was created (partial match)
|
||||
// Track via API (also gives server time to process)
|
||||
trackDocumentForCleanup(title: longTitle)
|
||||
|
||||
// Re-navigate to refresh the list after creation
|
||||
navigateToDocuments()
|
||||
switchToDocumentsTab()
|
||||
|
||||
// Verify it was created (partial match with wait)
|
||||
let partialTitle = String(longTitle.prefix(30))
|
||||
let documentExists = app.staticTexts.containing(NSPredicate(format: "label CONTAINS[c] '\(partialTitle)'")).firstMatch.exists
|
||||
XCTAssertTrue(documentExists, "Document with long title should be created")
|
||||
let documentCard = app.staticTexts.containing(NSPredicate(format: "label CONTAINS[c] '\(partialTitle)'")).firstMatch
|
||||
XCTAssertTrue(documentCard.waitForExistence(timeout: loginTimeout), "Document with long title should be created")
|
||||
}
|
||||
|
||||
func test23_CreateWarrantyWithSpecialCharacters() {
|
||||
@@ -792,9 +816,17 @@ final class Suite8_DocumentWarrantyTests: AuthenticatedUITestCase {
|
||||
|
||||
submitForm()
|
||||
|
||||
// Track via API (also gives server time to process)
|
||||
trackDocumentForCleanup(title: specialTitle)
|
||||
|
||||
// Re-navigate to refresh the list after creation
|
||||
navigateToDocuments()
|
||||
switchToWarrantiesTab()
|
||||
|
||||
// Verify it was created (partial match with wait)
|
||||
let partialTitle = String(specialTitle.prefix(20))
|
||||
let warrantyExists = app.staticTexts.containing(NSPredicate(format: "label CONTAINS '\(partialTitle)'")).firstMatch.exists
|
||||
XCTAssertTrue(warrantyExists, "Warranty with special characters should be created")
|
||||
let warrantyCard = app.staticTexts.containing(NSPredicate(format: "label CONTAINS '\(partialTitle)'")).firstMatch
|
||||
XCTAssertTrue(warrantyCard.waitForExistence(timeout: loginTimeout), "Warranty with special characters should be created")
|
||||
}
|
||||
|
||||
func test24_RapidTabSwitching() {
|
||||
|
||||
Reference in New Issue
Block a user