Perf: inject auth token at launch to skip the UI login (~26-50% faster)

Measured: ~half of every authenticated test was fixed setup, dominated by the
UI login (typing email+password, keyboard/SecureField dance, ~8-12s). The test
already creates the account via API and holds its real Kratos session token —
so instead of typing credentials, pass the token as a launch arg and boot the
app already authenticated.

- App (UITestRuntime + iOSApp): reads --ui-test-session-token; after the
  --reset-state clear, calls DataManager.setAuthToken(token) and replicates the
  post-login init the UI login path runs (getCurrentUser + initializeLookups +
  getMyResidences + getTasks) so owner-gated/data-gated screens (residence
  detail delete + manage-users, pickers, lists) work on boot. Guarded by
  UITestRuntime.isEnabled — no effect on production.
- AuthenticatedUITestCase: in fresh-account mode, create the account + seed its
  preconditions BEFORE launch, expose the token via additionalLaunchArguments,
  and drop the UI login. Legacy (usesFreshAccount=false) suites still UI-login.

Measured per-test medians: Contractor 34s -> 25s; Task (uses lookups) ~34s ->
16s. TESTING.md updated. All affected suites pass; 0 leaked accounts.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Trey T
2026-06-05 23:35:28 -05:00
parent ef9ed4f5fc
commit d11cc82fec
4 changed files with 59 additions and 10 deletions
@@ -23,6 +23,18 @@ class AuthenticatedUITestCase: BaseUITestCase {
/// logout-via-profile path was the #1 source of flakes under load).
override var relaunchBetweenTests: Bool { true }
/// In fresh-account mode the app boots already authenticated via the
/// account's real Kratos token (the app reads `--ui-test-session-token` in
/// UITestRuntime) skipping the slow, flaky UI login (~8-12s/test). The
/// account is created before the launch (see setUpWithError), so its token
/// is available here when BaseUITestCase assembles the launch arguments.
override var additionalLaunchArguments: [String] {
if usesFreshAccount, let token = account?.token {
return ["--ui-test-session-token", token]
}
return []
}
/// Credentials for the Kratos APP identity used to seed data over the API.
///
/// TWO DIFFERENT "admin@honeydue.com" EXIST do NOT "fix" Test1234 to password123:
@@ -119,25 +131,25 @@ class AuthenticatedUITestCase: BaseUITestCase {
throw XCTSkip("Backend not reachable at \(TestAccountAPIClient.baseURL)")
}
try super.setUpWithError()
if usesFreshAccount {
// Per-test isolation: relaunchBetweenTests gives every test a fresh
// app launch that lands on the login screen (--reset-state), so we
// log in as a brand-new pre-verified account, seed under its token,
// and delete it in teardown. No UI logout between tests.
// Per-test isolation WITHOUT a UI login: create the account and seed
// its UI-gated data via API BEFORE the app launches, then boot the
// app already authenticated via the injected session token (see
// `additionalLaunchArguments`). relaunchBetweenTests gives every test
// a fresh launch, so each boots as its own account; the account is
// deleted in teardown (cascading all its data).
let acct = TestAccount.create(domain: accountDomain)
account = acct
session = acct.session
cleaner = TestDataCleaner(token: acct.token)
// Seed UI-gated baseline data BEFORE login so the app loads it on
// its post-login fetch (a fresh account is otherwise empty).
seedAccountPreconditions(acct)
acct.login(into: app, timeout: loginTimeout)
try super.setUpWithError() // launches with --ui-test-session-token
waitForMainApp()
return
}
try super.setUpWithError()
// Legacy path: log in as a SPECIFIC seeded account (testCredentials),
// optionally opening a separate API session (apiCredentials).
let tabBar = app.tabBars.firstMatch