Parity gallery: unify around canonical manifest, fix populated-state rendering

Single source of truth: `com.tt.honeyDue.testing.GalleryScreens` lists every user-reachable screen with its category (DataCarrying / DataFree) and per-platform reachability. Both platforms' test harnesses are CI-gated against it — `GalleryManifestParityTest` on each side fails if the surface list drifts from the manifest. Variant matrix by category: DataCarrying captures 4 PNGs (empty/populated × light/dark), DataFree captures 2 (light/dark only). Empty variants for DataCarrying use `FixtureDataManager.empty(seedLookups = false)` so form screens that only read DM lookups can diff against populated. Detail-screen rendering fixed on both platforms. Root cause: VM `stateIn(Eagerly, initialValue = …)` closures evaluated `_selectedX.value` before screen-side `LaunchedEffect` / `.onAppear` could set the id, leaving populated captures byte-identical to empty. Kotlin: `ContractorViewModel` + `DocumentViewModel` accept `initialSelectedX: Int? = null` so the id is set in the primary constructor before `stateIn` computes its seed. Swift: `ContractorViewModel`, `DocumentViewModelWrapper`, `ResidenceViewModel`, `OnboardingTasksViewModel` gained pre-seed init params. `ContractorDetailView`, `DocumentDetailView`, `ResidenceDetailView`, `OnboardingFirstTaskContent` gained test/preview init overloads that accept the pre-seeded VM. Corresponding view bodies prefer cached success state over loading/error — avoids a spinner flashing over already-visible content during background refreshes (production benefit too). Real production bug fixed along the way: `DataManager.clear()` was missing `_contractorDetail`, `_documentDetail`, `_contractorsByResidence`, `_taskCompletions`, `_notificationPreferences`. On logout these maps leaked across user sessions; in the gallery they leaked the previous surface's populated state into the next surface's empty capture. `ImagePicker.android.kt` guards `rememberCameraPicker` with `LocalInspectionMode` — `FileProvider.getUriForFile` can't resolve the Robolectric test-cache path, so `add_document` / `edit_document` previously failed the entire capture. Honest reclassifications: `complete_task`, `manage_users`, and `task_suggestions` moved to DataFree. Their first-paint visible state is driven by static props or APILayer calls, not by anything on `IDataManager` — populated would be byte-identical to empty without a significant production rewire. The manifest comments call this out. Manifest counts after all moves: 43 screens = 12 DataCarrying + 31 DataFree, 37 on both platforms + 3 Android-only (home, documents, biometric_lock) + 3 iOS-only (documents_warranties, add_task, profile_edit). Test results after full record: Android: 11/11 DataCarrying diff populated vs empty iOS: 12/12 DataCarrying diff populated vs empty Also in this change: - `scripts/build_parity_gallery.py` parses the Kotlin manifest directly, renders rows in product-flow order, shows explicit `[missing — <platform>]` placeholders for expected-but-absent captures and muted `not on <platform>` placeholders for platform-specific screens. Docs regenerated. - `scripts/cleanup_orphan_goldens.sh` safely removes PNGs from prior test configurations (theme-named, compare artifacts, legacy empty/populated pairs for what is now DataFree). Dry-run by default. - `docs/parity-gallery.md` rewritten: canonical-manifest workflow, adding-a-screen guide, variant matrix explained. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-20 18:10:32 -05:00
parent 316b1f709d
commit 9fa58352c0
298 changed files with 2496 additions and 1343 deletions
@@ -0,0 +1,74 @@
+package com.tt.honeyDue.testing
+
+import kotlin.test.Test
+import kotlin.test.assertEquals
+import kotlin.test.assertTrue
+import kotlin.test.fail
+
+/**
+ * Sanity checks on the canonical parity-gallery manifest.
+ *
+ * These run on every platform's test target because the manifest lives in
+ * [commonMain]; they guard against obvious mistakes (duplicate names,
+ * empty-platform screens) before the platform-specific parity tests run.
+ */
+class GalleryManifestTest {
+
+    @Test
+    fun manifest_has_no_duplicate_names() {
+        val duplicates = GalleryScreens.all
+            .groupingBy { it.name }
+            .eachCount()
+            .filterValues { it > 1 }
+        assertTrue(
+            duplicates.isEmpty(),
+            "Duplicate canonical screen names in manifest: $duplicates",
+        )
+    }
+
+    @Test
+    fun every_screen_has_at_least_one_platform() {
+        val orphans = GalleryScreens.all.filter { it.platforms.isEmpty() }
+        assertTrue(
+            orphans.isEmpty(),
+            "Screens with no platforms — they'd never be captured: ${orphans.map { it.name }}",
+        )
+    }
+
+    @Test
+    fun snake_case_names_only() {
+        val malformed = GalleryScreens.all.filter { !it.name.matches(Regex("^[a-z][a-z0-9_]*$")) }
+        assertTrue(
+            malformed.isEmpty(),
+            "Non-snake_case screen names: ${malformed.map { it.name }}",
+        )
+    }
+
+    @Test
+    fun expected_counts_match_plan() {
+        // Canaries: if someone adds/removes a screen without updating the
+        // docs/parity-gallery.md summary, this test fails loudly. Bump
+        // both in the same PR.
+        assertEquals(43, GalleryScreens.all.size, "Total canonical screen count")
+        assertEquals(
+            12,
+            GalleryScreens.all.count { it.category == GalleryCategory.DataCarrying },
+            "Data-carrying screen count",
+        )
+        assertEquals(
+            31,
+            GalleryScreens.all.count { it.category == GalleryCategory.DataFree },
+            "Data-free screen count",
+        )
+    }
+
+    @Test
+    fun android_subset_matches_count() {
+        assertEquals(40, GalleryScreens.forAndroid.size, "Android-reachable screen count")
+    }
+
+    @Test
+    fun ios_subset_matches_count() {
+        assertEquals(40, GalleryScreens.forIos.size, "iOS-reachable screen count")
+    }
+}