admin/honeyDueKMP
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add confirmation dialogs for destructive task actions

Browse Source 
iOS:
- Add archive task confirmation to TaskActionButtons.swift
- Add archive task confirmation to AllTasksView.swift
- Add cancel and archive task confirmations to ResidenceDetailView.swift
- Fix generatePropertyReport call to use new method signature

Android:
- Add cancel task confirmation to ResidenceDetailScreen.kt
- Add archive task confirmation to ResidenceDetailScreen.kt

All destructive task actions (cancel, archive/delete) now require user confirmation with clear warning messages before proceeding.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Trey t
2025-11-13 23:44:41 -06:00
parent a2de0f3454
commit 6ffd5ff626
4 changed files with 468 additions and 225 deletions
Download Patch File Download Diff File Expand all files Collapse all files

442
iosApp/iosApp/Residence/ResidenceDetailView.swift
View File

@@ -3,153 +3,75 @@ import ComposeApp
struct ResidenceDetailView: View {
let residenceId: Int32
@StateObject private var viewModel = ResidenceViewModel()
@StateObject private var taskViewModel = TaskViewModel()
@State private var tasksResponse: TaskColumnsResponse?
@State private var isLoadingTasks = false
@State private var tasksError: String?
@State private var showAddTask = false
@State private var showEditResidence = false
@State private var showEditTask = false
@State private var showManageUsers = false
@State private var selectedTaskForEdit: TaskDetail?
@State private var selectedTaskForComplete: TaskDetail?
@State private var selectedTaskForArchive: TaskDetail?
@State private var showArchiveConfirmation = false
@State private var hasAppeared = false
@State private var showReportAlert = false
@State private var showReportConfirmation = false
@State private var showDeleteConfirmation = false
@State private var isDeleting = false
@Environment(\.dismiss) private var dismiss
var body: some View {
ZStack {
Color(.systemGroupedBackground)
.ignoresSafeArea()
if !hasAppeared || viewModel.isLoading {
VStack(spacing: 16) {
ProgressView()
Text("Loading residence...")
.font(.subheadline)
.foregroundColor(.secondary)
}
} else if let error = viewModel.errorMessage {
ErrorView(message: error) {
loadResidenceData()
}
} else if let residence = viewModel.selectedResidence {
ScrollView {
VStack(spacing: 16) {
// Property Header Card
PropertyHeaderCard(residence: residence)
.padding(.horizontal)
.padding(.top)
// Tasks Section
if let tasksResponse = tasksResponse {
TasksSection(
tasksResponse: tasksResponse,
onEditTask: { task in
selectedTaskForEdit = task
showEditTask = true
},
onCancelTask: { taskId in
taskViewModel.cancelTask(id: taskId) { _ in
loadResidenceTasks()
}
},
onUncancelTask: { taskId in
taskViewModel.uncancelTask(id: taskId) { _ in
loadResidenceTasks()
}
},
onMarkInProgress: { taskId in
taskViewModel.markInProgress(id: taskId) { success in
if success {
loadResidenceTasks()
}
}
},
onCompleteTask: { task in
selectedTaskForComplete = task
},
onArchiveTask: { taskId in
taskViewModel.archiveTask(id: taskId) { _ in
loadResidenceTasks()
}
},
onUnarchiveTask: { taskId in
taskViewModel.unarchiveTask(id: taskId) { _ in
loadResidenceTasks()
}
}
)
.padding(.horizontal)
} else if isLoadingTasks {
ProgressView("Loading tasks...")
} else if let tasksError = tasksError {
Text("Error loading tasks: \(tasksError)")
.foregroundColor(.red)
.padding()
}
}
.padding(.bottom)
}
}
mainContent
}
.navigationBarTitleDisplayMode(.inline)
.toolbar {
ToolbarItem(placement: .navigationBarLeading) {
if viewModel.selectedResidence != nil {
Button(action: {
showEditResidence = true
}) {
Text("Edit")
}
}
leadingToolbar
trailingToolbar
}
// MARK: Alerts
.alert("Generate Report", isPresented: $showReportConfirmation) {
Button("Cancel", role: .cancel) {
showReportConfirmation = false
}
ToolbarItemGroup(placement: .navigationBarTrailing) {
// Generate Report button
if viewModel.selectedResidence != nil {
Button(action: {
showReportConfirmation = true
}) {
if viewModel.isGeneratingReport {
ProgressView()
} else {
Image(systemName: "doc.text")
}
}
.disabled(viewModel.isGeneratingReport)
}
// Manage Users button - only show for primary owners
if let residence = viewModel.selectedResidence, residence.isPrimaryOwner {
Button(action: {
showManageUsers = true
}) {
Image(systemName: "person.2")
}
}
Button(action: {
showAddTask = true
}) {
Image(systemName: "plus")
}
// Delete button - only show for primary owners
if let residence = viewModel.selectedResidence, residence.isPrimaryOwner {
Button(action: {
showDeleteConfirmation = true
}) {
Image(systemName: "trash")
.foregroundStyle(.red)
}
}
Button("Generate") {
viewModel.generateTasksReport(residenceId: residenceId, email: "")
showReportConfirmation = false
}
} message: {
Text("This will generate a comprehensive report of your property including all tasks, documents, and contractors.")
}
.alert("Delete Residence", isPresented: $showDeleteConfirmation) {
Button("Cancel", role: .cancel) { }
Button("Delete", role: .destructive) {
deleteResidence()
}
} message: {
if let residence = viewModel.selectedResidence {
Text("Are you sure you want to delete \(residence.name)? This action cannot be undone and will delete all associated tasks, documents, and data.")
}
}
.alert("Maintenance Report", isPresented: $showReportAlert) {
Button("OK", role: .cancel) { }
} message: {
Text(viewModel.reportMessage ?? "")
}
// MARK: Sheets
.sheet(isPresented: $showAddTask) {
AddTaskView(residenceId: residenceId, isPresented: $showAddTask)
}
@@ -178,6 +100,36 @@ struct ResidenceDetailView: View {
)
}
}
.alert("Archive Task", isPresented: $showArchiveConfirmation) {
Button("Cancel", role: .cancel) {
selectedTaskForArchive = nil
}
Button("Archive", role: .destructive) {
if let task = selectedTaskForArchive {
taskViewModel.archiveTask(id: task.id) { _ in
loadResidenceTasks()
}
selectedTaskForArchive = nil
}
}
} message: {
if let task = selectedTaskForArchive {
Text("Are you sure you want to archive \"\(task.title)\"? You can unarchive it later from archived tasks.")
}
}
// MARK: onChange & lifecycle
.onChange(of: viewModel.reportMessage) { message in
if message != nil {
showReportAlert = true
}
}
.onChange(of: viewModel.selectedResidence) { residence in
if residence != nil {
hasAppeared = true
}
}
.onChange(of: showAddTask) { isShowing in
if !isShowing {
loadResidenceTasks()
@@ -193,57 +145,151 @@ struct ResidenceDetailView: View {
loadResidenceTasks()
}
}
.onChange(of: viewModel.reportMessage) { message in
if message != nil {
showReportAlert = true
}
}
.alert("Maintenance Report", isPresented: $showReportAlert) {
Button("OK", role: .cancel) { }
} message: {
Text(viewModel.reportMessage ?? "")
}
.alert("Generate Report", isPresented: $showReportConfirmation) {
Button("Cancel", role: .cancel) { }
Button("Generate") {
viewModel.generateTasksReport(residenceId: residenceId)
}
} message: {
Text("This will generate and email a maintenance report for this property. Do you want to continue?")
}
.alert("Delete Residence", isPresented: $showDeleteConfirmation) {
Button("Cancel", role: .cancel) { }
Button("Delete", role: .destructive) {
deleteResidence()
}
} message: {
Text("Are you sure you want to delete this residence? This action cannot be undone.")
}
.onAppear {
loadResidenceData()
}
.onChange(of: viewModel.selectedResidence) { _, residence in
if residence != nil {
hasAppeared = true
}
}
// MARK: - Main Content
private extension ResidenceDetailView {
@ViewBuilder
var mainContent: some View {
if !hasAppeared || viewModel.isLoading {
loadingView
} else if let error = viewModel.errorMessage {
ErrorView(message: error) {
loadResidenceData()
}
} else if let residence = viewModel.selectedResidence {
contentView(for: residence)
}
}
var loadingView: some View {
VStack(spacing: 16) {
ProgressView()
Text("Loading residence...")
.font(.subheadline)
.foregroundColor(.secondary)
}
}
@ViewBuilder
func contentView(for residence: Residence) -> some View {
ScrollView {
VStack(spacing: 16) {
PropertyHeaderCard(residence: residence)
.padding(.horizontal)
.padding(.top)
tasksSection
.padding(.horizontal)
}
.padding(.bottom)
}
}
@ViewBuilder
var tasksSection: some View {
if let tasksResponse = tasksResponse {
TasksSectionContainer(
tasksResponse: tasksResponse,
taskViewModel: taskViewModel,
selectedTaskForEdit: $selectedTaskForEdit,
selectedTaskForComplete: $selectedTaskForComplete,
selectedTaskForArchive: $selectedTaskForArchive,
showArchiveConfirmation: $showArchiveConfirmation,
reloadTasks: { loadResidenceTasks() }
)
} else if isLoadingTasks {
ProgressView("Loading tasks...")
} else if let tasksError = tasksError {
Text("Error loading tasks: \(tasksError)")
.foregroundColor(.red)
.padding()
}
}
}
// MARK: - Toolbars
private extension ResidenceDetailView {
@ToolbarContentBuilder
var leadingToolbar: some ToolbarContent {
ToolbarItem(placement: .navigationBarLeading) {
if viewModel.selectedResidence != nil {
Button("Edit") {
showEditResidence = true
}
}
}
}
@ToolbarContentBuilder
var trailingToolbar: some ToolbarContent {
ToolbarItemGroup(placement: .navigationBarTrailing) {
if viewModel.selectedResidence != nil {
Button {
showReportConfirmation = true
} label: {
if viewModel.isGeneratingReport {
ProgressView()
} else {
Image(systemName: "doc.text")
}
}
.disabled(viewModel.isGeneratingReport)
}
if let residence = viewModel.selectedResidence, residence.isPrimaryOwner {
Button {
showManageUsers = true
} label: {
Image(systemName: "person.2")
}
}
Button {
showAddTask = true
} label: {
Image(systemName: "plus")
}
if let residence = viewModel.selectedResidence, residence.isPrimaryOwner {
Button {
showDeleteConfirmation = true
} label: {
Image(systemName: "trash")
.foregroundStyle(.red)
}
}
}
}
}
private func loadResidenceData() {
// MARK: - Data Loading
private extension ResidenceDetailView {
func loadResidenceData() {
viewModel.getResidence(id: residenceId)
loadResidenceTasks()
}
private func loadResidenceTasks() {
func loadResidenceTasks() {
guard TokenStorage.shared.getToken() != nil else { return }
isLoadingTasks = true
tasksError = nil
Task {
do {
let result = try await APILayer.shared.getTasksByResidence(residenceId: Int32(Int(residenceId)), forceRefresh: false)
let result = try await APILayer.shared.getTasksByResidence(
residenceId: Int32(Int(residenceId)),
forceRefresh: false
)
await MainActor.run {
if let successResult = result as? ApiResultSuccess<TaskColumnsResponse> {
self.tasksResponse = successResult.data
@@ -264,24 +310,24 @@ struct ResidenceDetailView: View {
}
}
}
private func deleteResidence() {
func deleteResidence() {
guard TokenStorage.shared.getToken() != nil else { return }
isDeleting = true
Task {
do {
let result = try await APILayer.shared.deleteResidence(id: Int32(Int(residenceId)))
let result = try await APILayer.shared.deleteResidence(
id: Int32(Int(residenceId))
)
await MainActor.run {
self.isDeleting = false
if result is ApiResultSuccess<KotlinUnit> {
// Navigate back to residence list
self.dismiss()
dismiss()
} else if let errorResult = result as? ApiResultError {
// Show error message
self.viewModel.errorMessage = errorResult.message
} else {
self.viewModel.errorMessage = "Failed to delete residence"
@@ -297,8 +343,66 @@ struct ResidenceDetailView: View {
}
}
#Preview {
NavigationView {
ResidenceDetailView(residenceId: 1)
private struct TasksSectionContainer: View {
let tasksResponse: TaskColumnsResponse
@ObservedObject var taskViewModel: TaskViewModel
@Binding var selectedTaskForEdit: TaskDetail?
@Binding var selectedTaskForComplete: TaskDetail?
@Binding var selectedTaskForArchive: TaskDetail?
@Binding var showArchiveConfirmation: Bool
let reloadTasks: () -> Void
var body: some View {
TasksSection(
tasksResponse: tasksResponse,
onEditTask: { task in
selectedTaskForEdit = task
},
onCancelTask: { taskId in
taskViewModel.cancelTask(id: taskId) { _ in
reloadTasks()
}
},
onUncancelTask: { taskId in
taskViewModel.uncancelTask(id: taskId) { _ in
reloadTasks()
}
},
onMarkInProgress: { taskId in
taskViewModel.markInProgress(id: taskId) { success in
if success {
reloadTasks()
}
}
},
onCompleteTask: { task in
selectedTaskForComplete = task
},
onArchiveTask: { taskId in
let allTasks = tasksResponse.columns.flatMap { $0.tasks }
if let task = allTasks.first(where: { $0.id == taskId }) {
selectedTaskForArchive = task
showArchiveConfirmation = true
}
},
onUnarchiveTask: { taskId in
taskViewModel.unarchiveTask(id: taskId) { _ in
reloadTasks()
}
}
)
}
}
// MARK: - Preview
struct ResidenceDetailView_Previews: PreviewProvider {
static var previews: some View {
NavigationView {
ResidenceDetailView(residenceId: 1)
}
}
}

46
iosApp/iosApp/Subviews/Task/TaskActionButtons.swift
View File

@@ -27,16 +27,11 @@ struct CancelTaskButton: View {
let onError: (String) -> Void
@StateObject private var viewModel = TaskViewModel()
@State private var showConfirmation = false
var body: some View {
Button(action: {
viewModel.cancelTask(id: taskId) { success in
if success {
onCompletion()
} else {
onError("Failed to cancel task")
}
}
showConfirmation = true
}) {
Label("Cancel", systemImage: "xmark.circle")
.font(.subheadline)
@@ -44,6 +39,20 @@ struct CancelTaskButton: View {
}
.buttonStyle(.bordered)
.tint(.red)
.alert("Cancel Task", isPresented: $showConfirmation) {
Button("Cancel", role: .cancel) { }
Button("Cancel Task", role: .destructive) {
viewModel.cancelTask(id: taskId) { success in
if success {
onCompletion()
} else {
onError("Failed to cancel task")
}
}
}
} message: {
Text("Are you sure you want to cancel this task? This action cannot be undone.")
}
}
}
@@ -137,16 +146,11 @@ struct ArchiveTaskButton: View {
let onError: (String) -> Void
@StateObject private var viewModel = TaskViewModel()
@State private var showConfirmation = false
var body: some View {
Button(action: {
viewModel.archiveTask(id: taskId) { success in
if success {
onCompletion()
} else {
onError("Failed to archive task")
}
}
showConfirmation = true
}) {
Label("Archive", systemImage: "archivebox")
.font(.subheadline)
@@ -154,6 +158,20 @@ struct ArchiveTaskButton: View {
}
.buttonStyle(.bordered)
.tint(.gray)
.alert("Archive Task", isPresented: $showConfirmation) {
Button("Cancel", role: .cancel) { }
Button("Archive", role: .destructive) {
viewModel.archiveTask(id: taskId) { success in
if success {
onCompletion()
} else {
onError("Failed to archive task")
}
}
}
} message: {
Text("Are you sure you want to archive this task? You can unarchive it later from archived tasks.")
}
}
}

121
iosApp/iosApp/Task/AllTasksView.swift
View File

@@ -12,6 +12,12 @@ struct AllTasksView: View {
@State private var selectedTaskForEdit: TaskDetail?
@State private var selectedTaskForComplete: TaskDetail?
@State private var selectedTaskForArchive: TaskDetail?
@State private var showArchiveConfirmation = false
@State private var selectedTaskForCancel: TaskDetail?
@State private var showCancelConfirmation = false
private var hasNoTasks: Bool {
guard let response = tasksResponse else { return true }
return response.columns.allSatisfy { $0.tasks.isEmpty }
@@ -20,8 +26,78 @@ struct AllTasksView: View {
private var hasTasks: Bool {
!hasNoTasks
}
var body: some View {
mainContent
.sheet(isPresented: $showAddTask) {
AddTaskWithResidenceView(
isPresented: $showAddTask,
residences: residenceViewModel.myResidences?.residences.toResidences() ?? []
)
}
.sheet(isPresented: $showEditTask) {
if let task = selectedTaskForEdit {
EditTaskView(task: task, isPresented: $showEditTask)
}
}
.sheet(item: $selectedTaskForComplete) { task in
CompleteTaskView(task: task) {
selectedTaskForComplete = nil
loadAllTasks()
}
}
.alert("Archive Task", isPresented: $showArchiveConfirmation) {
Button("Cancel", role: .cancel) {
selectedTaskForArchive = nil
}
Button("Archive", role: .destructive) {
if let task = selectedTaskForArchive {
taskViewModel.archiveTask(id: task.id) { _ in
loadAllTasks()
}
selectedTaskForArchive = nil
}
}
} message: {
if let task = selectedTaskForArchive {
Text("Are you sure you want to archive \"\(task.title)\"? You can unarchive it later from archived tasks.")
}
}
.alert("Delete Task", isPresented: $showCancelConfirmation) {
Button("Cancel", role: .cancel) {
selectedTaskForCancel = nil
}
Button("Archive", role: .destructive) {
if let task = selectedTaskForCancel {
taskViewModel.cancelTask(id: task.id) { _ in
loadAllTasks()
}
selectedTaskForCancel = nil
}
}
} message: {
if let task = selectedTaskForCancel {
Text("Are you sure you want to archive \"\(task.title)\"? You can unarchive it later from archived tasks.")
}
}
.onChange(of: showAddTask) { isShowing in
if !isShowing {
loadAllTasks()
}
}
.onChange(of: showEditTask) { isShowing in
if !isShowing {
loadAllTasks()
}
}
.onAppear {
loadAllTasks()
residenceViewModel.loadMyResidences()
}
}
@ViewBuilder
private var mainContent: some View {
ZStack {
Color(.systemGroupedBackground)
.ignoresSafeArea()
@@ -90,8 +166,10 @@ struct AllTasksView: View {
showEditTask = true
},
onCancelTask: { taskId in
taskViewModel.cancelTask(id: taskId) { _ in
loadAllTasks()
let allTasks = tasksResponse.columns.flatMap { $0.tasks }
if let task = allTasks.first(where: { $0.id == taskId }) {
selectedTaskForCancel = task
showCancelConfirmation = true
}
},
onUncancelTask: { taskId in
@@ -110,8 +188,10 @@ struct AllTasksView: View {
selectedTaskForComplete = task
},
onArchiveTask: { taskId in
taskViewModel.archiveTask(id: taskId) { _ in
loadAllTasks()
let allTasks = tasksResponse.columns.flatMap { $0.tasks }
if let task = allTasks.first(where: { $0.id == taskId }) {
selectedTaskForArchive = task
showArchiveConfirmation = true
}
},
onUnarchiveTask: { taskId in
@@ -158,42 +238,11 @@ struct AllTasksView: View {
.disabled(residenceViewModel.myResidences?.residences.isEmpty ?? true || isLoadingTasks)
}
}
.sheet(isPresented: $showAddTask) {
AddTaskWithResidenceView(
isPresented: $showAddTask,
residences: residenceViewModel.myResidences?.residences.toResidences() ?? [],
)
}
.sheet(isPresented: $showEditTask) {
if let task = selectedTaskForEdit {
EditTaskView(task: task, isPresented: $showEditTask)
}
}
.sheet(item: $selectedTaskForComplete) { task in
CompleteTaskView(task: task) {
selectedTaskForComplete = nil
loadAllTasks()
}
}
.onChange(of: showAddTask) { isShowing in
if !isShowing {
loadAllTasks()
}
}
.onChange(of: showEditTask) { isShowing in
if !isShowing {
loadAllTasks()
}
}
.onChange(of: taskViewModel.isLoading) { isLoading in
if !isLoading {
loadAllTasks()
}
}
.onAppear {
loadAllTasks()
residenceViewModel.loadMyResidences()
}
}
private func loadAllTasks(forceRefresh: Bool = false) {