Rearchitect UI test suite for complete, non-flaky coverage against live API
- Migrate Suite4-10, SmokeTests, NavigationCriticalPathTests to AuthenticatedTestCase with seeded admin account and real backend login - Add 34 accessibility identifiers across 11 app views (task completion, profile, notifications, theme, join residence, manage users, forms) - Create FeatureCoverageTests (14 tests) covering previously untested features: profile edit, theme selection, notification prefs, task completion, manage users, join residence, task templates - Create MultiUserSharingTests (18 API tests) and MultiUserSharingUITests (8 XCUI tests) for full cross-user residence sharing lifecycle - Add cleanup infrastructure: SuiteZZ_CleanupTests auto-wipes test data after runs, cleanup_test_data.sh script for manual reset via admin API - Add share code API methods to TestAccountAPIClient (generateShareCode, joinWithCode, getShareCode, listResidenceUsers, removeUser) - Fix app bugs found by tests: - ResidencesListView join callback now uses forceRefresh:true - APILayer invalidates task cache when residence count changes - AllTasksView auto-reloads tasks when residence list changes - Fix test quality: keyboard focus waits, Save/Add button label matching, Documents tab label (Docs), remove API verification from UI tests - DataLayerTests and PasswordResetTests now verify through UI, not API calls Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -93,6 +93,7 @@ struct CompleteTaskView: View {
|
||||
.foregroundStyle(.tertiary)
|
||||
}
|
||||
}
|
||||
.accessibilityIdentifier("TaskCompletion.ContractorPicker")
|
||||
} header: {
|
||||
Text(L10n.Tasks.contractorOptional)
|
||||
} footer: {
|
||||
@@ -120,6 +121,7 @@ struct CompleteTaskView: View {
|
||||
}
|
||||
.padding(.leading, 12)
|
||||
.keyboardDismissToolbar()
|
||||
.accessibilityIdentifier(AccessibilityIdentifiers.Task.actualCostField)
|
||||
} label: {
|
||||
Label(L10n.Tasks.actualCost, systemImage: "dollarsign.circle")
|
||||
}
|
||||
@@ -141,6 +143,7 @@ struct CompleteTaskView: View {
|
||||
.frame(minHeight: 100)
|
||||
.scrollContentBackground(.hidden)
|
||||
.keyboardDismissToolbar()
|
||||
.accessibilityIdentifier(AccessibilityIdentifiers.Task.notesField)
|
||||
}
|
||||
} footer: {
|
||||
Text(L10n.Tasks.optionalNotes)
|
||||
@@ -176,6 +179,7 @@ struct CompleteTaskView: View {
|
||||
}
|
||||
.frame(maxWidth: .infinity)
|
||||
}
|
||||
.accessibilityIdentifier(AccessibilityIdentifiers.Task.ratingView)
|
||||
} footer: {
|
||||
Text(L10n.Tasks.rateQuality)
|
||||
}
|
||||
@@ -263,6 +267,7 @@ struct CompleteTaskView: View {
|
||||
.frame(maxWidth: .infinity)
|
||||
.fontWeight(.semibold)
|
||||
}
|
||||
.accessibilityIdentifier(AccessibilityIdentifiers.Task.submitButton)
|
||||
.listRowBackground(isSubmitting ? Color.gray : Color.appPrimary)
|
||||
.foregroundStyle(Color.appTextOnPrimary)
|
||||
.disabled(isSubmitting)
|
||||
|
||||
Reference in New Issue
Block a user