Rearchitect UI test suite for complete, non-flaky coverage against live API
- Migrate Suite4-10, SmokeTests, NavigationCriticalPathTests to AuthenticatedTestCase with seeded admin account and real backend login - Add 34 accessibility identifiers across 11 app views (task completion, profile, notifications, theme, join residence, manage users, forms) - Create FeatureCoverageTests (14 tests) covering previously untested features: profile edit, theme selection, notification prefs, task completion, manage users, join residence, task templates - Create MultiUserSharingTests (18 API tests) and MultiUserSharingUITests (8 XCUI tests) for full cross-user residence sharing lifecycle - Add cleanup infrastructure: SuiteZZ_CleanupTests auto-wipes test data after runs, cleanup_test_data.sh script for manual reset via admin API - Add share code API methods to TestAccountAPIClient (generateShareCode, joinWithCode, getShareCode, listResidenceUsers, removeUser) - Fix app bugs found by tests: - ResidencesListView join callback now uses forceRefresh:true - APILayer invalidates task cache when residence count changes - AllTasksView auto-reloads tasks when residence list changes - Fix test quality: keyboard focus waits, Save/Add button label matching, Documents tab label (Docs), remove API verification from UI tests - DataLayerTests and PasswordResetTests now verify through UI, not API calls Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -60,6 +60,7 @@ struct ContractorFormSheet: View {
|
||||
.frame(width: 24)
|
||||
TextField(L10n.Contractors.nameLabel, text: $name)
|
||||
.focused($focusedField, equals: .name)
|
||||
.accessibilityIdentifier(AccessibilityIdentifiers.Contractor.nameField)
|
||||
}
|
||||
|
||||
HStack {
|
||||
@@ -68,6 +69,7 @@ struct ContractorFormSheet: View {
|
||||
.frame(width: 24)
|
||||
TextField(L10n.Contractors.companyLabel, text: $company)
|
||||
.focused($focusedField, equals: .company)
|
||||
.accessibilityIdentifier(AccessibilityIdentifiers.Contractor.companyField)
|
||||
}
|
||||
} header: {
|
||||
Text(L10n.Contractors.basicInfoSection)
|
||||
@@ -116,6 +118,7 @@ struct ContractorFormSheet: View {
|
||||
.keyboardType(.phonePad)
|
||||
.focused($focusedField, equals: .phone)
|
||||
.keyboardDismissToolbar()
|
||||
.accessibilityIdentifier(AccessibilityIdentifiers.Contractor.phoneField)
|
||||
}
|
||||
|
||||
HStack {
|
||||
@@ -127,6 +130,7 @@ struct ContractorFormSheet: View {
|
||||
.textInputAutocapitalization(.never)
|
||||
.autocorrectionDisabled()
|
||||
.focused($focusedField, equals: .email)
|
||||
.accessibilityIdentifier(AccessibilityIdentifiers.Contractor.emailField)
|
||||
}
|
||||
|
||||
HStack {
|
||||
@@ -168,6 +172,7 @@ struct ContractorFormSheet: View {
|
||||
.foregroundColor(Color.appTextSecondary.opacity(0.7))
|
||||
}
|
||||
}
|
||||
.accessibilityIdentifier(AccessibilityIdentifiers.Contractor.specialtyPicker)
|
||||
} header: {
|
||||
Text(L10n.Contractors.specialtiesSection)
|
||||
}
|
||||
@@ -226,6 +231,7 @@ struct ContractorFormSheet: View {
|
||||
.frame(height: 100)
|
||||
.focused($focusedField, equals: .notes)
|
||||
.keyboardDismissToolbar()
|
||||
.accessibilityIdentifier(AccessibilityIdentifiers.Contractor.notesField)
|
||||
}
|
||||
} header: {
|
||||
Text(L10n.Contractors.notesSection)
|
||||
@@ -269,6 +275,7 @@ struct ContractorFormSheet: View {
|
||||
Button(L10n.Common.cancel) {
|
||||
dismiss()
|
||||
}
|
||||
.accessibilityIdentifier(AccessibilityIdentifiers.Contractor.formCancelButton)
|
||||
}
|
||||
|
||||
ToolbarItem(placement: .confirmationAction) {
|
||||
@@ -281,6 +288,7 @@ struct ContractorFormSheet: View {
|
||||
}
|
||||
}
|
||||
.disabled(!canSave || viewModel.isCreating || viewModel.isUpdating)
|
||||
.accessibilityIdentifier(AccessibilityIdentifiers.Contractor.saveButton)
|
||||
}
|
||||
}
|
||||
.sheet(isPresented: $showingResidencePicker) {
|
||||
|
||||
Reference in New Issue
Block a user