Rearchitect UI test suite for complete, non-flaky coverage against live API

- Migrate Suite4-10, SmokeTests, NavigationCriticalPathTests to AuthenticatedTestCase
  with seeded admin account and real backend login
- Add 34 accessibility identifiers across 11 app views (task completion, profile,
  notifications, theme, join residence, manage users, forms)
- Create FeatureCoverageTests (14 tests) covering previously untested features:
  profile edit, theme selection, notification prefs, task completion, manage users,
  join residence, task templates
- Create MultiUserSharingTests (18 API tests) and MultiUserSharingUITests (8 XCUI
  tests) for full cross-user residence sharing lifecycle
- Add cleanup infrastructure: SuiteZZ_CleanupTests auto-wipes test data after runs,
  cleanup_test_data.sh script for manual reset via admin API
- Add share code API methods to TestAccountAPIClient (generateShareCode, joinWithCode,
  getShareCode, listResidenceUsers, removeUser)
- Fix app bugs found by tests:
  - ResidencesListView join callback now uses forceRefresh:true
  - APILayer invalidates task cache when residence count changes
  - AllTasksView auto-reloads tasks when residence list changes
- Fix test quality: keyboard focus waits, Save/Add button label matching,
  Documents tab label (Docs), remove API verification from UI tests
- DataLayerTests and PasswordResetTests now verify through UI, not API calls

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
treyt
2026-03-15 17:32:13 -05:00
parent cf2e6d8bcc
commit 5c360a2796
57 changed files with 3781 additions and 928 deletions

View File

@@ -54,7 +54,7 @@ final class Suite3_ResidenceTests: BaseUITestCase {
XCTAssertTrue(residencesHeader.waitForExistence(timeout: 5), "Residences list screen must be visible")
// Add button must exist
let addButton = app.buttons[AccessibilityIdentifiers.Residence.addButton]
let addButton = app.buttons[AccessibilityIdentifiers.Residence.addButton].firstMatch
XCTAssertTrue(addButton.exists, "Add residence button must exist")
}
@@ -65,7 +65,7 @@ final class Suite3_ResidenceTests: BaseUITestCase {
navigateToResidencesTab()
// When: User taps add residence button (using accessibility identifier to avoid wrong button)
let addButton = app.buttons[AccessibilityIdentifiers.Residence.addButton]
let addButton = app.buttons[AccessibilityIdentifiers.Residence.addButton].firstMatch
XCTAssertTrue(addButton.waitForExistence(timeout: 5), "Add residence button should exist")
addButton.tap()
@@ -110,7 +110,7 @@ final class Suite3_ResidenceTests: BaseUITestCase {
// Given: User is on add residence form
navigateToResidencesTab()
let addButton = app.buttons[AccessibilityIdentifiers.Residence.addButton]
let addButton = app.buttons[AccessibilityIdentifiers.Residence.addButton].firstMatch
addButton.tap()
sleep(2)
@@ -132,7 +132,7 @@ final class Suite3_ResidenceTests: BaseUITestCase {
navigateToResidencesTab()
// Use accessibility identifier to get the correct add button
let addButton = app.buttons[AccessibilityIdentifiers.Residence.addButton]
let addButton = app.buttons[AccessibilityIdentifiers.Residence.addButton].firstMatch
XCTAssertTrue(addButton.exists, "Add residence button should exist")
addButton.tap()
sleep(2)