Rearchitect UI test suite for complete, non-flaky coverage against live API

- Migrate Suite4-10, SmokeTests, NavigationCriticalPathTests to AuthenticatedTestCase
  with seeded admin account and real backend login
- Add 34 accessibility identifiers across 11 app views (task completion, profile,
  notifications, theme, join residence, manage users, forms)
- Create FeatureCoverageTests (14 tests) covering previously untested features:
  profile edit, theme selection, notification prefs, task completion, manage users,
  join residence, task templates
- Create MultiUserSharingTests (18 API tests) and MultiUserSharingUITests (8 XCUI
  tests) for full cross-user residence sharing lifecycle
- Add cleanup infrastructure: SuiteZZ_CleanupTests auto-wipes test data after runs,
  cleanup_test_data.sh script for manual reset via admin API
- Add share code API methods to TestAccountAPIClient (generateShareCode, joinWithCode,
  getShareCode, listResidenceUsers, removeUser)
- Fix app bugs found by tests:
  - ResidencesListView join callback now uses forceRefresh:true
  - APILayer invalidates task cache when residence count changes
  - AllTasksView auto-reloads tasks when residence list changes
- Fix test quality: keyboard focus waits, Save/Add button label matching,
  Documents tab label (Docs), remove API verification from UI tests
- DataLayerTests and PasswordResetTests now verify through UI, not API calls

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

iosApp/HoneyDueUITests/PageObjects/MainTabScreen.swift

@@ -4,25 +4,27 @@ import XCTest
 ///
 /// The app has 4 tabs: Residences, Tasks, Contractors, Documents.
 /// Profile is accessed via the settings button on the Residences screen.
-/// Uses accessibility identifiers for reliable element lookup.
+///
+/// Tab bar buttons are matched by label because SwiftUI's `.accessibilityIdentifier()`
+/// on tab content does not propagate to the tab bar button itself.
 class MainTabScreen: BaseScreen {
 
     // MARK: - Tab Elements
 
     var residencesTab: XCUIElement {
-        app.tabBars.buttons[AccessibilityIdentifiers.Navigation.residencesTab]
+        app.tabBars.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Residences'")).firstMatch
     }
 
     var tasksTab: XCUIElement {
-        app.tabBars.buttons[AccessibilityIdentifiers.Navigation.tasksTab]
+        app.tabBars.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Tasks'")).firstMatch
     }
 
     var contractorsTab: XCUIElement {
-        app.tabBars.buttons[AccessibilityIdentifiers.Navigation.contractorsTab]
+        app.tabBars.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Contractors'")).firstMatch
     }
 
     var documentsTab: XCUIElement {
-        app.tabBars.buttons[AccessibilityIdentifiers.Navigation.documentsTab]
+        app.tabBars.buttons.containing(NSPredicate(format: "label CONTAINS[c] 'Doc'")).firstMatch
     }
 
     /// Settings button on the Residences tab (leads to profile/settings).
@@ -75,18 +77,40 @@ class MainTabScreen: BaseScreen {
     func logout() {
         goToSettings()
 
+        // The profile sheet uses a SwiftUI List (lazy CollectionView).
+        // The logout button is near the bottom and may not exist in the
+        // accessibility tree until scrolled into view.
         let logoutButton = app.buttons[AccessibilityIdentifiers.Profile.logoutButton]
-        if logoutButton.waitForExistence(timeout: 5) {
-            waitForHittable(logoutButton).tap()
 
-            // Handle confirmation alert
-            let alert = app.alerts.firstMatch
-            if alert.waitForExistence(timeout: 3) {
-                let confirmLogout = alert.buttons["Log Out"]
-                if confirmLogout.exists {
-                    confirmLogout.tap()
+        if !logoutButton.waitForExistence(timeout: 3) {
+            // Scroll down in the sheet to reveal the logout button
+            let collectionView = app.collectionViews.firstMatch
+            if collectionView.exists {
+                for _ in 0..<5 {
+                    collectionView.swipeUp()
+                    if logoutButton.waitForExistence(timeout: 1) { break }
                 }
             }
         }
+
+        guard logoutButton.waitForExistence(timeout: 5) else {
+            XCTFail("Logout button not found in settings sheet after scrolling")
+            return
+        }
+
+        if logoutButton.isHittable {
+            logoutButton.tap()
+        } else {
+            logoutButton.forceTap()
+        }
+
+        // Handle confirmation alert
+        let alert = app.alerts.firstMatch
+        if alert.waitForExistence(timeout: 5) {
+            let confirmLogout = alert.buttons["Log Out"]
+            if confirmLogout.waitForExistence(timeout: 3) {
+                confirmLogout.tap()
+            }
+        }
     }
 }