Rearchitect UI test suite for complete, non-flaky coverage against live API

- Migrate Suite4-10, SmokeTests, NavigationCriticalPathTests to AuthenticatedTestCase
  with seeded admin account and real backend login
- Add 34 accessibility identifiers across 11 app views (task completion, profile,
  notifications, theme, join residence, manage users, forms)
- Create FeatureCoverageTests (14 tests) covering previously untested features:
  profile edit, theme selection, notification prefs, task completion, manage users,
  join residence, task templates
- Create MultiUserSharingTests (18 API tests) and MultiUserSharingUITests (8 XCUI
  tests) for full cross-user residence sharing lifecycle
- Add cleanup infrastructure: SuiteZZ_CleanupTests auto-wipes test data after runs,
  cleanup_test_data.sh script for manual reset via admin API
- Add share code API methods to TestAccountAPIClient (generateShareCode, joinWithCode,
  getShareCode, listResidenceUsers, removeUser)
- Fix app bugs found by tests:
  - ResidencesListView join callback now uses forceRefresh:true
  - APILayer invalidates task cache when residence count changes
  - AllTasksView auto-reloads tasks when residence list changes
- Fix test quality: keyboard focus waits, Save/Add button label matching,
  Documents tab label (Docs), remove API verification from UI tests
- DataLayerTests and PasswordResetTests now verify through UI, not API calls

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

iosApp/HoneyDueUITests/Framework/TestFlows.swift

@@ -3,11 +3,29 @@ import XCTest
 enum TestFlows {
     @discardableResult
     static func navigateToLoginFromOnboarding(app: XCUIApplication) -> LoginScreenObject {
-        let welcome = OnboardingWelcomeScreen(app: app)
-        welcome.waitForLoad()
-        welcome.tapAlreadyHaveAccount()
-
         let login = LoginScreenObject(app: app)
+
+        // If already on standalone login screen, return immediately.
+        // Use a generous timeout — the app may still be rendering after launch.
+        if app.textFields[UITestID.Auth.usernameField].waitForExistence(timeout: 10)
+            || app.otherElements[UITestID.Root.login].waitForExistence(timeout: 3) {
+            login.waitForLoad()
+            return login
+        }
+
+        // Check if onboarding is actually present before trying to navigate from it
+        let onboardingRoot = app.otherElements[UITestID.Root.onboarding]
+        if onboardingRoot.waitForExistence(timeout: 5) {
+            // Navigate from onboarding welcome
+            let welcome = OnboardingWelcomeScreen(app: app)
+            welcome.waitForLoad()
+            welcome.tapAlreadyHaveAccount()
+            login.waitForLoad()
+            return login
+        }
+
+        // Fallback: use ensureOnLoginScreen which handles all edge cases
+        UITestHelpers.ensureOnLoginScreen(app: app)
         login.waitForLoad()
         return login
     }
@@ -79,8 +97,9 @@ enum TestFlows {
     @discardableResult
     static func openRegisterFromLogin(app: XCUIApplication) -> RegisterScreenObject {
         let login: LoginScreenObject
-        let loginRoot = app.otherElements[UITestID.Root.login]
-        if loginRoot.exists || app.textFields[UITestID.Auth.usernameField].exists {
+        // Wait for login screen elements instead of instantaneous .exists checks
+        if app.textFields[UITestID.Auth.usernameField].waitForExistence(timeout: 10)
+            || app.otherElements[UITestID.Root.login].waitForExistence(timeout: 3) {
             login = LoginScreenObject(app: app)
             login.waitForLoad()
         } else {