UI test infrastructure overhaul — 58% to 96% pass rate (231/241)
Major infrastructure changes: - BaseUITestCase: per-suite app termination via class setUp() prevents stale state when parallel clones share simulators - relaunchBetweenTests override for suites that modify login/onboarding state - focusAndType: dedicated SecureTextField path handles iOS strong password autofill suggestions (Choose My Own Password / Not Now dialogs) - LoginScreenObject: tapSignUp/tapForgotPassword use scrollIntoView for offscreen buttons instead of simple swipeUp - Removed all coordinate taps from ForgotPasswordScreen, VerifyResetCodeScreen, ResetPasswordScreen (Rule 3 compliance) - Removed all usleep calls from screen objects (Rule 14 compliance) App fixes exposed by tests: - ContractorsListView: added onDismiss to sheet for list refresh after save - AllTasksView: added Task.RefreshButton accessibility identifier - AccessibilityIdentifiers: added Task.refreshButton - DocumentsWarrantiesView: onDismiss handler for document list refresh - Various form views: textContentType, submitLabel, onSubmit for keyboard flow Test fixes: - PasswordResetTests: handle auto-login after reset (app skips success screen) - AuthenticatedUITestCase: refreshTasks() helper for kanban toolbar button - All pre-login suites use relaunchBetweenTests for test independence - Deleted dead code: AuthenticatedTestCase, SeededTestData, SeedTests, CleanupTests, old Suite0/2/3, Suite1_RegistrationRebuildTests 10 remaining failures: 5 iOS strong password autofill (simulator env), 3 pull-to-refresh gesture on empty lists, 2 feature coverage edge cases. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -60,6 +60,9 @@ struct ContractorFormSheet: View {
|
||||
.frame(width: 24)
|
||||
TextField(L10n.Contractors.nameLabel, text: $name)
|
||||
.focused($focusedField, equals: .name)
|
||||
.textContentType(.name)
|
||||
.submitLabel(.next)
|
||||
.onSubmit { focusedField = .company }
|
||||
.accessibilityIdentifier(AccessibilityIdentifiers.Contractor.nameField)
|
||||
}
|
||||
|
||||
@@ -69,6 +72,9 @@ struct ContractorFormSheet: View {
|
||||
.frame(width: 24)
|
||||
TextField(L10n.Contractors.companyLabel, text: $company)
|
||||
.focused($focusedField, equals: .company)
|
||||
.textContentType(.organizationName)
|
||||
.submitLabel(.next)
|
||||
.onSubmit { focusedField = .phone }
|
||||
.accessibilityIdentifier(AccessibilityIdentifiers.Contractor.companyField)
|
||||
}
|
||||
} header: {
|
||||
@@ -116,6 +122,7 @@ struct ContractorFormSheet: View {
|
||||
.frame(width: 24)
|
||||
TextField(L10n.Contractors.phoneLabel, text: $phone)
|
||||
.keyboardType(.phonePad)
|
||||
.textContentType(.telephoneNumber)
|
||||
.focused($focusedField, equals: .phone)
|
||||
.keyboardDismissToolbar()
|
||||
.accessibilityIdentifier(AccessibilityIdentifiers.Contractor.phoneField)
|
||||
@@ -127,9 +134,12 @@ struct ContractorFormSheet: View {
|
||||
.frame(width: 24)
|
||||
TextField(L10n.Contractors.emailLabel, text: $email)
|
||||
.keyboardType(.emailAddress)
|
||||
.textContentType(.emailAddress)
|
||||
.textInputAutocapitalization(.never)
|
||||
.autocorrectionDisabled()
|
||||
.focused($focusedField, equals: .email)
|
||||
.submitLabel(.next)
|
||||
.onSubmit { focusedField = .website }
|
||||
.accessibilityIdentifier(AccessibilityIdentifiers.Contractor.emailField)
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user