UI test infrastructure overhaul — 58% to 96% pass rate (231/241)

Major infrastructure changes:
- BaseUITestCase: per-suite app termination via class setUp() prevents
  stale state when parallel clones share simulators
- relaunchBetweenTests override for suites that modify login/onboarding state
- focusAndType: dedicated SecureTextField path handles iOS strong password
  autofill suggestions (Choose My Own Password / Not Now dialogs)
- LoginScreenObject: tapSignUp/tapForgotPassword use scrollIntoView for
  offscreen buttons instead of simple swipeUp
- Removed all coordinate taps from ForgotPasswordScreen, VerifyResetCodeScreen,
  ResetPasswordScreen (Rule 3 compliance)
- Removed all usleep calls from screen objects (Rule 14 compliance)

App fixes exposed by tests:
- ContractorsListView: added onDismiss to sheet for list refresh after save
- AllTasksView: added Task.RefreshButton accessibility identifier
- AccessibilityIdentifiers: added Task.refreshButton
- DocumentsWarrantiesView: onDismiss handler for document list refresh
- Various form views: textContentType, submitLabel, onSubmit for keyboard flow

Test fixes:
- PasswordResetTests: handle auto-login after reset (app skips success screen)
- AuthenticatedUITestCase: refreshTasks() helper for kanban toolbar button
- All pre-login suites use relaunchBetweenTests for test independence
- Deleted dead code: AuthenticatedTestCase, SeededTestData, SeedTests,
  CleanupTests, old Suite0/2/3, Suite1_RegistrationRebuildTests

10 remaining failures: 5 iOS strong password autofill (simulator env),
3 pull-to-refresh gesture on empty lists, 2 feature coverage edge cases.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Trey T
2026-03-23 15:05:37 -05:00
parent 0ca4a44bac
commit 4df8707b92
67 changed files with 3085 additions and 4853 deletions

View File

@@ -10,7 +10,10 @@ import XCTest
/// - test06_viewResidenceDetails
final class Suite3_ResidenceRebuildTests: BaseUITestCase {
override var includeResetStateLaunchArgument: Bool { false }
override var relaunchBetweenTests: Bool { true }
override func setUpWithError() throws {
// Force a clean app launch so no stale field text persists between tests
app.terminate()
try super.setUpWithError()
UITestHelpers.ensureLoggedOut(app: app)
}
@@ -23,8 +26,27 @@ final class Suite3_ResidenceRebuildTests: BaseUITestCase {
login.enterPassword("TestPass123!")
app.buttons[AccessibilityIdentifiers.Authentication.loginButton].waitForExistenceOrFail(timeout: defaultTimeout).forceTap()
// Wait for either main tabs or verification screen
let main = MainTabScreenObject(app: app)
main.waitForLoad(timeout: longTimeout)
let mainTabs = app.otherElements[UITestID.Root.mainTabs]
let tabBar = app.tabBars.firstMatch
let verificationScreen = VerificationScreen(app: app)
let deadline = Date().addingTimeInterval(loginTimeout)
while Date() < deadline {
if mainTabs.exists || tabBar.exists {
break
}
if verificationScreen.codeField.exists {
verificationScreen.enterCode(TestAccountAPIClient.debugVerificationCode)
verificationScreen.submitCode()
_ = mainTabs.waitForExistence(timeout: loginTimeout) || tabBar.waitForExistence(timeout: 5)
break
}
RunLoop.current.run(until: Date().addingTimeInterval(0.5))
}
XCTAssertTrue(mainTabs.exists || tabBar.exists, "Expected main app root to appear after login (with verification handling)")
main.goToResidences()
}
@@ -89,14 +111,14 @@ final class Suite3_ResidenceRebuildTests: BaseUITestCase {
let name = "UITest Home \(Int(Date().timeIntervalSince1970))"
_ = createResidence(name: name)
let created = app.staticTexts.containing(NSPredicate(format: "label CONTAINS[c] %@", name)).firstMatch
XCTAssertTrue(created.waitForExistence(timeout: longTimeout), "Created residence should appear in list")
XCTAssertTrue(created.waitForExistence(timeout: loginTimeout), "Created residence should appear in list")
}
func testR307_newResidenceAppearsInResidenceList() throws {
let name = "UITest Verify \(Int(Date().timeIntervalSince1970))"
_ = createResidence(name: name)
let created = app.staticTexts.containing(NSPredicate(format: "label CONTAINS[c] %@", name)).firstMatch
XCTAssertTrue(created.waitForExistence(timeout: longTimeout), "New residence should be visible in residences list")
XCTAssertTrue(created.waitForExistence(timeout: loginTimeout), "New residence should be visible in residences list")
}
func testR308_openResidenceDetailsFromResidenceList() throws {
@@ -104,7 +126,7 @@ final class Suite3_ResidenceRebuildTests: BaseUITestCase {
_ = createResidence(name: name)
let row = app.staticTexts.containing(NSPredicate(format: "label CONTAINS[c] %@", name)).firstMatch
row.waitForExistenceOrFail(timeout: longTimeout).forceTap()
row.waitForExistenceOrFail(timeout: loginTimeout).forceTap()
let edit = app.buttons[AccessibilityIdentifiers.Residence.editButton]
let delete = app.buttons[AccessibilityIdentifiers.Residence.deleteButton]