UI test infrastructure overhaul — 58% to 96% pass rate (231/241)

Major infrastructure changes:
- BaseUITestCase: per-suite app termination via class setUp() prevents
  stale state when parallel clones share simulators
- relaunchBetweenTests override for suites that modify login/onboarding state
- focusAndType: dedicated SecureTextField path handles iOS strong password
  autofill suggestions (Choose My Own Password / Not Now dialogs)
- LoginScreenObject: tapSignUp/tapForgotPassword use scrollIntoView for
  offscreen buttons instead of simple swipeUp
- Removed all coordinate taps from ForgotPasswordScreen, VerifyResetCodeScreen,
  ResetPasswordScreen (Rule 3 compliance)
- Removed all usleep calls from screen objects (Rule 14 compliance)

App fixes exposed by tests:
- ContractorsListView: added onDismiss to sheet for list refresh after save
- AllTasksView: added Task.RefreshButton accessibility identifier
- AccessibilityIdentifiers: added Task.refreshButton
- DocumentsWarrantiesView: onDismiss handler for document list refresh
- Various form views: textContentType, submitLabel, onSubmit for keyboard flow

Test fixes:
- PasswordResetTests: handle auto-login after reset (app skips success screen)
- AuthenticatedUITestCase: refreshTasks() helper for kanban toolbar button
- All pre-login suites use relaunchBetweenTests for test independence
- Deleted dead code: AuthenticatedTestCase, SeededTestData, SeedTests,
  CleanupTests, old Suite0/2/3, Suite1_RegistrationRebuildTests

10 remaining failures: 5 iOS strong password autofill (simulator env),
3 pull-to-refresh gesture on empty lists, 2 feature coverage edge cases.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Trey T
2026-03-23 15:05:37 -05:00
parent 0ca4a44bac
commit 4df8707b92
67 changed files with 3085 additions and 4853 deletions

View File

@@ -5,6 +5,7 @@ import XCTest
/// - test06_logout
final class Suite2_AuthenticationRebuildTests: BaseUITestCase {
override var includeResetStateLaunchArgument: Bool { false }
override var relaunchBetweenTests: Bool { true }
private let validUser = RebuildTestUserFactory.seeded
private enum AuthLandingState {
@@ -13,6 +14,8 @@ final class Suite2_AuthenticationRebuildTests: BaseUITestCase {
}
override func setUpWithError() throws {
// Force a clean app launch so no stale field text persists between tests
app.terminate()
try super.setUpWithError()
UITestHelpers.ensureLoggedOut(app: app)
}
@@ -34,7 +37,7 @@ final class Suite2_AuthenticationRebuildTests: BaseUITestCase {
loginFromLoginScreen(user: user)
let mainRoot = app.otherElements[UITestID.Root.mainTabs]
if mainRoot.waitForExistence(timeout: longTimeout) || app.tabBars.firstMatch.waitForExistence(timeout: 2) {
if mainRoot.waitForExistence(timeout: loginTimeout) || app.tabBars.firstMatch.waitForExistence(timeout: 2) {
return .main
}
@@ -85,9 +88,9 @@ final class Suite2_AuthenticationRebuildTests: BaseUITestCase {
let landing = loginAndWaitForAuthenticatedLanding(user: validUser)
switch landing {
case .main:
RebuildSessionAssertions.assertOnMainApp(app, timeout: longTimeout)
RebuildSessionAssertions.assertOnMainApp(app, timeout: loginTimeout)
case .verification:
RebuildSessionAssertions.assertOnVerification(app, timeout: longTimeout)
RebuildSessionAssertions.assertOnVerification(app, timeout: loginTimeout)
}
}
@@ -96,7 +99,7 @@ final class Suite2_AuthenticationRebuildTests: BaseUITestCase {
switch landing {
case .main:
RebuildSessionAssertions.assertOnMainApp(app, timeout: longTimeout)
RebuildSessionAssertions.assertOnMainApp(app, timeout: loginTimeout)
let tabBar = app.tabBars.firstMatch
if tabBar.waitForExistence(timeout: 5) {
@@ -127,7 +130,7 @@ final class Suite2_AuthenticationRebuildTests: BaseUITestCase {
case .verification:
logoutFromVerificationIfNeeded()
}
RebuildSessionAssertions.assertOnLogin(app, timeout: longTimeout)
RebuildSessionAssertions.assertOnLogin(app, timeout: loginTimeout)
}
func testR206_postLogoutMainAppIsNoLongerAccessible() {
@@ -139,7 +142,7 @@ final class Suite2_AuthenticationRebuildTests: BaseUITestCase {
case .verification:
logoutFromVerificationIfNeeded()
}
RebuildSessionAssertions.assertOnLogin(app, timeout: longTimeout)
RebuildSessionAssertions.assertOnLogin(app, timeout: loginTimeout)
XCTAssertFalse(app.otherElements[UITestID.Root.mainTabs].exists, "Main app root should not be visible after logout")
}