UI test infrastructure overhaul — 58% to 96% pass rate (231/241)

Major infrastructure changes:
- BaseUITestCase: per-suite app termination via class setUp() prevents
  stale state when parallel clones share simulators
- relaunchBetweenTests override for suites that modify login/onboarding state
- focusAndType: dedicated SecureTextField path handles iOS strong password
  autofill suggestions (Choose My Own Password / Not Now dialogs)
- LoginScreenObject: tapSignUp/tapForgotPassword use scrollIntoView for
  offscreen buttons instead of simple swipeUp
- Removed all coordinate taps from ForgotPasswordScreen, VerifyResetCodeScreen,
  ResetPasswordScreen (Rule 3 compliance)
- Removed all usleep calls from screen objects (Rule 14 compliance)

App fixes exposed by tests:
- ContractorsListView: added onDismiss to sheet for list refresh after save
- AllTasksView: added Task.RefreshButton accessibility identifier
- AccessibilityIdentifiers: added Task.refreshButton
- DocumentsWarrantiesView: onDismiss handler for document list refresh
- Various form views: textContentType, submitLabel, onSubmit for keyboard flow

Test fixes:
- PasswordResetTests: handle auto-login after reset (app skips success screen)
- AuthenticatedUITestCase: refreshTasks() helper for kanban toolbar button
- All pre-login suites use relaunchBetweenTests for test independence
- Deleted dead code: AuthenticatedTestCase, SeededTestData, SeedTests,
  CleanupTests, old Suite0/2/3, Suite1_RegistrationRebuildTests

10 remaining failures: 5 iOS strong password autofill (simulator env),
3 pull-to-refresh gesture on empty lists, 2 feature coverage edge cases.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Trey T
2026-03-23 15:05:37 -05:00
parent 0ca4a44bac
commit 4df8707b92
67 changed files with 3085 additions and 4853 deletions

View File

@@ -3,6 +3,8 @@ import XCTest
/// Rebuild plan for legacy: Suite0_OnboardingTests.test_onboarding
/// Split into smaller tests to isolate focus/input/navigation failures.
final class Suite0_OnboardingRebuildTests: BaseUITestCase {
override var relaunchBetweenTests: Bool { true }
func testR001_onboardingWelcomeLoadsAndCanNavigateToLoginEntry() {
let welcome = OnboardingWelcomeScreen(app: app)
welcome.waitForLoad(timeout: defaultTimeout)
@@ -17,15 +19,4 @@ final class Suite0_OnboardingRebuildTests: BaseUITestCase {
createAccount.waitForLoad(timeout: defaultTimeout)
}
func testR003_createAccountExpandedFormFieldsAreInteractable() throws {
throw XCTSkip("Skeleton: implement deterministic focus assertions for username/email/password fields")
}
func testR004_emailFieldCanFocusAndAcceptTyping() throws {
throw XCTSkip("Skeleton: implement replacement for legacy email focus failure")
}
func testR005_createAccountContinueOnlyAfterValidInputs() throws {
throw XCTSkip("Skeleton: validate disabled/enabled state transition for Create Account")
}
}