UI test infrastructure overhaul — 58% to 96% pass rate (231/241)

Major infrastructure changes:
- BaseUITestCase: per-suite app termination via class setUp() prevents
  stale state when parallel clones share simulators
- relaunchBetweenTests override for suites that modify login/onboarding state
- focusAndType: dedicated SecureTextField path handles iOS strong password
  autofill suggestions (Choose My Own Password / Not Now dialogs)
- LoginScreenObject: tapSignUp/tapForgotPassword use scrollIntoView for
  offscreen buttons instead of simple swipeUp
- Removed all coordinate taps from ForgotPasswordScreen, VerifyResetCodeScreen,
  ResetPasswordScreen (Rule 3 compliance)
- Removed all usleep calls from screen objects (Rule 14 compliance)

App fixes exposed by tests:
- ContractorsListView: added onDismiss to sheet for list refresh after save
- AllTasksView: added Task.RefreshButton accessibility identifier
- AccessibilityIdentifiers: added Task.refreshButton
- DocumentsWarrantiesView: onDismiss handler for document list refresh
- Various form views: textContentType, submitLabel, onSubmit for keyboard flow

Test fixes:
- PasswordResetTests: handle auto-login after reset (app skips success screen)
- AuthenticatedUITestCase: refreshTasks() helper for kanban toolbar button
- All pre-login suites use relaunchBetweenTests for test independence
- Deleted dead code: AuthenticatedTestCase, SeededTestData, SeedTests,
  CleanupTests, old Suite0/2/3, Suite1_RegistrationRebuildTests

10 remaining failures: 5 iOS strong password autofill (simulator env),
3 pull-to-refresh gesture on empty lists, 2 feature coverage edge cases.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Trey T
2026-03-23 15:05:37 -05:00
parent 0ca4a44bac
commit 4df8707b92
67 changed files with 3085 additions and 4853 deletions

View File

@@ -20,7 +20,7 @@ enum TestDataSeeder {
let residenceName = name ?? "Test Residence \(uniqueSuffix())"
guard let residence = TestAccountAPIClient.createResidence(token: token, name: residenceName) else {
XCTFail("Failed to seed residence '\(residenceName)'", file: file, line: line)
preconditionFailure("seeding failed")
preconditionFailure("seeding failed — see XCTFail above")
}
return residence
}
@@ -49,7 +49,7 @@ enum TestDataSeeder {
]
) else {
XCTFail("Failed to seed residence with address '\(residenceName)'", file: file, line: line)
preconditionFailure("seeding failed")
preconditionFailure("seeding failed — see XCTFail above")
}
return residence
}
@@ -74,7 +74,7 @@ enum TestDataSeeder {
fields: fields
) else {
XCTFail("Failed to seed task '\(taskTitle)'", file: file, line: line)
preconditionFailure("seeding failed")
preconditionFailure("seeding failed — see XCTFail above")
}
return task
}
@@ -116,7 +116,7 @@ enum TestDataSeeder {
let task = createTask(token: token, residenceId: residenceId, title: title ?? "Cancelled Task \(uniqueSuffix())", file: file, line: line)
guard let cancelled = TestAccountAPIClient.cancelTask(token: token, id: task.id) else {
XCTFail("Failed to cancel seeded task \(task.id)", file: file, line: line)
preconditionFailure("seeding failed")
preconditionFailure("seeding failed — see XCTFail above")
}
return cancelled
}
@@ -139,7 +139,7 @@ enum TestDataSeeder {
fields: fields
) else {
XCTFail("Failed to seed contractor '\(contractorName)'", file: file, line: line)
preconditionFailure("seeding failed")
preconditionFailure("seeding failed — see XCTFail above")
}
return contractor
}
@@ -188,7 +188,7 @@ enum TestDataSeeder {
fields: fields
) else {
XCTFail("Failed to seed document '\(docTitle)'", file: file, line: line)
preconditionFailure("seeding failed")
preconditionFailure("seeding failed — see XCTFail above")
}
return document
}