P0: IDataManager coverage gaps — contractorDetail/documentDetail/taskCompletions/contractorsByResidence

Browse Source

Adds 4 new StateFlow members to IDataManager + DataManager + InMemoryDataManager + FixtureDataManager:
- contractorDetail: Map<Int, Contractor> — cached detail fetches
- documentDetail: Map<Int, Document>
- taskCompletions: Map<Int, List<TaskCompletionResponse>>
- contractorsByResidence: Map<Int, List<ContractorSummary>>

APILayer now writes to these on successful detail/per-residence fetches:
- getTaskCompletions -> setTaskCompletions
- getDocument -> setDocumentDetail
- getContractor -> setContractorDetail
- getContractorsByResidence -> setContractorsForResidence

Fixture populated() seeds contractorDetail + contractorsByResidence.
Populated taskCompletions is empty (Fixtures doesn't define any completions yet).

Foundation for P1 — VMs can now derive every read-state from DataManager
reactively instead of owning independent MutableStateFlow fields.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

...

This commit is contained in:

Trey T

2026-04-19 18:31:06 -05:00

parent f83e89bee3

commit 2230cde071

55 changed files with 69 additions and 1 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

BIN

composeApp/src/androidUnitTest/roborazzi/animation_testing_empty_dark.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 24 KiB After Width:  |  Height:  |  Size: 31 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/animation_testing_empty_light.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 24 KiB After Width:  |  Height:  |  Size: 30 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/animation_testing_populated_dark.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 24 KiB After Width:  |  Height:  |  Size: 31 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/animation_testing_populated_light.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 24 KiB After Width:  |  Height:  |  Size: 30 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/biometric_lock_empty_dark.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 24 KiB After Width:  |  Height:  |  Size: 40 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/biometric_lock_empty_light.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 40 KiB After Width:  |  Height:  |  Size: 62 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/biometric_lock_populated_dark.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 24 KiB After Width:  |  Height:  |  Size: 40 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/biometric_lock_populated_light.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 40 KiB After Width:  |  Height:  |  Size: 62 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/contractor_detail_empty_dark.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 8.2 KiB After Width:  |  Height:  |  Size: 26 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/contractor_detail_empty_light.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 30 KiB After Width:  |  Height:  |  Size: 50 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/contractor_detail_populated_dark.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 8.2 KiB After Width:  |  Height:  |  Size: 26 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/contractor_detail_populated_light.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 30 KiB After Width:  |  Height:  |  Size: 50 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/contractors_empty_dark.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 28 KiB After Width:  |  Height:  |  Size: 28 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/contractors_populated_dark.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 15 KiB After Width:  |  Height:  |  Size: 28 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/contractors_populated_light.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 51 KiB After Width:  |  Height:  |  Size: 52 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/document_detail_empty_dark.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 8.1 KiB After Width:  |  Height:  |  Size: 26 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/document_detail_empty_light.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 30 KiB After Width:  |  Height:  |  Size: 50 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/document_detail_populated_dark.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 8.1 KiB After Width:  |  Height:  |  Size: 26 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/document_detail_populated_light.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 30 KiB After Width:  |  Height:  |  Size: 50 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/documents_empty_dark.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 19 KiB After Width:  |  Height:  |  Size: 37 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/documents_empty_light.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 36 KiB After Width:  |  Height:  |  Size: 36 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/documents_populated_dark.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 19 KiB After Width:  |  Height:  |  Size: 39 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/documents_populated_light.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 36 KiB After Width:  |  Height:  |  Size: 54 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/feature_comparison_empty_dark.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 22 KiB After Width:  |  Height:  |  Size: 27 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/feature_comparison_empty_light.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 23 KiB After Width:  |  Height:  |  Size: 27 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/feature_comparison_populated_dark.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 22 KiB After Width:  |  Height:  |  Size: 27 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/feature_comparison_populated_light.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 23 KiB After Width:  |  Height:  |  Size: 27 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/notification_preferences_empty_dark.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 46 KiB After Width:  |  Height:  |  Size: 66 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/notification_preferences_empty_light.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 69 KiB After Width:  |  Height:  |  Size: 97 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/notification_preferences_populated_dark.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 46 KiB After Width:  |  Height:  |  Size: 66 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/notification_preferences_populated_light.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 69 KiB After Width:  |  Height:  |  Size: 97 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/profile_empty_dark.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 37 KiB After Width:  |  Height:  |  Size: 55 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/profile_empty_light.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 58 KiB After Width:  |  Height:  |  Size: 81 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/profile_populated_dark.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 38 KiB After Width:  |  Height:  |  Size: 56 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/profile_populated_light.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 58 KiB After Width:  |  Height:  |  Size: 82 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/residence_detail_empty_dark.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 28 KiB After Width:  |  Height:  |  Size: 56 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/residence_detail_empty_light.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 52 KiB After Width:  |  Height:  |  Size: 83 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/residence_detail_populated_dark.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 28 KiB After Width:  |  Height:  |  Size: 52 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/residence_detail_populated_light.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 52 KiB After Width:  |  Height:  |  Size: 77 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/residences_populated_dark.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 6.7 KiB After Width:  |  Height:  |  Size: 37 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/residences_populated_light.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 7.0 KiB After Width:  |  Height:  |  Size: 37 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/task_templates_browser_empty_dark.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 7.2 KiB After Width:  |  Height:  |  Size: 7.0 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/task_templates_browser_populated_dark.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 7.3 KiB After Width:  |  Height:  |  Size: 7.0 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/tasks_empty_dark.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 27 KiB After Width:  |  Height:  |  Size: 52 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/tasks_empty_light.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 52 KiB After Width:  |  Height:  |  Size: 66 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/tasks_populated_light.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 52 KiB After Width:  |  Height:  |  Size: 66 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/theme_selection_empty_dark.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 34 KiB After Width:  |  Height:  |  Size: 41 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/theme_selection_empty_light.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 36 KiB After Width:  |  Height:  |  Size: 43 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/theme_selection_populated_dark.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 34 KiB After Width:  |  Height:  |  Size: 41 KiB

BIN

composeApp/src/androidUnitTest/roborazzi/theme_selection_populated_light.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 36 KiB After Width:  |  Height:  |  Size: 43 KiB