Major changes: - Migrate all handlers from Gin to Echo framework - Add new apperrors, echohelpers, and validator packages - Update middleware for Echo compatibility - Add ArchivedHandler to task categorization chain (archived tasks go to cancelled_tasks column) - Add 6 new integration tests: - RecurringTaskLifecycle: NextDueDate advancement for weekly/monthly tasks - MultiUserSharing: Complex sharing with user removal - TaskStateTransitions: All state transitions and kanban column changes - DateBoundaryEdgeCases: Threshold boundary testing - CascadeOperations: Residence deletion cascade effects - MultiUserOperations: Shared residence collaboration - Add single-purpose repository functions for kanban columns (GetOverdueTasks, GetDueSoonTasks, etc.) - Fix RemoveUser route param mismatch (userId -> user_id) - Fix determineExpectedColumn helper to correctly prioritize in_progress over overdue 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
336 lines
12 KiB
Go
336 lines
12 KiB
Go
package services
|
|
|
|
import (
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/shopspring/decimal"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/treytartt/casera-api/internal/config"
|
|
"github.com/treytartt/casera-api/internal/dto/requests"
|
|
"github.com/treytartt/casera-api/internal/repositories"
|
|
"github.com/treytartt/casera-api/internal/testutil"
|
|
)
|
|
|
|
func setupResidenceService(t *testing.T) (*ResidenceService, *repositories.ResidenceRepository, *repositories.UserRepository) {
|
|
db := testutil.SetupTestDB(t)
|
|
residenceRepo := repositories.NewResidenceRepository(db)
|
|
userRepo := repositories.NewUserRepository(db)
|
|
cfg := &config.Config{}
|
|
service := NewResidenceService(residenceRepo, userRepo, cfg)
|
|
return service, residenceRepo, userRepo
|
|
}
|
|
|
|
func TestResidenceService_CreateResidence(t *testing.T) {
|
|
db := testutil.SetupTestDB(t)
|
|
residenceRepo := repositories.NewResidenceRepository(db)
|
|
userRepo := repositories.NewUserRepository(db)
|
|
cfg := &config.Config{}
|
|
service := NewResidenceService(residenceRepo, userRepo, cfg)
|
|
|
|
user := testutil.CreateTestUser(t, db, "owner", "owner@test.com", "password")
|
|
|
|
req := &requests.CreateResidenceRequest{
|
|
Name: "Test House",
|
|
StreetAddress: "123 Main St",
|
|
City: "Austin",
|
|
StateProvince: "TX",
|
|
PostalCode: "78701",
|
|
}
|
|
|
|
resp, err := service.CreateResidence(req, user.ID)
|
|
require.NoError(t, err)
|
|
assert.NotNil(t, resp)
|
|
assert.Equal(t, "Test House", resp.Data.Name)
|
|
assert.Equal(t, "123 Main St", resp.Data.StreetAddress)
|
|
assert.Equal(t, "Austin", resp.Data.City)
|
|
assert.Equal(t, "TX", resp.Data.StateProvince)
|
|
assert.Equal(t, "USA", resp.Data.Country) // Default country
|
|
assert.True(t, resp.Data.IsPrimary) // Default is_primary
|
|
}
|
|
|
|
func TestResidenceService_CreateResidence_WithOptionalFields(t *testing.T) {
|
|
db := testutil.SetupTestDB(t)
|
|
residenceRepo := repositories.NewResidenceRepository(db)
|
|
userRepo := repositories.NewUserRepository(db)
|
|
cfg := &config.Config{}
|
|
service := NewResidenceService(residenceRepo, userRepo, cfg)
|
|
|
|
user := testutil.CreateTestUser(t, db, "owner", "owner@test.com", "password")
|
|
|
|
bedrooms := 3
|
|
bathrooms := decimal.NewFromFloat(2.5)
|
|
sqft := 2000
|
|
isPrimary := false
|
|
|
|
req := &requests.CreateResidenceRequest{
|
|
Name: "Test House",
|
|
StreetAddress: "123 Main St",
|
|
City: "Austin",
|
|
StateProvince: "TX",
|
|
PostalCode: "78701",
|
|
Country: "Canada",
|
|
Bedrooms: &bedrooms,
|
|
Bathrooms: &bathrooms,
|
|
SquareFootage: &sqft,
|
|
IsPrimary: &isPrimary,
|
|
}
|
|
|
|
resp, err := service.CreateResidence(req, user.ID)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "Canada", resp.Data.Country)
|
|
assert.Equal(t, 3, *resp.Data.Bedrooms)
|
|
assert.True(t, resp.Data.Bathrooms.Equal(decimal.NewFromFloat(2.5)))
|
|
assert.Equal(t, 2000, *resp.Data.SquareFootage)
|
|
// First residence defaults to primary regardless of request
|
|
assert.True(t, resp.Data.IsPrimary)
|
|
}
|
|
|
|
func TestResidenceService_GetResidence(t *testing.T) {
|
|
db := testutil.SetupTestDB(t)
|
|
residenceRepo := repositories.NewResidenceRepository(db)
|
|
userRepo := repositories.NewUserRepository(db)
|
|
cfg := &config.Config{}
|
|
service := NewResidenceService(residenceRepo, userRepo, cfg)
|
|
|
|
user := testutil.CreateTestUser(t, db, "owner", "owner@test.com", "password")
|
|
residence := testutil.CreateTestResidence(t, db, user.ID, "Test House")
|
|
|
|
resp, err := service.GetResidence(residence.ID, user.ID)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, residence.ID, resp.ID)
|
|
assert.Equal(t, "Test House", resp.Name)
|
|
}
|
|
|
|
func TestResidenceService_GetResidence_AccessDenied(t *testing.T) {
|
|
db := testutil.SetupTestDB(t)
|
|
residenceRepo := repositories.NewResidenceRepository(db)
|
|
userRepo := repositories.NewUserRepository(db)
|
|
cfg := &config.Config{}
|
|
service := NewResidenceService(residenceRepo, userRepo, cfg)
|
|
|
|
owner := testutil.CreateTestUser(t, db, "owner", "owner@test.com", "password")
|
|
otherUser := testutil.CreateTestUser(t, db, "other", "other@test.com", "password")
|
|
residence := testutil.CreateTestResidence(t, db, owner.ID, "Test House")
|
|
|
|
_, err := service.GetResidence(residence.ID, otherUser.ID)
|
|
testutil.AssertAppError(t, err, http.StatusForbidden, "error.residence_access_denied")
|
|
}
|
|
|
|
func TestResidenceService_GetResidence_NotFound(t *testing.T) {
|
|
db := testutil.SetupTestDB(t)
|
|
residenceRepo := repositories.NewResidenceRepository(db)
|
|
userRepo := repositories.NewUserRepository(db)
|
|
cfg := &config.Config{}
|
|
service := NewResidenceService(residenceRepo, userRepo, cfg)
|
|
|
|
user := testutil.CreateTestUser(t, db, "user", "user@test.com", "password")
|
|
|
|
_, err := service.GetResidence(9999, user.ID)
|
|
assert.Error(t, err)
|
|
}
|
|
|
|
func TestResidenceService_ListResidences(t *testing.T) {
|
|
db := testutil.SetupTestDB(t)
|
|
residenceRepo := repositories.NewResidenceRepository(db)
|
|
userRepo := repositories.NewUserRepository(db)
|
|
cfg := &config.Config{}
|
|
service := NewResidenceService(residenceRepo, userRepo, cfg)
|
|
|
|
user := testutil.CreateTestUser(t, db, "owner", "owner@test.com", "password")
|
|
testutil.CreateTestResidence(t, db, user.ID, "House 1")
|
|
testutil.CreateTestResidence(t, db, user.ID, "House 2")
|
|
|
|
resp, err := service.ListResidences(user.ID)
|
|
require.NoError(t, err)
|
|
assert.Len(t, resp, 2)
|
|
}
|
|
|
|
func TestResidenceService_UpdateResidence(t *testing.T) {
|
|
db := testutil.SetupTestDB(t)
|
|
residenceRepo := repositories.NewResidenceRepository(db)
|
|
userRepo := repositories.NewUserRepository(db)
|
|
cfg := &config.Config{}
|
|
service := NewResidenceService(residenceRepo, userRepo, cfg)
|
|
|
|
user := testutil.CreateTestUser(t, db, "owner", "owner@test.com", "password")
|
|
residence := testutil.CreateTestResidence(t, db, user.ID, "Original Name")
|
|
|
|
newName := "Updated Name"
|
|
newCity := "Dallas"
|
|
req := &requests.UpdateResidenceRequest{
|
|
Name: &newName,
|
|
City: &newCity,
|
|
}
|
|
|
|
resp, err := service.UpdateResidence(residence.ID, user.ID, req)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "Updated Name", resp.Data.Name)
|
|
assert.Equal(t, "Dallas", resp.Data.City)
|
|
}
|
|
|
|
func TestResidenceService_UpdateResidence_NotOwner(t *testing.T) {
|
|
db := testutil.SetupTestDB(t)
|
|
residenceRepo := repositories.NewResidenceRepository(db)
|
|
userRepo := repositories.NewUserRepository(db)
|
|
cfg := &config.Config{}
|
|
service := NewResidenceService(residenceRepo, userRepo, cfg)
|
|
|
|
owner := testutil.CreateTestUser(t, db, "owner", "owner@test.com", "password")
|
|
sharedUser := testutil.CreateTestUser(t, db, "shared", "shared@test.com", "password")
|
|
residence := testutil.CreateTestResidence(t, db, owner.ID, "Test House")
|
|
|
|
// Share with user
|
|
residenceRepo.AddUser(residence.ID, sharedUser.ID)
|
|
|
|
newName := "Updated"
|
|
req := &requests.UpdateResidenceRequest{Name: &newName}
|
|
|
|
_, err := service.UpdateResidence(residence.ID, sharedUser.ID, req)
|
|
testutil.AssertAppError(t, err, http.StatusForbidden, "error.not_residence_owner")
|
|
}
|
|
|
|
func TestResidenceService_DeleteResidence(t *testing.T) {
|
|
db := testutil.SetupTestDB(t)
|
|
residenceRepo := repositories.NewResidenceRepository(db)
|
|
userRepo := repositories.NewUserRepository(db)
|
|
cfg := &config.Config{}
|
|
service := NewResidenceService(residenceRepo, userRepo, cfg)
|
|
|
|
user := testutil.CreateTestUser(t, db, "owner", "owner@test.com", "password")
|
|
residence := testutil.CreateTestResidence(t, db, user.ID, "Test House")
|
|
|
|
_, err := service.DeleteResidence(residence.ID, user.ID)
|
|
require.NoError(t, err)
|
|
|
|
// Should not be found
|
|
_, err = service.GetResidence(residence.ID, user.ID)
|
|
assert.Error(t, err)
|
|
}
|
|
|
|
func TestResidenceService_DeleteResidence_NotOwner(t *testing.T) {
|
|
db := testutil.SetupTestDB(t)
|
|
residenceRepo := repositories.NewResidenceRepository(db)
|
|
userRepo := repositories.NewUserRepository(db)
|
|
cfg := &config.Config{}
|
|
service := NewResidenceService(residenceRepo, userRepo, cfg)
|
|
|
|
owner := testutil.CreateTestUser(t, db, "owner", "owner@test.com", "password")
|
|
sharedUser := testutil.CreateTestUser(t, db, "shared", "shared@test.com", "password")
|
|
residence := testutil.CreateTestResidence(t, db, owner.ID, "Test House")
|
|
residenceRepo.AddUser(residence.ID, sharedUser.ID)
|
|
|
|
_, err := service.DeleteResidence(residence.ID, sharedUser.ID)
|
|
testutil.AssertAppError(t, err, http.StatusForbidden, "error.not_residence_owner")
|
|
}
|
|
|
|
func TestResidenceService_GenerateShareCode(t *testing.T) {
|
|
db := testutil.SetupTestDB(t)
|
|
residenceRepo := repositories.NewResidenceRepository(db)
|
|
userRepo := repositories.NewUserRepository(db)
|
|
cfg := &config.Config{}
|
|
service := NewResidenceService(residenceRepo, userRepo, cfg)
|
|
|
|
user := testutil.CreateTestUser(t, db, "owner", "owner@test.com", "password")
|
|
residence := testutil.CreateTestResidence(t, db, user.ID, "Test House")
|
|
|
|
resp, err := service.GenerateShareCode(residence.ID, user.ID, 24)
|
|
require.NoError(t, err)
|
|
assert.NotEmpty(t, resp.ShareCode.Code)
|
|
assert.Len(t, resp.ShareCode.Code, 6)
|
|
}
|
|
|
|
func TestResidenceService_JoinWithCode(t *testing.T) {
|
|
db := testutil.SetupTestDB(t)
|
|
residenceRepo := repositories.NewResidenceRepository(db)
|
|
userRepo := repositories.NewUserRepository(db)
|
|
cfg := &config.Config{}
|
|
service := NewResidenceService(residenceRepo, userRepo, cfg)
|
|
|
|
owner := testutil.CreateTestUser(t, db, "owner", "owner@test.com", "password")
|
|
newUser := testutil.CreateTestUser(t, db, "newuser", "new@test.com", "password")
|
|
residence := testutil.CreateTestResidence(t, db, owner.ID, "Test House")
|
|
|
|
// Generate share code
|
|
shareResp, err := service.GenerateShareCode(residence.ID, owner.ID, 24)
|
|
require.NoError(t, err)
|
|
|
|
// Join with code
|
|
joinResp, err := service.JoinWithCode(shareResp.ShareCode.Code, newUser.ID)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, residence.ID, joinResp.Residence.ID)
|
|
|
|
// Verify access
|
|
hasAccess, _ := residenceRepo.HasAccess(residence.ID, newUser.ID)
|
|
assert.True(t, hasAccess)
|
|
}
|
|
|
|
func TestResidenceService_JoinWithCode_AlreadyMember(t *testing.T) {
|
|
db := testutil.SetupTestDB(t)
|
|
residenceRepo := repositories.NewResidenceRepository(db)
|
|
userRepo := repositories.NewUserRepository(db)
|
|
cfg := &config.Config{}
|
|
service := NewResidenceService(residenceRepo, userRepo, cfg)
|
|
|
|
owner := testutil.CreateTestUser(t, db, "owner", "owner@test.com", "password")
|
|
residence := testutil.CreateTestResidence(t, db, owner.ID, "Test House")
|
|
|
|
shareResp, _ := service.GenerateShareCode(residence.ID, owner.ID, 24)
|
|
|
|
// Owner tries to join their own residence
|
|
_, err := service.JoinWithCode(shareResp.ShareCode.Code, owner.ID)
|
|
testutil.AssertAppError(t, err, http.StatusConflict, "error.user_already_member")
|
|
}
|
|
|
|
func TestResidenceService_GetResidenceUsers(t *testing.T) {
|
|
db := testutil.SetupTestDB(t)
|
|
residenceRepo := repositories.NewResidenceRepository(db)
|
|
userRepo := repositories.NewUserRepository(db)
|
|
cfg := &config.Config{}
|
|
service := NewResidenceService(residenceRepo, userRepo, cfg)
|
|
|
|
owner := testutil.CreateTestUser(t, db, "owner", "owner@test.com", "password")
|
|
user1 := testutil.CreateTestUser(t, db, "user1", "user1@test.com", "password")
|
|
residence := testutil.CreateTestResidence(t, db, owner.ID, "Test House")
|
|
residenceRepo.AddUser(residence.ID, user1.ID)
|
|
|
|
users, err := service.GetResidenceUsers(residence.ID, owner.ID)
|
|
require.NoError(t, err)
|
|
assert.Len(t, users, 2) // owner + shared user
|
|
}
|
|
|
|
func TestResidenceService_RemoveUser(t *testing.T) {
|
|
db := testutil.SetupTestDB(t)
|
|
residenceRepo := repositories.NewResidenceRepository(db)
|
|
userRepo := repositories.NewUserRepository(db)
|
|
cfg := &config.Config{}
|
|
service := NewResidenceService(residenceRepo, userRepo, cfg)
|
|
|
|
owner := testutil.CreateTestUser(t, db, "owner", "owner@test.com", "password")
|
|
sharedUser := testutil.CreateTestUser(t, db, "shared", "shared@test.com", "password")
|
|
residence := testutil.CreateTestResidence(t, db, owner.ID, "Test House")
|
|
residenceRepo.AddUser(residence.ID, sharedUser.ID)
|
|
|
|
err := service.RemoveUser(residence.ID, sharedUser.ID, owner.ID)
|
|
require.NoError(t, err)
|
|
|
|
hasAccess, _ := residenceRepo.HasAccess(residence.ID, sharedUser.ID)
|
|
assert.False(t, hasAccess)
|
|
}
|
|
|
|
func TestResidenceService_RemoveUser_CannotRemoveOwner(t *testing.T) {
|
|
db := testutil.SetupTestDB(t)
|
|
residenceRepo := repositories.NewResidenceRepository(db)
|
|
userRepo := repositories.NewUserRepository(db)
|
|
cfg := &config.Config{}
|
|
service := NewResidenceService(residenceRepo, userRepo, cfg)
|
|
|
|
owner := testutil.CreateTestUser(t, db, "owner", "owner@test.com", "password")
|
|
residence := testutil.CreateTestResidence(t, db, owner.ID, "Test House")
|
|
|
|
err := service.RemoveUser(residence.ID, owner.ID, owner.ID)
|
|
testutil.AssertAppError(t, err, http.StatusBadRequest, "error.cannot_remove_owner")
|
|
}
|