admin/honeyDueAPI
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove embedded completions from task response

Browse Source 
Since completions are fetched separately via GetCompletionsByTask,
there's no need to embed them in the task JSON response.

- Remove Completions field from TaskResponse (keep CompletionCount)
- Remove Completions.CompletedBy preloads from task queries

This reduces response payload size and improves query performance.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Trey t
2025-11-28 08:50:50 -06:00
parent f02c1e6a64
commit b38a1f547b
2 changed files with 3 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
internal/dto/responses/task.go
View File

@@ -90,10 +90,9 @@ type TaskResponse struct {
ContractorID *uint `json:"contractor_id"` ContractorID *uint `json:"contractor_id"`
IsCancelled bool `json:"is_cancelled"` IsCancelled bool `json:"is_cancelled"`
IsArchived bool `json:"is_archived"` IsArchived bool `json:"is_archived"`
ParentTaskID *uint `json:"parent_task_id"` ParentTaskID *uint `json:"parent_task_id"`
CompletionCount int `json:"completion_count"` CompletionCount int `json:"completion_count"`
Completions []TaskCompletionResponse `json:"completions,omitempty"` CreatedAt time.Time `json:"created_at"`
CreatedAt time.Time `json:"created_at"`
UpdatedAt time.Time `json:"updated_at"` UpdatedAt time.Time `json:"updated_at"`
} }
@@ -252,11 +251,6 @@ func NewTaskResponse(t *models.Task) TaskResponse {
resp.Frequency = NewTaskFrequencyResponse(t.Frequency) resp.Frequency = NewTaskFrequencyResponse(t.Frequency)
} }
resp.Completions = make([]TaskCompletionResponse, len(t.Completions))
for i, c := range t.Completions {
resp.Completions[i] = NewTaskCompletionResponse(&c)
}
return resp return resp
} }

3
internal/repositories/task_repo.go
View File

@@ -31,7 +31,6 @@ func (r *TaskRepository) FindByID(id uint) (*models.Task, error) {
Preload("Status"). Preload("Status").
Preload("Frequency"). Preload("Frequency").
Preload("Completions"). Preload("Completions").
Preload("Completions.CompletedBy").
First(&task, id).Error First(&task, id).Error
if err != nil { if err != nil {
return nil, err return nil, err
@@ -136,7 +135,6 @@ func (r *TaskRepository) GetKanbanData(residenceID uint, daysThreshold int) (*mo
Preload("Status"). Preload("Status").
Preload("Frequency"). Preload("Frequency").
Preload("Completions"). Preload("Completions").
Preload("Completions.CompletedBy").
Where("residence_id = ? AND is_archived = ?", residenceID, false). Where("residence_id = ? AND is_archived = ?", residenceID, false).
Order("due_date ASC NULLS LAST, priority_id DESC, created_at DESC"). Order("due_date ASC NULLS LAST, priority_id DESC, created_at DESC").
Find(&tasks).Error Find(&tasks).Error
@@ -261,7 +259,6 @@ func (r *TaskRepository) GetKanbanDataForMultipleResidences(residenceIDs []uint,
Preload("Status"). Preload("Status").
Preload("Frequency"). Preload("Frequency").
Preload("Completions"). Preload("Completions").
Preload("Completions.CompletedBy").
Preload("Residence"). Preload("Residence").
Where("residence_id IN ? AND is_archived = ?", residenceIDs, false). Where("residence_id IN ? AND is_archived = ?", residenceIDs, false).
Order("due_date ASC NULLS LAST, priority_id DESC, created_at DESC"). Order("due_date ASC NULLS LAST, priority_id DESC, created_at DESC").