Migrate from Gin to Echo framework and add comprehensive integration tests

Major changes: - Migrate all handlers from Gin to Echo framework - Add new apperrors, echohelpers, and validator packages - Update middleware for Echo compatibility - Add ArchivedHandler to task categorization chain (archived tasks go to cancelled_tasks column) - Add 6 new integration tests: - RecurringTaskLifecycle: NextDueDate advancement for weekly/monthly tasks - MultiUserSharing: Complex sharing with user removal - TaskStateTransitions: All state transitions and kanban column changes - DateBoundaryEdgeCases: Threshold boundary testing - CascadeOperations: Residence deletion cascade effects - MultiUserOperations: Shared residence collaboration - Add single-purpose repository functions for kanban columns (GetOverdueTasks, GetDueSoonTasks, etc.) - Fix RemoveUser route param mismatch (userId -> user_id) - Fix determineExpectedColumn helper to correctly prioritize in_progress over overdue 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-16 13:52:08 -06:00
parent c51f1ce34a
commit 6dac34e373
98 changed files with 8209 additions and 4425 deletions
--- a/internal/handlers/document_handler.go
+++ b/internal/handlers/document_handler.go
@@ -1,18 +1,17 @@
 package handlers

 import (
-	"errors"
 	"mime/multipart"
 	"net/http"
 	"strconv"
 	"strings"
 	"time"

-	"github.com/gin-gonic/gin"
+	"github.com/labstack/echo/v4"
 	"github.com/shopspring/decimal"

+	"github.com/treytartt/casera-api/internal/apperrors"
 	"github.com/treytartt/casera-api/internal/dto/requests"
-	"github.com/treytartt/casera-api/internal/i18n"
 	"github.com/treytartt/casera-api/internal/middleware"
 	"github.com/treytartt/casera-api/internal/models"
 	"github.com/treytartt/casera-api/internal/services"
@@ -33,101 +32,86 @@ func NewDocumentHandler(documentService *services.DocumentService, storageServic
 }

 // ListDocuments handles GET /api/documents/
-func (h *DocumentHandler) ListDocuments(c *gin.Context) {
-	user := c.MustGet(middleware.AuthUserKey).(*models.User)
+func (h *DocumentHandler) ListDocuments(c echo.Context) error {
+	user := c.Get(middleware.AuthUserKey).(*models.User)
 	response, err := h.documentService.ListDocuments(user.ID)
 	if err != nil {
-		c.JSON(http.StatusInternalServerError, gin.H{"error": err.Error()})
-		return
+		return c.JSON(http.StatusInternalServerError, map[string]interface{}{"error": err.Error()})
 	}
-	c.JSON(http.StatusOK, response)
+	return c.JSON(http.StatusOK, response)
 }

 // GetDocument handles GET /api/documents/:id/
-func (h *DocumentHandler) GetDocument(c *gin.Context) {
-	user := c.MustGet(middleware.AuthUserKey).(*models.User)
+func (h *DocumentHandler) GetDocument(c echo.Context) error {
+	user := c.Get(middleware.AuthUserKey).(*models.User)
 	documentID, err := strconv.ParseUint(c.Param("id"), 10, 32)
 	if err != nil {
-		c.JSON(http.StatusBadRequest, gin.H{"error": i18n.LocalizedMessage(c, "error.invalid_document_id")})
-		return
+		return apperrors.BadRequest("error.invalid_document_id")
 	}

 	response, err := h.documentService.GetDocument(uint(documentID), user.ID)
 	if err != nil {
-		switch {
-		case errors.Is(err, services.ErrDocumentNotFound):
-			c.JSON(http.StatusNotFound, gin.H{"error": i18n.LocalizedMessage(c, "error.document_not_found")})
-		case errors.Is(err, services.ErrDocumentAccessDenied):
-			c.JSON(http.StatusForbidden, gin.H{"error": i18n.LocalizedMessage(c, "error.document_access_denied")})
-		default:
-			c.JSON(http.StatusInternalServerError, gin.H{"error": err.Error()})
-		}
-		return
+		return err
 	}
-	c.JSON(http.StatusOK, response)
+	return c.JSON(http.StatusOK, response)
 }

 // ListWarranties handles GET /api/documents/warranties/
-func (h *DocumentHandler) ListWarranties(c *gin.Context) {
-	user := c.MustGet(middleware.AuthUserKey).(*models.User)
+func (h *DocumentHandler) ListWarranties(c echo.Context) error {
+	user := c.Get(middleware.AuthUserKey).(*models.User)
 	response, err := h.documentService.ListWarranties(user.ID)
 	if err != nil {
-		c.JSON(http.StatusInternalServerError, gin.H{"error": err.Error()})
-		return
+		return c.JSON(http.StatusInternalServerError, map[string]interface{}{"error": err.Error()})
 	}
-	c.JSON(http.StatusOK, response)
+	return c.JSON(http.StatusOK, response)
 }

 // CreateDocument handles POST /api/documents/
 // Supports both JSON and multipart form data (for file uploads)
-func (h *DocumentHandler) CreateDocument(c *gin.Context) {
-	user := c.MustGet(middleware.AuthUserKey).(*models.User)
+func (h *DocumentHandler) CreateDocument(c echo.Context) error {
+	user := c.Get(middleware.AuthUserKey).(*models.User)
 	var req requests.CreateDocumentRequest

-	contentType := c.GetHeader("Content-Type")
+	contentType := c.Request().Header.Get("Content-Type")

 	// Check if this is a multipart form request (file upload)
 	if strings.HasPrefix(contentType, "multipart/form-data") {
 		// Parse multipart form
-		if err := c.Request.ParseMultipartForm(32 << 20); err != nil { // 32MB max
-			c.JSON(http.StatusBadRequest, gin.H{"error": i18n.LocalizedMessage(c, "error.failed_to_parse_form")})
-			return
+		if err := c.Request().ParseMultipartForm(32 << 20); err != nil { // 32MB max
+			return apperrors.BadRequest("error.failed_to_parse_form")
 		}

 		// Parse residence_id (required)
-		residenceIDStr := c.PostForm("residence_id")
+		residenceIDStr := c.FormValue("residence_id")
 		if residenceIDStr == "" {
-			c.JSON(http.StatusBadRequest, gin.H{"error": i18n.LocalizedMessage(c, "error.residence_id_required")})
-			return
+			return apperrors.BadRequest("error.residence_id_required")
 		}
 		residenceID, err := strconv.ParseUint(residenceIDStr, 10, 32)
 		if err != nil {
-			c.JSON(http.StatusBadRequest, gin.H{"error": i18n.LocalizedMessage(c, "error.invalid_residence_id")})
-			return
+			return apperrors.BadRequest("error.invalid_residence_id")
 		}
 		req.ResidenceID = uint(residenceID)

 		// Parse title (required)
-		req.Title = c.PostForm("title")
+		req.Title = c.FormValue("title")
 		if req.Title == "" {
-			c.JSON(http.StatusBadRequest, gin.H{"error": i18n.LocalizedMessage(c, "error.title_required")})
-			return
+			return apperrors.BadRequest("error.title_required")
 		}

 		// Parse optional fields
-		req.Description = c.PostForm("description")
-		req.Vendor = c.PostForm("vendor")
-		req.SerialNumber = c.PostForm("serial_number")
-		req.ModelNumber = c.PostForm("model_number")
+		req.Description = c.FormValue("description")
+		req.Vendor = c.FormValue("vendor")
+		req.SerialNumber = c.FormValue("serial_number")
+		req.ModelNumber = c.FormValue("model_number")

 		// Parse document_type
-		if docType := c.PostForm("document_type"); docType != "" {
+		if docType := c.FormValue("document_type"); docType != "" {
 			dt := models.DocumentType(docType)
 			req.DocumentType = dt
 		}

 		// Parse task_id (optional)
-		if taskIDStr := c.PostForm("task_id"); taskIDStr != "" {
+		if taskIDStr := c.FormValue("task_id"); taskIDStr != "" {
 			if taskID, err := strconv.ParseUint(taskIDStr, 10, 32); err == nil {
 				tid := uint(taskID)
 				req.TaskID = &tid
@@ -135,14 +119,14 @@ func (h *DocumentHandler) CreateDocument(c *gin.Context) {
 		}

 		// Parse purchase_price (optional)
-		if priceStr := c.PostForm("purchase_price"); priceStr != "" {
+		if priceStr := c.FormValue("purchase_price"); priceStr != "" {
 			if price, err := decimal.NewFromString(priceStr); err == nil {
 				req.PurchasePrice = &price
 			}
 		}

 		// Parse purchase_date (optional)
-		if dateStr := c.PostForm("purchase_date"); dateStr != "" {
+		if dateStr := c.FormValue("purchase_date"); dateStr != "" {
 			if t, err := time.Parse(time.RFC3339, dateStr); err == nil {
 				req.PurchaseDate = &t
 			} else if t, err := time.Parse("2006-01-02", dateStr); err == nil {
@@ -151,7 +135,7 @@ func (h *DocumentHandler) CreateDocument(c *gin.Context) {
 		}

 		// Parse expiry_date (optional)
-		if dateStr := c.PostForm("expiry_date"); dateStr != "" {
+		if dateStr := c.FormValue("expiry_date"); dateStr != "" {
 			if t, err := time.Parse(time.RFC3339, dateStr); err == nil {
 				req.ExpiryDate = &t
 			} else if t, err := time.Parse("2006-01-02", dateStr); err == nil {
@@ -171,8 +155,7 @@ func (h *DocumentHandler) CreateDocument(c *gin.Context) {
 		if uploadedFile != nil && h.storageService != nil {
 			result, err := h.storageService.Upload(uploadedFile, "documents")
 			if err != nil {
-				c.JSON(http.StatusBadRequest, gin.H{"error": i18n.LocalizedMessage(c, "error.failed_to_upload_file")})
-				return
+				return apperrors.BadRequest("error.failed_to_upload_file")
 			}
 			req.FileURL = result.URL
 			req.FileName = result.FileName
@@ -182,122 +165,79 @@ func (h *DocumentHandler) CreateDocument(c *gin.Context) {
 		}
 	} else {
 		// Standard JSON request
-		if err := c.ShouldBindJSON(&req); err != nil {
-			c.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
-			return
+		if err := c.Bind(&req); err != nil {
+			return apperrors.BadRequest("error.invalid_request")
 		}
 	}

 	response, err := h.documentService.CreateDocument(&req, user.ID)
 	if err != nil {
-		if errors.Is(err, services.ErrResidenceAccessDenied) {
-			c.JSON(http.StatusForbidden, gin.H{"error": i18n.LocalizedMessage(c, "error.residence_access_denied")})
-			return
-		}
-		c.JSON(http.StatusInternalServerError, gin.H{"error": err.Error()})
-		return
+		return err
 	}
-	c.JSON(http.StatusCreated, response)
+	return c.JSON(http.StatusCreated, response)
 }

 // UpdateDocument handles PUT/PATCH /api/documents/:id/
-func (h *DocumentHandler) UpdateDocument(c *gin.Context) {
-	user := c.MustGet(middleware.AuthUserKey).(*models.User)
+func (h *DocumentHandler) UpdateDocument(c echo.Context) error {
+	user := c.Get(middleware.AuthUserKey).(*models.User)
 	documentID, err := strconv.ParseUint(c.Param("id"), 10, 32)
 	if err != nil {
-		c.JSON(http.StatusBadRequest, gin.H{"error": i18n.LocalizedMessage(c, "error.invalid_document_id")})
-		return
+		return apperrors.BadRequest("error.invalid_document_id")
 	}

 	var req requests.UpdateDocumentRequest
-	if err := c.ShouldBindJSON(&req); err != nil {
-		c.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
-		return
+	if err := c.Bind(&req); err != nil {
+		return apperrors.BadRequest("error.invalid_request")
 	}

 	response, err := h.documentService.UpdateDocument(uint(documentID), user.ID, &req)
 	if err != nil {
-		switch {
-		case errors.Is(err, services.ErrDocumentNotFound):
-			c.JSON(http.StatusNotFound, gin.H{"error": i18n.LocalizedMessage(c, "error.document_not_found")})
-		case errors.Is(err, services.ErrDocumentAccessDenied):
-			c.JSON(http.StatusForbidden, gin.H{"error": i18n.LocalizedMessage(c, "error.document_access_denied")})
-		default:
-			c.JSON(http.StatusInternalServerError, gin.H{"error": err.Error()})
-		}
-		return
+		return err
 	}
-	c.JSON(http.StatusOK, response)
+	return c.JSON(http.StatusOK, response)
 }

 // DeleteDocument handles DELETE /api/documents/:id/
-func (h *DocumentHandler) DeleteDocument(c *gin.Context) {
-	user := c.MustGet(middleware.AuthUserKey).(*models.User)
+func (h *DocumentHandler) DeleteDocument(c echo.Context) error {
+	user := c.Get(middleware.AuthUserKey).(*models.User)
 	documentID, err := strconv.ParseUint(c.Param("id"), 10, 32)
 	if err != nil {
-		c.JSON(http.StatusBadRequest, gin.H{"error": i18n.LocalizedMessage(c, "error.invalid_document_id")})
-		return
+		return apperrors.BadRequest("error.invalid_document_id")
 	}

 	err = h.documentService.DeleteDocument(uint(documentID), user.ID)
 	if err != nil {
-		switch {
-		case errors.Is(err, services.ErrDocumentNotFound):
-			c.JSON(http.StatusNotFound, gin.H{"error": i18n.LocalizedMessage(c, "error.document_not_found")})
-		case errors.Is(err, services.ErrDocumentAccessDenied):
-			c.JSON(http.StatusForbidden, gin.H{"error": i18n.LocalizedMessage(c, "error.document_access_denied")})
-		default:
-			c.JSON(http.StatusInternalServerError, gin.H{"error": err.Error()})
-		}
-		return
+		return err
 	}
-	c.JSON(http.StatusOK, gin.H{"message": i18n.LocalizedMessage(c, "message.document_deleted")})
+	return c.JSON(http.StatusOK, map[string]interface{}{"message": "Document deleted successfully"})
 }

 // ActivateDocument handles POST /api/documents/:id/activate/
-func (h *DocumentHandler) ActivateDocument(c *gin.Context) {
-	user := c.MustGet(middleware.AuthUserKey).(*models.User)
+func (h *DocumentHandler) ActivateDocument(c echo.Context) error {
+	user := c.Get(middleware.AuthUserKey).(*models.User)
 	documentID, err := strconv.ParseUint(c.Param("id"), 10, 32)
 	if err != nil {
-		c.JSON(http.StatusBadRequest, gin.H{"error": i18n.LocalizedMessage(c, "error.invalid_document_id")})
-		return
+		return apperrors.BadRequest("error.invalid_document_id")
 	}

 	response, err := h.documentService.ActivateDocument(uint(documentID), user.ID)
 	if err != nil {
-		switch {
-		case errors.Is(err, services.ErrDocumentNotFound):
-			c.JSON(http.StatusNotFound, gin.H{"error": i18n.LocalizedMessage(c, "error.document_not_found")})
-		case errors.Is(err, services.ErrDocumentAccessDenied):
-			c.JSON(http.StatusForbidden, gin.H{"error": i18n.LocalizedMessage(c, "error.document_access_denied")})
-		default:
-			c.JSON(http.StatusInternalServerError, gin.H{"error": err.Error()})
-		}
-		return
+		return err
 	}
-	c.JSON(http.StatusOK, gin.H{"message": i18n.LocalizedMessage(c, "message.document_activated"), "document": response})
+	return c.JSON(http.StatusOK, map[string]interface{}{"message": "Document activated successfully", "document": response})
 }

 // DeactivateDocument handles POST /api/documents/:id/deactivate/
-func (h *DocumentHandler) DeactivateDocument(c *gin.Context) {
-	user := c.MustGet(middleware.AuthUserKey).(*models.User)
+func (h *DocumentHandler) DeactivateDocument(c echo.Context) error {
+	user := c.Get(middleware.AuthUserKey).(*models.User)
 	documentID, err := strconv.ParseUint(c.Param("id"), 10, 32)
 	if err != nil {
-		c.JSON(http.StatusBadRequest, gin.H{"error": i18n.LocalizedMessage(c, "error.invalid_document_id")})
-		return
+		return apperrors.BadRequest("error.invalid_document_id")
 	}

 	response, err := h.documentService.DeactivateDocument(uint(documentID), user.ID)
 	if err != nil {
-		switch {
-		case errors.Is(err, services.ErrDocumentNotFound):
-			c.JSON(http.StatusNotFound, gin.H{"error": i18n.LocalizedMessage(c, "error.document_not_found")})
-		case errors.Is(err, services.ErrDocumentAccessDenied):
-			c.JSON(http.StatusForbidden, gin.H{"error": i18n.LocalizedMessage(c, "error.document_access_denied")})
-		default:
-			c.JSON(http.StatusInternalServerError, gin.H{"error": err.Error()})
-		}
-		return
+		return err
 	}
-	c.JSON(http.StatusOK, gin.H{"message": i18n.LocalizedMessage(c, "message.document_deactivated"), "document": response})
+	return c.JSON(http.StatusOK, map[string]interface{}{"message": "Document deactivated successfully", "document": response})
 }