Fix 113 hardening issues across entire Go backend
Security: - Replace all binding: tags with validate: + c.Validate() in admin handlers - Add rate limiting to auth endpoints (login, register, password reset) - Add security headers (HSTS, XSS protection, nosniff, frame options) - Wire Google Pub/Sub token verification into webhook handler - Replace ParseUnverified with proper OIDC/JWKS key verification - Verify inner Apple JWS signatures in webhook handler - Add io.LimitReader (1MB) to all webhook body reads - Add ownership verification to file deletion - Move hardcoded admin credentials to env vars - Add uniqueIndex to User.Email - Hide ConfirmationCode from JSON serialization - Mask confirmation codes in admin responses - Use http.DetectContentType for upload validation - Fix path traversal in storage service - Replace os.Getenv with Viper in stripe service - Sanitize Redis URLs before logging - Separate DEBUG_FIXED_CODES from DEBUG flag - Reject weak SECRET_KEY in production - Add host check on /_next/* proxy routes - Use explicit localhost CORS origins in debug mode - Replace err.Error() with generic messages in all admin error responses Critical fixes: - Rewrite FCM to HTTP v1 API with OAuth 2.0 service account auth - Fix user_customuser -> auth_user table names in raw SQL - Fix dashboard verified query to use UserProfile model - Add escapeLikeWildcards() to prevent SQL wildcard injection Bug fixes: - Add bounds checks for days/expiring_soon query params (1-3650) - Add receipt_data/transaction_id empty-check to RestoreSubscription - Change Active bool -> *bool in device handler - Check all unchecked GORM/FindByIDWithProfile errors - Add validation for notification hour fields (0-23) - Add max=10000 validation on task description updates Transactions & data integrity: - Wrap registration flow in transaction - Wrap QuickComplete in transaction - Move image creation inside completion transaction - Wrap SetSpecialties in transaction - Wrap GetOrCreateToken in transaction - Wrap completion+image deletion in transaction Performance: - Batch completion summaries (2 queries vs 2N) - Reuse single http.Client in IAP validation - Cache dashboard counts (30s TTL) - Batch COUNT queries in admin user list - Add Limit(500) to document queries - Add reminder_stage+due_date filters to reminder queries - Parse AllowedTypes once at init - In-memory user cache in auth middleware (30s TTL) - Timezone change detection cache - Optimize P95 with per-endpoint sorted buffers - Replace crypto/md5 with hash/fnv for ETags Code quality: - Add sync.Once to all monitoring Stop()/Close() methods - Replace 8 fmt.Printf with zerolog in auth service - Log previously discarded errors - Standardize delete response shapes - Route hardcoded English through i18n - Remove FileURL from DocumentResponse (keep MediaURL only) - Thread user timezone through kanban board responses - Initialize empty slices to prevent null JSON - Extract shared field map for task Update/UpdateTx - Delete unused SoftDeleteModel, min(), formatCron, legacy handlers Worker & jobs: - Wire Asynq email infrastructure into worker - Register HandleReminderLogCleanup with daily 3AM cron - Use per-user timezone in HandleSmartReminder - Replace direct DB queries with repository calls - Delete legacy reminder handlers (~200 lines) - Delete unused task type constants Dependencies: - Replace archived jung-kurt/gofpdf with go-pdf/fpdf - Replace unmaintained gomail.v2 with wneessen/go-mail - Add TODO for Echo jwt v3 transitive dep removal Test infrastructure: - Fix MakeRequest/SeedLookupData error handling - Replace os.Exit(0) with t.Skip() in scope/consistency tests - Add 11 new FCM v1 tests Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Trey t
@@ -1,27 +1,18 @@
|
||||
package worker
|
||||
|
||||
import (
|
||||
"context"
|
||||
"encoding/json"
|
||||
"fmt"
|
||||
"time"
|
||||
|
||||
"github.com/hibiken/asynq"
|
||||
"github.com/rs/zerolog/log"
|
||||
)
|
||||
|
||||
// Task types
|
||||
// Task types for email jobs
|
||||
const (
|
||||
TypeWelcomeEmail = "email:welcome"
|
||||
TypeVerificationEmail = "email:verification"
|
||||
TypePasswordResetEmail = "email:password_reset"
|
||||
TypePasswordChangedEmail = "email:password_changed"
|
||||
TypeTaskCompletionEmail = "email:task_completion"
|
||||
TypeGeneratePDFReport = "pdf:generate_report"
|
||||
TypeUpdateContractorRating = "contractor:update_rating"
|
||||
TypeDailyNotifications = "notifications:daily"
|
||||
TypeTaskReminders = "notifications:task_reminders"
|
||||
TypeOverdueReminders = "notifications:overdue_reminders"
|
||||
TypeWelcomeEmail = "email:welcome"
|
||||
TypeVerificationEmail = "email:verification"
|
||||
TypePasswordResetEmail = "email:password_reset"
|
||||
TypePasswordChangedEmail = "email:password_changed"
|
||||
)
|
||||
|
||||
// EmailPayload is the base payload for email tasks
|
||||
@@ -146,94 +137,3 @@ func (c *TaskClient) EnqueuePasswordChangedEmail(to, firstName string) error {
|
||||
log.Debug().Str("to", to).Msg("Password changed email task enqueued")
|
||||
return nil
|
||||
}
|
||||
|
||||
// WorkerServer manages the asynq worker server
|
||||
type WorkerServer struct {
|
||||
server *asynq.Server
|
||||
scheduler *asynq.Scheduler
|
||||
}
|
||||
|
||||
// NewWorkerServer creates a new worker server
|
||||
func NewWorkerServer(redisAddr string, concurrency int) *WorkerServer {
|
||||
srv := asynq.NewServer(
|
||||
asynq.RedisClientOpt{Addr: redisAddr},
|
||||
asynq.Config{
|
||||
Concurrency: concurrency,
|
||||
Queues: map[string]int{
|
||||
"critical": 6,
|
||||
"default": 3,
|
||||
"low": 1,
|
||||
},
|
||||
ErrorHandler: asynq.ErrorHandlerFunc(func(ctx context.Context, task *asynq.Task, err error) {
|
||||
log.Error().
|
||||
Err(err).
|
||||
Str("type", task.Type()).
|
||||
Bytes("payload", task.Payload()).
|
||||
Msg("Task failed")
|
||||
}),
|
||||
},
|
||||
)
|
||||
|
||||
// Create scheduler for periodic tasks
|
||||
loc, _ := time.LoadLocation("UTC")
|
||||
scheduler := asynq.NewScheduler(
|
||||
asynq.RedisClientOpt{Addr: redisAddr},
|
||||
&asynq.SchedulerOpts{
|
||||
Location: loc,
|
||||
},
|
||||
)
|
||||
|
||||
return &WorkerServer{
|
||||
server: srv,
|
||||
scheduler: scheduler,
|
||||
}
|
||||
}
|
||||
|
||||
// RegisterHandlers registers task handlers
|
||||
func (w *WorkerServer) RegisterHandlers(mux *asynq.ServeMux) {
|
||||
// Handlers will be registered by the main worker process
|
||||
}
|
||||
|
||||
// RegisterScheduledTasks registers periodic tasks
|
||||
func (w *WorkerServer) RegisterScheduledTasks() error {
|
||||
// Task reminders - 8:00 PM UTC daily
|
||||
_, err := w.scheduler.Register("0 20 * * *", asynq.NewTask(TypeTaskReminders, nil))
|
||||
if err != nil {
|
||||
return fmt.Errorf("failed to register task reminders: %w", err)
|
||||
}
|
||||
|
||||
// Overdue reminders - 9:00 AM UTC daily
|
||||
_, err = w.scheduler.Register("0 9 * * *", asynq.NewTask(TypeOverdueReminders, nil))
|
||||
if err != nil {
|
||||
return fmt.Errorf("failed to register overdue reminders: %w", err)
|
||||
}
|
||||
|
||||
// Daily notifications - 11:00 AM UTC daily
|
||||
_, err = w.scheduler.Register("0 11 * * *", asynq.NewTask(TypeDailyNotifications, nil))
|
||||
if err != nil {
|
||||
return fmt.Errorf("failed to register daily notifications: %w", err)
|
||||
}
|
||||
|
||||
return nil
|
||||
}
|
||||
|
||||
// Start starts the worker server and scheduler
|
||||
func (w *WorkerServer) Start(mux *asynq.ServeMux) error {
|
||||
// Start scheduler
|
||||
if err := w.scheduler.Start(); err != nil {
|
||||
return fmt.Errorf("failed to start scheduler: %w", err)
|
||||
}
|
||||
|
||||
// Start server
|
||||
if err := w.server.Start(mux); err != nil {
|
||||
return fmt.Errorf("failed to start worker server: %w", err)
|
||||
}
|
||||
|
||||
return nil
|
||||
}
|
||||
|
||||
// Shutdown gracefully shuts down the worker server
|
||||
func (w *WorkerServer) Shutdown() {
|
||||
w.scheduler.Shutdown()
|
||||
w.server.Shutdown()
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user