Fix 113 hardening issues across entire Go backend
Security: - Replace all binding: tags with validate: + c.Validate() in admin handlers - Add rate limiting to auth endpoints (login, register, password reset) - Add security headers (HSTS, XSS protection, nosniff, frame options) - Wire Google Pub/Sub token verification into webhook handler - Replace ParseUnverified with proper OIDC/JWKS key verification - Verify inner Apple JWS signatures in webhook handler - Add io.LimitReader (1MB) to all webhook body reads - Add ownership verification to file deletion - Move hardcoded admin credentials to env vars - Add uniqueIndex to User.Email - Hide ConfirmationCode from JSON serialization - Mask confirmation codes in admin responses - Use http.DetectContentType for upload validation - Fix path traversal in storage service - Replace os.Getenv with Viper in stripe service - Sanitize Redis URLs before logging - Separate DEBUG_FIXED_CODES from DEBUG flag - Reject weak SECRET_KEY in production - Add host check on /_next/* proxy routes - Use explicit localhost CORS origins in debug mode - Replace err.Error() with generic messages in all admin error responses Critical fixes: - Rewrite FCM to HTTP v1 API with OAuth 2.0 service account auth - Fix user_customuser -> auth_user table names in raw SQL - Fix dashboard verified query to use UserProfile model - Add escapeLikeWildcards() to prevent SQL wildcard injection Bug fixes: - Add bounds checks for days/expiring_soon query params (1-3650) - Add receipt_data/transaction_id empty-check to RestoreSubscription - Change Active bool -> *bool in device handler - Check all unchecked GORM/FindByIDWithProfile errors - Add validation for notification hour fields (0-23) - Add max=10000 validation on task description updates Transactions & data integrity: - Wrap registration flow in transaction - Wrap QuickComplete in transaction - Move image creation inside completion transaction - Wrap SetSpecialties in transaction - Wrap GetOrCreateToken in transaction - Wrap completion+image deletion in transaction Performance: - Batch completion summaries (2 queries vs 2N) - Reuse single http.Client in IAP validation - Cache dashboard counts (30s TTL) - Batch COUNT queries in admin user list - Add Limit(500) to document queries - Add reminder_stage+due_date filters to reminder queries - Parse AllowedTypes once at init - In-memory user cache in auth middleware (30s TTL) - Timezone change detection cache - Optimize P95 with per-endpoint sorted buffers - Replace crypto/md5 with hash/fnv for ETags Code quality: - Add sync.Once to all monitoring Stop()/Close() methods - Replace 8 fmt.Printf with zerolog in auth service - Log previously discarded errors - Standardize delete response shapes - Route hardcoded English through i18n - Remove FileURL from DocumentResponse (keep MediaURL only) - Thread user timezone through kanban board responses - Initialize empty slices to prevent null JSON - Extract shared field map for task Update/UpdateTx - Delete unused SoftDeleteModel, min(), formatCron, legacy handlers Worker & jobs: - Wire Asynq email infrastructure into worker - Register HandleReminderLogCleanup with daily 3AM cron - Use per-user timezone in HandleSmartReminder - Replace direct DB queries with repository calls - Delete legacy reminder handlers (~200 lines) - Delete unused task type constants Dependencies: - Replace archived jung-kurt/gofpdf with go-pdf/fpdf - Replace unmaintained gomail.v2 with wneessen/go-mail - Add TODO for Echo jwt v3 transitive dep removal Test infrastructure: - Fix MakeRequest/SeedLookupData error handling - Replace os.Exit(0) with t.Skip() in scope/consistency tests - Add 11 new FCM v1 tests Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -9,6 +9,7 @@ import (
|
||||
"strings"
|
||||
"time"
|
||||
|
||||
"github.com/rs/zerolog/log"
|
||||
"golang.org/x/crypto/bcrypt"
|
||||
|
||||
"github.com/treytartt/honeydue-api/internal/apperrors"
|
||||
@@ -90,7 +91,7 @@ func (s *AuthService) Login(req *requests.LoginRequest) (*responses.LoginRespons
|
||||
// Update last login
|
||||
if err := s.userRepo.UpdateLastLogin(user.ID); err != nil {
|
||||
// Log error but don't fail the login
|
||||
fmt.Printf("Failed to update last login: %v\n", err)
|
||||
log.Warn().Err(err).Uint("user_id", user.ID).Msg("Failed to update last login")
|
||||
}
|
||||
|
||||
return &responses.LoginResponse{
|
||||
@@ -99,7 +100,9 @@ func (s *AuthService) Login(req *requests.LoginRequest) (*responses.LoginRespons
|
||||
}, nil
|
||||
}
|
||||
|
||||
// Register creates a new user account
|
||||
// Register creates a new user account.
|
||||
// F-10: User creation, profile creation, notification preferences, and confirmation code
|
||||
// are wrapped in a transaction for atomicity.
|
||||
func (s *AuthService) Register(req *requests.RegisterRequest) (*responses.RegisterResponse, string, error) {
|
||||
// Check if username exists
|
||||
exists, err := s.userRepo.ExistsByUsername(req.Username)
|
||||
@@ -133,43 +136,49 @@ func (s *AuthService) Register(req *requests.RegisterRequest) (*responses.Regist
|
||||
return nil, "", apperrors.Internal(err)
|
||||
}
|
||||
|
||||
// Save user
|
||||
if err := s.userRepo.Create(user); err != nil {
|
||||
return nil, "", apperrors.Internal(err)
|
||||
}
|
||||
|
||||
// Create user profile
|
||||
if _, err := s.userRepo.GetOrCreateProfile(user.ID); err != nil {
|
||||
// Log error but don't fail registration
|
||||
fmt.Printf("Failed to create user profile: %v\n", err)
|
||||
}
|
||||
|
||||
// Create notification preferences with all options enabled
|
||||
if s.notificationRepo != nil {
|
||||
if _, err := s.notificationRepo.GetOrCreatePreferences(user.ID); err != nil {
|
||||
// Log error but don't fail registration
|
||||
fmt.Printf("Failed to create notification preferences: %v\n", err)
|
||||
}
|
||||
}
|
||||
|
||||
// Create auth token
|
||||
token, err := s.userRepo.GetOrCreateToken(user.ID)
|
||||
if err != nil {
|
||||
return nil, "", apperrors.Internal(err)
|
||||
}
|
||||
|
||||
// Generate confirmation code - use fixed code in debug mode for easier local testing
|
||||
// Generate confirmation code - use fixed code when DEBUG_FIXED_CODES is enabled for easier local testing
|
||||
var code string
|
||||
if s.cfg.Server.Debug {
|
||||
if s.cfg.Server.DebugFixedCodes {
|
||||
code = "123456"
|
||||
} else {
|
||||
code = generateSixDigitCode()
|
||||
}
|
||||
expiresAt := time.Now().UTC().Add(s.cfg.Security.ConfirmationExpiry)
|
||||
|
||||
if _, err := s.userRepo.CreateConfirmationCode(user.ID, code, expiresAt); err != nil {
|
||||
// Log error but don't fail registration
|
||||
fmt.Printf("Failed to create confirmation code: %v\n", err)
|
||||
// Wrap user creation + profile + notification preferences + confirmation code in a transaction
|
||||
txErr := s.userRepo.Transaction(func(txRepo *repositories.UserRepository) error {
|
||||
// Save user
|
||||
if err := txRepo.Create(user); err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
// Create user profile
|
||||
if _, err := txRepo.GetOrCreateProfile(user.ID); err != nil {
|
||||
log.Warn().Err(err).Uint("user_id", user.ID).Msg("Failed to create user profile during registration")
|
||||
}
|
||||
|
||||
// Create notification preferences with all options enabled
|
||||
if s.notificationRepo != nil {
|
||||
if _, err := s.notificationRepo.GetOrCreatePreferences(user.ID); err != nil {
|
||||
log.Warn().Err(err).Uint("user_id", user.ID).Msg("Failed to create notification preferences during registration")
|
||||
}
|
||||
}
|
||||
|
||||
// Create confirmation code
|
||||
if _, err := txRepo.CreateConfirmationCode(user.ID, code, expiresAt); err != nil {
|
||||
log.Warn().Err(err).Uint("user_id", user.ID).Msg("Failed to create confirmation code during registration")
|
||||
}
|
||||
|
||||
return nil
|
||||
})
|
||||
if txErr != nil {
|
||||
return nil, "", apperrors.Internal(txErr)
|
||||
}
|
||||
|
||||
// Create auth token (outside transaction since token generation is idempotent)
|
||||
token, err := s.userRepo.GetOrCreateToken(user.ID)
|
||||
if err != nil {
|
||||
return nil, "", apperrors.Internal(err)
|
||||
}
|
||||
|
||||
return &responses.RegisterResponse{
|
||||
@@ -248,8 +257,8 @@ func (s *AuthService) VerifyEmail(userID uint, code string) error {
|
||||
return apperrors.BadRequest("error.email_already_verified")
|
||||
}
|
||||
|
||||
// Check for test code in debug mode
|
||||
if s.cfg.Server.Debug && code == "123456" {
|
||||
// Check for test code when DEBUG_FIXED_CODES is enabled
|
||||
if s.cfg.Server.DebugFixedCodes && code == "123456" {
|
||||
if err := s.userRepo.SetProfileVerified(userID, true); err != nil {
|
||||
return apperrors.Internal(err)
|
||||
}
|
||||
@@ -294,9 +303,9 @@ func (s *AuthService) ResendVerificationCode(userID uint) (string, error) {
|
||||
return "", apperrors.BadRequest("error.email_already_verified")
|
||||
}
|
||||
|
||||
// Generate new code - use fixed code in debug mode for easier local testing
|
||||
// Generate new code - use fixed code when DEBUG_FIXED_CODES is enabled for easier local testing
|
||||
var code string
|
||||
if s.cfg.Server.Debug {
|
||||
if s.cfg.Server.DebugFixedCodes {
|
||||
code = "123456"
|
||||
} else {
|
||||
code = generateSixDigitCode()
|
||||
@@ -331,9 +340,9 @@ func (s *AuthService) ForgotPassword(email string) (string, *models.User, error)
|
||||
return "", nil, apperrors.TooManyRequests("error.rate_limit_exceeded")
|
||||
}
|
||||
|
||||
// Generate code and reset token - use fixed code in debug mode for easier local testing
|
||||
// Generate code and reset token - use fixed code when DEBUG_FIXED_CODES is enabled for easier local testing
|
||||
var code string
|
||||
if s.cfg.Server.Debug {
|
||||
if s.cfg.Server.DebugFixedCodes {
|
||||
code = "123456"
|
||||
} else {
|
||||
code = generateSixDigitCode()
|
||||
@@ -365,8 +374,8 @@ func (s *AuthService) VerifyResetCode(email, code string) (string, error) {
|
||||
return "", apperrors.Internal(err)
|
||||
}
|
||||
|
||||
// Check for test code in debug mode
|
||||
if s.cfg.Server.Debug && code == "123456" {
|
||||
// Check for test code when DEBUG_FIXED_CODES is enabled
|
||||
if s.cfg.Server.DebugFixedCodes && code == "123456" {
|
||||
return resetCode.ResetToken, nil
|
||||
}
|
||||
|
||||
@@ -422,13 +431,13 @@ func (s *AuthService) ResetPassword(resetToken, newPassword string) error {
|
||||
// Mark reset code as used
|
||||
if err := s.userRepo.MarkPasswordResetCodeUsed(resetCode.ID); err != nil {
|
||||
// Log error but don't fail
|
||||
fmt.Printf("Failed to mark reset code as used: %v\n", err)
|
||||
log.Warn().Err(err).Uint("reset_code_id", resetCode.ID).Msg("Failed to mark reset code as used")
|
||||
}
|
||||
|
||||
// Invalidate all existing tokens for this user (security measure)
|
||||
if err := s.userRepo.DeleteTokenByUserID(user.ID); err != nil {
|
||||
// Log error but don't fail
|
||||
fmt.Printf("Failed to delete user tokens: %v\n", err)
|
||||
log.Warn().Err(err).Uint("user_id", user.ID).Msg("Failed to delete user tokens after password reset")
|
||||
}
|
||||
|
||||
return nil
|
||||
@@ -482,6 +491,13 @@ func (s *AuthService) AppleSignIn(ctx context.Context, appleAuth *AppleAuthServi
|
||||
if email != "" {
|
||||
existingUser, err := s.userRepo.FindByEmail(email)
|
||||
if err == nil && existingUser != nil {
|
||||
// S-06: Log auto-linking of social account to existing user
|
||||
log.Warn().
|
||||
Str("email", email).
|
||||
Str("provider", "apple").
|
||||
Uint("user_id", existingUser.ID).
|
||||
Msg("Auto-linking social account to existing user by email match")
|
||||
|
||||
// Link Apple ID to existing account
|
||||
appleAuthRecord := &models.AppleSocialAuth{
|
||||
UserID: existingUser.ID,
|
||||
@@ -505,8 +521,11 @@ func (s *AuthService) AppleSignIn(ctx context.Context, appleAuth *AppleAuthServi
|
||||
// Update last login
|
||||
_ = s.userRepo.UpdateLastLogin(existingUser.ID)
|
||||
|
||||
// Reload user with profile
|
||||
existingUser, _ = s.userRepo.FindByIDWithProfile(existingUser.ID)
|
||||
// B-08: Check error from FindByIDWithProfile
|
||||
existingUser, err = s.userRepo.FindByIDWithProfile(existingUser.ID)
|
||||
if err != nil {
|
||||
return nil, apperrors.Internal(err)
|
||||
}
|
||||
|
||||
return &responses.AppleSignInResponse{
|
||||
Token: token.Key,
|
||||
@@ -544,8 +563,7 @@ func (s *AuthService) AppleSignIn(ctx context.Context, appleAuth *AppleAuthServi
|
||||
// Create notification preferences with all options enabled
|
||||
if s.notificationRepo != nil {
|
||||
if _, err := s.notificationRepo.GetOrCreatePreferences(user.ID); err != nil {
|
||||
// Log error but don't fail registration
|
||||
fmt.Printf("Failed to create notification preferences: %v\n", err)
|
||||
log.Warn().Err(err).Uint("user_id", user.ID).Msg("Failed to create notification preferences for Apple Sign In user")
|
||||
}
|
||||
}
|
||||
|
||||
@@ -566,8 +584,11 @@ func (s *AuthService) AppleSignIn(ctx context.Context, appleAuth *AppleAuthServi
|
||||
return nil, apperrors.Internal(err)
|
||||
}
|
||||
|
||||
// Reload user with profile
|
||||
user, _ = s.userRepo.FindByIDWithProfile(user.ID)
|
||||
// B-08: Check error from FindByIDWithProfile
|
||||
user, err = s.userRepo.FindByIDWithProfile(user.ID)
|
||||
if err != nil {
|
||||
return nil, apperrors.Internal(err)
|
||||
}
|
||||
|
||||
return &responses.AppleSignInResponse{
|
||||
Token: token.Key,
|
||||
@@ -623,6 +644,13 @@ func (s *AuthService) GoogleSignIn(ctx context.Context, googleAuth *GoogleAuthSe
|
||||
if email != "" {
|
||||
existingUser, err := s.userRepo.FindByEmail(email)
|
||||
if err == nil && existingUser != nil {
|
||||
// S-06: Log auto-linking of social account to existing user
|
||||
log.Warn().
|
||||
Str("email", email).
|
||||
Str("provider", "google").
|
||||
Uint("user_id", existingUser.ID).
|
||||
Msg("Auto-linking social account to existing user by email match")
|
||||
|
||||
// Link Google ID to existing account
|
||||
googleAuthRecord := &models.GoogleSocialAuth{
|
||||
UserID: existingUser.ID,
|
||||
@@ -649,8 +677,11 @@ func (s *AuthService) GoogleSignIn(ctx context.Context, googleAuth *GoogleAuthSe
|
||||
// Update last login
|
||||
_ = s.userRepo.UpdateLastLogin(existingUser.ID)
|
||||
|
||||
// Reload user with profile
|
||||
existingUser, _ = s.userRepo.FindByIDWithProfile(existingUser.ID)
|
||||
// B-08: Check error from FindByIDWithProfile
|
||||
existingUser, err = s.userRepo.FindByIDWithProfile(existingUser.ID)
|
||||
if err != nil {
|
||||
return nil, apperrors.Internal(err)
|
||||
}
|
||||
|
||||
return &responses.GoogleSignInResponse{
|
||||
Token: token.Key,
|
||||
@@ -688,8 +719,7 @@ func (s *AuthService) GoogleSignIn(ctx context.Context, googleAuth *GoogleAuthSe
|
||||
// Create notification preferences with all options enabled
|
||||
if s.notificationRepo != nil {
|
||||
if _, err := s.notificationRepo.GetOrCreatePreferences(user.ID); err != nil {
|
||||
// Log error but don't fail registration
|
||||
fmt.Printf("Failed to create notification preferences: %v\n", err)
|
||||
log.Warn().Err(err).Uint("user_id", user.ID).Msg("Failed to create notification preferences for Google Sign In user")
|
||||
}
|
||||
}
|
||||
|
||||
@@ -711,8 +741,11 @@ func (s *AuthService) GoogleSignIn(ctx context.Context, googleAuth *GoogleAuthSe
|
||||
return nil, apperrors.Internal(err)
|
||||
}
|
||||
|
||||
// Reload user with profile
|
||||
user, _ = s.userRepo.FindByIDWithProfile(user.ID)
|
||||
// B-08: Check error from FindByIDWithProfile
|
||||
user, err = s.userRepo.FindByIDWithProfile(user.ID)
|
||||
if err != nil {
|
||||
return nil, apperrors.Internal(err)
|
||||
}
|
||||
|
||||
return &responses.GoogleSignInResponse{
|
||||
Token: token.Key,
|
||||
|
||||
Reference in New Issue
Block a user