Fix 113 hardening issues across entire Go backend
Security: - Replace all binding: tags with validate: + c.Validate() in admin handlers - Add rate limiting to auth endpoints (login, register, password reset) - Add security headers (HSTS, XSS protection, nosniff, frame options) - Wire Google Pub/Sub token verification into webhook handler - Replace ParseUnverified with proper OIDC/JWKS key verification - Verify inner Apple JWS signatures in webhook handler - Add io.LimitReader (1MB) to all webhook body reads - Add ownership verification to file deletion - Move hardcoded admin credentials to env vars - Add uniqueIndex to User.Email - Hide ConfirmationCode from JSON serialization - Mask confirmation codes in admin responses - Use http.DetectContentType for upload validation - Fix path traversal in storage service - Replace os.Getenv with Viper in stripe service - Sanitize Redis URLs before logging - Separate DEBUG_FIXED_CODES from DEBUG flag - Reject weak SECRET_KEY in production - Add host check on /_next/* proxy routes - Use explicit localhost CORS origins in debug mode - Replace err.Error() with generic messages in all admin error responses Critical fixes: - Rewrite FCM to HTTP v1 API with OAuth 2.0 service account auth - Fix user_customuser -> auth_user table names in raw SQL - Fix dashboard verified query to use UserProfile model - Add escapeLikeWildcards() to prevent SQL wildcard injection Bug fixes: - Add bounds checks for days/expiring_soon query params (1-3650) - Add receipt_data/transaction_id empty-check to RestoreSubscription - Change Active bool -> *bool in device handler - Check all unchecked GORM/FindByIDWithProfile errors - Add validation for notification hour fields (0-23) - Add max=10000 validation on task description updates Transactions & data integrity: - Wrap registration flow in transaction - Wrap QuickComplete in transaction - Move image creation inside completion transaction - Wrap SetSpecialties in transaction - Wrap GetOrCreateToken in transaction - Wrap completion+image deletion in transaction Performance: - Batch completion summaries (2 queries vs 2N) - Reuse single http.Client in IAP validation - Cache dashboard counts (30s TTL) - Batch COUNT queries in admin user list - Add Limit(500) to document queries - Add reminder_stage+due_date filters to reminder queries - Parse AllowedTypes once at init - In-memory user cache in auth middleware (30s TTL) - Timezone change detection cache - Optimize P95 with per-endpoint sorted buffers - Replace crypto/md5 with hash/fnv for ETags Code quality: - Add sync.Once to all monitoring Stop()/Close() methods - Replace 8 fmt.Printf with zerolog in auth service - Log previously discarded errors - Standardize delete response shapes - Route hardcoded English through i18n - Remove FileURL from DocumentResponse (keep MediaURL only) - Thread user timezone through kanban board responses - Initialize empty slices to prevent null JSON - Extract shared field map for task Update/UpdateTx - Delete unused SoftDeleteModel, min(), formatCron, legacy handlers Worker & jobs: - Wire Asynq email infrastructure into worker - Register HandleReminderLogCleanup with daily 3AM cron - Use per-user timezone in HandleSmartReminder - Replace direct DB queries with repository calls - Delete legacy reminder handlers (~200 lines) - Delete unused task type constants Dependencies: - Replace archived jung-kurt/gofpdf with go-pdf/fpdf - Replace unmaintained gomail.v2 with wneessen/go-mail - Add TODO for Echo jwt v3 transitive dep removal Test infrastructure: - Fix MakeRequest/SeedLookupData error handling - Replace os.Exit(0) with t.Skip() in scope/consistency tests - Add 11 new FCM v1 tests Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Trey t
@@ -248,180 +248,10 @@ func TestDocument_JSONSerialization(t *testing.T) {
|
||||
assert.Equal(t, "5000", result["purchase_price"]) // Decimal serializes as string
|
||||
}
|
||||
|
||||
// ============================================================================
|
||||
// TASK KANBAN COLUMN TESTS
|
||||
// These tests verify GetKanbanColumn and GetKanbanColumnWithTimezone methods
|
||||
// ============================================================================
|
||||
|
||||
func timePtr(t time.Time) *time.Time {
|
||||
return &t
|
||||
}
|
||||
|
||||
func TestTask_GetKanbanColumn_PriorityOrder(t *testing.T) {
|
||||
now := time.Date(2025, 12, 16, 12, 0, 0, 0, time.UTC)
|
||||
yesterday := time.Date(2025, 12, 15, 0, 0, 0, 0, time.UTC)
|
||||
in5Days := time.Date(2025, 12, 21, 0, 0, 0, 0, time.UTC)
|
||||
in60Days := time.Date(2026, 2, 14, 0, 0, 0, 0, time.UTC)
|
||||
|
||||
tests := []struct {
|
||||
name string
|
||||
task *Task
|
||||
expected string
|
||||
}{
|
||||
// Priority 1: Cancelled
|
||||
{
|
||||
name: "cancelled takes highest priority",
|
||||
task: &Task{
|
||||
IsCancelled: true,
|
||||
NextDueDate: timePtr(yesterday),
|
||||
InProgress: true,
|
||||
},
|
||||
expected: "cancelled_tasks",
|
||||
},
|
||||
|
||||
// Priority 2: Completed
|
||||
{
|
||||
name: "completed: NextDueDate nil with completions",
|
||||
task: &Task{
|
||||
IsCancelled: false,
|
||||
NextDueDate: nil,
|
||||
DueDate: timePtr(yesterday),
|
||||
Completions: []TaskCompletion{{BaseModel: BaseModel{ID: 1}}},
|
||||
},
|
||||
expected: "completed_tasks",
|
||||
},
|
||||
|
||||
// Priority 3: In Progress
|
||||
{
|
||||
name: "in progress takes priority over overdue",
|
||||
task: &Task{
|
||||
IsCancelled: false,
|
||||
NextDueDate: timePtr(yesterday),
|
||||
InProgress: true,
|
||||
},
|
||||
expected: "in_progress_tasks",
|
||||
},
|
||||
|
||||
// Priority 4: Overdue
|
||||
{
|
||||
name: "overdue: effective date in past",
|
||||
task: &Task{
|
||||
IsCancelled: false,
|
||||
NextDueDate: timePtr(yesterday),
|
||||
},
|
||||
expected: "overdue_tasks",
|
||||
},
|
||||
|
||||
// Priority 5: Due Soon
|
||||
{
|
||||
name: "due soon: within 30-day threshold",
|
||||
task: &Task{
|
||||
IsCancelled: false,
|
||||
NextDueDate: timePtr(in5Days),
|
||||
},
|
||||
expected: "due_soon_tasks",
|
||||
},
|
||||
|
||||
// Priority 6: Upcoming
|
||||
{
|
||||
name: "upcoming: beyond threshold",
|
||||
task: &Task{
|
||||
IsCancelled: false,
|
||||
NextDueDate: timePtr(in60Days),
|
||||
},
|
||||
expected: "upcoming_tasks",
|
||||
},
|
||||
{
|
||||
name: "upcoming: no due date",
|
||||
task: &Task{
|
||||
IsCancelled: false,
|
||||
NextDueDate: nil,
|
||||
DueDate: nil,
|
||||
},
|
||||
expected: "upcoming_tasks",
|
||||
},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
result := tt.task.GetKanbanColumnWithTimezone(30, now)
|
||||
assert.Equal(t, tt.expected, result)
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestTask_GetKanbanColumnWithTimezone_TimezoneAware(t *testing.T) {
|
||||
// Task due Dec 17, 2025
|
||||
taskDueDate := time.Date(2025, 12, 17, 0, 0, 0, 0, time.UTC)
|
||||
|
||||
task := &Task{
|
||||
NextDueDate: timePtr(taskDueDate),
|
||||
IsCancelled: false,
|
||||
}
|
||||
|
||||
// At 11 PM UTC on Dec 16 (UTC user) - task is tomorrow, due_soon
|
||||
utcDec16Evening := time.Date(2025, 12, 16, 23, 0, 0, 0, time.UTC)
|
||||
result := task.GetKanbanColumnWithTimezone(30, utcDec16Evening)
|
||||
assert.Equal(t, "due_soon_tasks", result, "UTC Dec 16 evening")
|
||||
|
||||
// At 8 AM UTC on Dec 17 (UTC user) - task is today, due_soon
|
||||
utcDec17Morning := time.Date(2025, 12, 17, 8, 0, 0, 0, time.UTC)
|
||||
result = task.GetKanbanColumnWithTimezone(30, utcDec17Morning)
|
||||
assert.Equal(t, "due_soon_tasks", result, "UTC Dec 17 morning")
|
||||
|
||||
// At 8 AM UTC on Dec 18 (UTC user) - task was yesterday, overdue
|
||||
utcDec18Morning := time.Date(2025, 12, 18, 8, 0, 0, 0, time.UTC)
|
||||
result = task.GetKanbanColumnWithTimezone(30, utcDec18Morning)
|
||||
assert.Equal(t, "overdue_tasks", result, "UTC Dec 18 morning")
|
||||
|
||||
// Tokyo user at 11 PM UTC Dec 16 = 8 AM Dec 17 Tokyo
|
||||
// Task due Dec 17 is TODAY for Tokyo user - due_soon
|
||||
tokyo, _ := time.LoadLocation("Asia/Tokyo")
|
||||
tokyoDec17Morning := utcDec16Evening.In(tokyo)
|
||||
result = task.GetKanbanColumnWithTimezone(30, tokyoDec17Morning)
|
||||
assert.Equal(t, "due_soon_tasks", result, "Tokyo Dec 17 morning")
|
||||
|
||||
// Tokyo at 8 AM Dec 18 UTC = 5 PM Dec 18 Tokyo
|
||||
// Task due Dec 17 was YESTERDAY for Tokyo - overdue
|
||||
tokyoDec18 := utcDec18Morning.In(tokyo)
|
||||
result = task.GetKanbanColumnWithTimezone(30, tokyoDec18)
|
||||
assert.Equal(t, "overdue_tasks", result, "Tokyo Dec 18")
|
||||
}
|
||||
|
||||
func TestTask_GetKanbanColumnWithTimezone_DueSoonThreshold(t *testing.T) {
|
||||
now := time.Date(2025, 12, 16, 12, 0, 0, 0, time.UTC)
|
||||
|
||||
// Task due in 29 days - within 30-day threshold
|
||||
due29Days := time.Date(2026, 1, 14, 0, 0, 0, 0, time.UTC)
|
||||
task29 := &Task{NextDueDate: timePtr(due29Days)}
|
||||
result := task29.GetKanbanColumnWithTimezone(30, now)
|
||||
assert.Equal(t, "due_soon_tasks", result, "29 days should be due_soon")
|
||||
|
||||
// Task due in exactly 30 days - at threshold boundary (upcoming, not due_soon)
|
||||
due30Days := time.Date(2026, 1, 15, 0, 0, 0, 0, time.UTC)
|
||||
task30 := &Task{NextDueDate: timePtr(due30Days)}
|
||||
result = task30.GetKanbanColumnWithTimezone(30, now)
|
||||
assert.Equal(t, "upcoming_tasks", result, "30 days should be upcoming (at boundary)")
|
||||
|
||||
// Task due in 31 days - beyond threshold
|
||||
due31Days := time.Date(2026, 1, 16, 0, 0, 0, 0, time.UTC)
|
||||
task31 := &Task{NextDueDate: timePtr(due31Days)}
|
||||
result = task31.GetKanbanColumnWithTimezone(30, now)
|
||||
assert.Equal(t, "upcoming_tasks", result, "31 days should be upcoming")
|
||||
}
|
||||
|
||||
func TestTask_GetKanbanColumn_CompletionCount(t *testing.T) {
|
||||
// Test that CompletionCount is also used for completion detection
|
||||
task := &Task{
|
||||
NextDueDate: nil,
|
||||
CompletionCount: 1, // Using CompletionCount instead of Completions slice
|
||||
Completions: []TaskCompletion{},
|
||||
}
|
||||
|
||||
result := task.GetKanbanColumn(30)
|
||||
assert.Equal(t, "completed_tasks", result)
|
||||
}
|
||||
|
||||
func TestTask_IsOverdueAt_DayBased(t *testing.T) {
|
||||
// Test that IsOverdueAt uses day-based comparison
|
||||
now := time.Date(2025, 12, 16, 15, 0, 0, 0, time.UTC) // 3 PM UTC
|
||||
|
||||
Reference in New Issue
Block a user