Fix 28 issues from deep audit and UI audit + redesign changes
Some checks failed
Apple Platform CI / smoke-and-tests (push) Has been cancelled
Some checks failed
Apple Platform CI / smoke-and-tests (push) Has been cancelled
Deep audit (issues 2-14): - Add missing WCSession handlers for applicationContext and userInfo - Fix BoundedFIFOQueue race condition with serial dispatch queue - Fix timer race condition with main thread guarantee - Fix watch pause state divergence — phone is now source of truth - Fix wrong notification posted on logout (createdNewWorkout → userLoggedOut) - Fix POST status check to accept any 2xx (was exact match) - Fix @StateObject → @ObservedObject for injected viewModel - Add pull-to-refresh to CompletedWorkoutsView - Fix typos: RefreshUserInfoFetcable, defualtPackageModle - Replace string concatenation with interpolation - Replace 6 @StateObject with @ObservedObject for BridgeModule.shared - Replace 7 hardcoded AVPlayer URLs with BaseURLs.currentBaseURL UI audit (issues 1-15): - Fix GeometryReader eating VStack space — replaced with .overlay - Fix refreshable continuation resuming before fetch completes - Remove duplicate @State workouts — derive from DataStore - Decouple leaf views from BridgeModule (pass discrete values) - Convert selectedIds from Array to Set for O(1) lookups - Extract .sorted() from var body into computed properties - Move search filter out of ForEach render loop - Replace import SwiftUI with import Combine in non-UI classes - Mark all @State properties private - Extract L/R exercise auto-add logic to WorkoutViewModel - Use enumerated() instead of .indices in ForEach - Make AddSupersetView frame flexible instead of fixed 300pt - Hoist Set construction out of per-exercise filter loop - Move ViewModel network fetch from init to load() Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -39,17 +39,21 @@ extension BridgeModule: WCSessionDelegate {
|
||||
}
|
||||
|
||||
private func flushQueuedWatchMessages() {
|
||||
let queuedMessages = queuedWatchMessages.dequeueAll()
|
||||
guard queuedMessages.isEmpty == false else {
|
||||
return
|
||||
watchMessageQueue.sync {
|
||||
let queuedMessages = queuedWatchMessages.dequeueAll()
|
||||
guard queuedMessages.isEmpty == false else {
|
||||
return
|
||||
}
|
||||
queuedMessages.forEach { send($0) }
|
||||
}
|
||||
queuedMessages.forEach { send($0) }
|
||||
}
|
||||
|
||||
private func enqueueWatchMessage(_ data: Data) {
|
||||
let droppedCount = queuedWatchMessages.enqueue(data)
|
||||
if droppedCount > 0 {
|
||||
watchBridgeLogger.warning("Dropping oldest queued watch message to enforce queue cap")
|
||||
watchMessageQueue.sync {
|
||||
let droppedCount = queuedWatchMessages.enqueue(data)
|
||||
if droppedCount > 0 {
|
||||
watchBridgeLogger.warning("Dropping oldest queued watch message to enforce queue cap")
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -90,7 +94,7 @@ extension BridgeModule: WCSessionDelegate {
|
||||
}
|
||||
}
|
||||
|
||||
func session(_ session: WCSession, didReceiveMessageData messageData: Data) {
|
||||
func dataToAction(messageData: Data) {
|
||||
do {
|
||||
let model = try WatchPayloadValidation.decode(WatchActions.self, from: messageData)
|
||||
DispatchQueue.main.async {
|
||||
@@ -119,6 +123,10 @@ extension BridgeModule: WCSessionDelegate {
|
||||
watchBridgeLogger.error("Rejected WatchActions payload: \(error.localizedDescription, privacy: .public)")
|
||||
}
|
||||
}
|
||||
|
||||
func session(_ session: WCSession, didReceiveMessageData messageData: Data) {
|
||||
dataToAction(messageData: messageData)
|
||||
}
|
||||
|
||||
|
||||
func session(_ session: WCSession,
|
||||
@@ -158,6 +166,22 @@ extension BridgeModule: WCSessionDelegate {
|
||||
func sessionDidDeactivate(_ session: WCSession) {
|
||||
session.activate()
|
||||
}
|
||||
|
||||
func session(_ session: WCSession, didReceiveApplicationContext applicationContext: [String : Any]) {
|
||||
if let messageData = applicationContext["package"] as? Data {
|
||||
DispatchQueue.main.async {
|
||||
self.dataToAction(messageData: messageData)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func session(_ session: WCSession, didReceiveUserInfo userInfo: [String : Any] = [:]) {
|
||||
if let messageData = userInfo["package"] as? Data {
|
||||
DispatchQueue.main.async {
|
||||
self.dataToAction(messageData: messageData)
|
||||
}
|
||||
}
|
||||
}
|
||||
#endif
|
||||
func send(_ data: Data) {
|
||||
guard WCSession.isSupported() else {
|
||||
|
||||
Reference in New Issue
Block a user