Deep audit identified 106 findings; 102 fixed, 4 deferred. Covers 8 areas: - Settings & deploy: env-gated DEBUG/SECRET_KEY, HTTPS headers, gunicorn, celery worker - Auth (registered_user): password write_only, request.data fixes, transaction safety, proper HTTP status codes - Workout app: IDOR protection, get_object_or_404, prefetch_related N+1 fixes, transaction.atomic - Video/scripts: path traversal sanitization, HLS trigger guard, auth on cache wipe - Models (exercise/equipment/muscle/superset): null-safe __str__, stable IDs, prefetch support - Generator views: helper for registered_user lookup, logger.exception, bulk_update, transaction wrapping - Generator core (rules/selector/generator): push-pull ratio, type affinity normalization, modality checks, side-pair exact match, word-boundary regex, equipment cache clearing - Generator services (plan_builder/analyzer/normalizer): transaction.atomic, muscle cache, bulk_update, glutes classification fix Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
40 lines
1.5 KiB
Python
40 lines
1.5 KiB
Python
import math
|
|
import random
|
|
|
|
|
|
def pick_reps_for_exercise(exercise, wt_params: dict, tier_ranges: dict, rng=random) -> int:
|
|
"""Pick reps from tier-specific range, then fallback to generic wt params."""
|
|
tier = (getattr(exercise, 'exercise_tier', None) or 'accessory').lower()
|
|
selected_range = tier_ranges.get(tier) or (wt_params['rep_min'], wt_params['rep_max'])
|
|
low, high = int(selected_range[0]), int(selected_range[1])
|
|
if low > high:
|
|
low, high = high, low
|
|
return rng.randint(low, high)
|
|
|
|
|
|
def apply_rep_volume_floor(entries: list[dict], rounds: int, min_volume: int) -> None:
|
|
"""Mutate entries in-place so reps*rounds meets the minimum volume floor."""
|
|
if rounds <= 0:
|
|
return
|
|
for entry in entries:
|
|
reps = entry.get('reps')
|
|
if reps and reps * rounds < min_volume:
|
|
entry['reps'] = max(reps, math.ceil(min_volume / rounds))
|
|
|
|
|
|
def working_rest_seconds(rest_override, default_rest: int, minimum_rest: int = 15) -> int:
|
|
"""Return guarded positive working rest in seconds."""
|
|
rest = rest_override or default_rest or 45
|
|
return max(minimum_rest, int(rest))
|
|
|
|
|
|
def sort_entries_by_hr(entries: list[dict], is_early_block: bool) -> None:
|
|
"""Sort entries by HR elevation and re-number order."""
|
|
entries.sort(
|
|
key=lambda e: getattr(e.get('exercise'), 'hr_elevation_rating', 5) or 5,
|
|
reverse=is_early_block,
|
|
)
|
|
for idx, entry in enumerate(entries, start=1):
|
|
entry['order'] = idx
|
|
|