Codebase hardening: 102 fixes across 35+ files
Deep audit identified 106 findings; 102 fixed, 4 deferred. Covers 8 areas: - Settings & deploy: env-gated DEBUG/SECRET_KEY, HTTPS headers, gunicorn, celery worker - Auth (registered_user): password write_only, request.data fixes, transaction safety, proper HTTP status codes - Workout app: IDOR protection, get_object_or_404, prefetch_related N+1 fixes, transaction.atomic - Video/scripts: path traversal sanitization, HLS trigger guard, auth on cache wipe - Models (exercise/equipment/muscle/superset): null-safe __str__, stable IDs, prefetch support - Generator views: helper for registered_user lookup, logger.exception, bulk_update, transaction wrapping - Generator core (rules/selector/generator): push-pull ratio, type affinity normalization, modality checks, side-pair exact match, word-boundary regex, equipment cache clearing - Generator services (plan_builder/analyzer/normalizer): transaction.atomic, muscle cache, bulk_update, glutes classification fix Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Trey t
@@ -85,8 +85,8 @@ class TestWarmupSelector(TestCase):
|
||||
self.assertNotIn(weighted_press.pk, selected_ids)
|
||||
self.assertNotIn(duration_push.pk, selected_ids)
|
||||
|
||||
def test_warmup_excludes_side_specific_variants(self):
|
||||
left_variant = Exercise.objects.create(
|
||||
def test_warmup_keeps_side_specific_variants_adjacent(self):
|
||||
left_variant_a = Exercise.objects.create(
|
||||
name='Side Lying T Stretch',
|
||||
side='left_arm',
|
||||
movement_patterns='dynamic stretch, mobility - dynamic, warm up',
|
||||
@@ -99,7 +99,7 @@ class TestWarmupSelector(TestCase):
|
||||
complexity_rating=1,
|
||||
difficulty_level='beginner',
|
||||
)
|
||||
right_variant = Exercise.objects.create(
|
||||
right_variant_a = Exercise.objects.create(
|
||||
name='Side Lying T Stretch',
|
||||
side='right_arm',
|
||||
movement_patterns='dynamic stretch, mobility - dynamic, warm up',
|
||||
@@ -112,9 +112,9 @@ class TestWarmupSelector(TestCase):
|
||||
complexity_rating=1,
|
||||
difficulty_level='beginner',
|
||||
)
|
||||
unsided_a = Exercise.objects.create(
|
||||
name='Worlds Greatest Stretch',
|
||||
side='',
|
||||
left_variant_b = Exercise.objects.create(
|
||||
name='Quadruped Adductor Stretch with Thoracic Rotation',
|
||||
side='left_side',
|
||||
movement_patterns='dynamic stretch, mobility - dynamic, warm up',
|
||||
is_duration=True,
|
||||
is_reps=False,
|
||||
@@ -125,31 +125,47 @@ class TestWarmupSelector(TestCase):
|
||||
complexity_rating=1,
|
||||
difficulty_level='beginner',
|
||||
)
|
||||
unsided_b = Exercise.objects.create(
|
||||
name='Hip Opener Flow',
|
||||
side='',
|
||||
movement_patterns='activation, warmup, cardio/locomotion',
|
||||
right_variant_b = Exercise.objects.create(
|
||||
name='Quadruped Adductor Stretch with Thoracic Rotation',
|
||||
side='right_side',
|
||||
movement_patterns='dynamic stretch, mobility - dynamic, warm up',
|
||||
is_duration=True,
|
||||
is_reps=False,
|
||||
is_weight=False,
|
||||
is_compound=False,
|
||||
exercise_tier='accessory',
|
||||
hr_elevation_rating=3,
|
||||
complexity_rating=2,
|
||||
hr_elevation_rating=2,
|
||||
complexity_rating=1,
|
||||
difficulty_level='beginner',
|
||||
)
|
||||
|
||||
selector = ExerciseSelector(self.preference)
|
||||
selected = selector.select_warmup_exercises(target_muscles=[], count=2)
|
||||
selected_ids = {ex.pk for ex in selected}
|
||||
selected = selector.select_warmup_exercises(target_muscles=[], count=4)
|
||||
|
||||
self.assertEqual(selected_ids, {unsided_a.pk, unsided_b.pk})
|
||||
self.assertNotIn(left_variant.pk, selected_ids)
|
||||
self.assertNotIn(right_variant.pk, selected_ids)
|
||||
self.assertTrue(all(not (ex.side or '').strip() for ex in selected))
|
||||
selected_ids = [ex.pk for ex in selected]
|
||||
self.assertEqual(
|
||||
set(selected_ids),
|
||||
{left_variant_a.pk, right_variant_a.pk, left_variant_b.pk, right_variant_b.pk},
|
||||
)
|
||||
|
||||
def test_cooldown_excludes_side_specific_variants(self):
|
||||
left_variant = Exercise.objects.create(
|
||||
side_pairs = {}
|
||||
for idx, ex in enumerate(selected):
|
||||
key = selector._strip_side_tokens(ex.name)
|
||||
side_pairs.setdefault(key, []).append(idx)
|
||||
|
||||
self.assertEqual(len(side_pairs['side lying t stretch']), 2)
|
||||
self.assertEqual(len(side_pairs['quadruped adductor stretch with thoracic rotation']), 2)
|
||||
self.assertEqual(
|
||||
side_pairs['side lying t stretch'][1],
|
||||
side_pairs['side lying t stretch'][0] + 1,
|
||||
)
|
||||
self.assertEqual(
|
||||
side_pairs['quadruped adductor stretch with thoracic rotation'][1],
|
||||
side_pairs['quadruped adductor stretch with thoracic rotation'][0] + 1,
|
||||
)
|
||||
|
||||
def test_cooldown_keeps_side_specific_variants_adjacent(self):
|
||||
left_variant_a = Exercise.objects.create(
|
||||
name="Matsyendra's Pose",
|
||||
side='left_side',
|
||||
movement_patterns='static stretch, cool down',
|
||||
@@ -162,7 +178,7 @@ class TestWarmupSelector(TestCase):
|
||||
complexity_rating=1,
|
||||
difficulty_level='beginner',
|
||||
)
|
||||
right_variant = Exercise.objects.create(
|
||||
right_variant_a = Exercise.objects.create(
|
||||
name="Matsyendra's Pose",
|
||||
side='right_side',
|
||||
movement_patterns='static stretch, cool down',
|
||||
@@ -175,9 +191,9 @@ class TestWarmupSelector(TestCase):
|
||||
complexity_rating=1,
|
||||
difficulty_level='beginner',
|
||||
)
|
||||
unsided_a = Exercise.objects.create(
|
||||
name='Butterfly Stretch',
|
||||
side='',
|
||||
left_variant_b = Exercise.objects.create(
|
||||
name='Miniband Reverse Clamshell',
|
||||
side='left_leg',
|
||||
movement_patterns='mobility - static, cooldown',
|
||||
is_duration=True,
|
||||
is_reps=False,
|
||||
@@ -188,25 +204,41 @@ class TestWarmupSelector(TestCase):
|
||||
complexity_rating=1,
|
||||
difficulty_level='beginner',
|
||||
)
|
||||
unsided_b = Exercise.objects.create(
|
||||
name='Hamstring Reach',
|
||||
side='',
|
||||
movement_patterns='static stretch, cool down',
|
||||
right_variant_b = Exercise.objects.create(
|
||||
name='Miniband Reverse Clamshell',
|
||||
side='right_leg',
|
||||
movement_patterns='mobility - static, cooldown',
|
||||
is_duration=True,
|
||||
is_reps=False,
|
||||
is_weight=False,
|
||||
is_compound=False,
|
||||
exercise_tier='accessory',
|
||||
hr_elevation_rating=2,
|
||||
hr_elevation_rating=1,
|
||||
complexity_rating=1,
|
||||
difficulty_level='beginner',
|
||||
)
|
||||
|
||||
selector = ExerciseSelector(self.preference)
|
||||
selected = selector.select_cooldown_exercises(target_muscles=[], count=2)
|
||||
selected_ids = {ex.pk for ex in selected}
|
||||
selected = selector.select_cooldown_exercises(target_muscles=[], count=4)
|
||||
|
||||
self.assertEqual(selected_ids, {unsided_a.pk, unsided_b.pk})
|
||||
self.assertNotIn(left_variant.pk, selected_ids)
|
||||
self.assertNotIn(right_variant.pk, selected_ids)
|
||||
self.assertTrue(all(not (ex.side or '').strip() for ex in selected))
|
||||
selected_ids = [ex.pk for ex in selected]
|
||||
self.assertEqual(
|
||||
set(selected_ids),
|
||||
{left_variant_a.pk, right_variant_a.pk, left_variant_b.pk, right_variant_b.pk},
|
||||
)
|
||||
|
||||
side_pairs = {}
|
||||
for idx, ex in enumerate(selected):
|
||||
key = selector._strip_side_tokens(ex.name)
|
||||
side_pairs.setdefault(key, []).append(idx)
|
||||
|
||||
self.assertEqual(len(side_pairs["matsyendra's pose"]), 2)
|
||||
self.assertEqual(len(side_pairs['miniband reverse clamshell']), 2)
|
||||
self.assertEqual(
|
||||
side_pairs["matsyendra's pose"][1],
|
||||
side_pairs["matsyendra's pose"][0] + 1,
|
||||
)
|
||||
self.assertEqual(
|
||||
side_pairs['miniband reverse clamshell'][1],
|
||||
side_pairs['miniband reverse clamshell'][0] + 1,
|
||||
)
|
||||
|
||||
Reference in New Issue
Block a user