admin/WerkoutAPI
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Hardening follow-up: N+1 elimination, type validation, diversify fix

Browse Source 
Additional fixes from parallel hardening streams:

- exercise/serializers: remove unused WorkoutEquipment import, add prefetch docs
- generator/serializers: N+1 fix in GeneratedWorkoutDetailSerializer (inline workout dict, prefetch-aware supersets)
- generator/services/plan_builder: eliminate redundant .save() after .create() via single create_kwargs dict
- generator/services/workout_generator: proper type-match validation for HIIT/cardio/core/flexibility; fix diversify type count to account for removed entry
- generator/views: request-level caching for get_registered_user helper; prefetch chain for accept_workout
- superset/serializers: guard against dangling FK in SupersetExerciseSerializer
- workout/helpers: use prefetched data instead of re-querying per superset

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Trey t
2026-02-27 22:33:40 -06:00
parent c80c66c2e5
commit 8e14fd5774
7 changed files with 117 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
workout/helpers.py
View File

@@ -62,26 +62,28 @@ def create_all_exercise_list_for_workout(workout):
audio_queues.append(next_up_data)
elif x < superset.rounds - 1:
first_exercise = supersetExercises.first()
next_up_data = {
"audio_url": first_exercise.exercise.audio_url().lower(),
"play_at": 7
}
first_exercise = supersetExercises[0] if supersetExercises else None
if first_exercise is not None:
next_up_data = {
"audio_url": first_exercise.exercise.audio_url().lower(),
"play_at": 7
}
audio_queues.append(next_up_data)
audio_queues.append(next_up_data)
elif len(supersets) > superset_count+1:
next_superset = supersets[superset_count+1]
# Use prefetched data instead of re-querying
next_superset_exercises = sorted(next_superset.supersetexercise_set.all(), key=lambda se: se.order)
next_supersetExercises = next_superset_exercises[0] if next_superset_exercises else None
next_up_data = {
"audio_url": next_supersetExercises.exercise.audio_url().lower(),
"play_at": 7
}
audio_queues.append(next_up_data)
if next_supersetExercises is not None:
next_up_data = {
"audio_url": next_supersetExercises.exercise.audio_url().lower(),
"play_at": 7
}
audio_queues.append(next_up_data)
ser_data["audio_queues"] = audio_queues
all_superset_exercise.append(ser_data)