Files
Sportstime/SportsTime/Export/Services/PDFAssetPrefetcher.swift
Trey t c94e373e33 fix: comprehensive codebase hardening — crashes, silent failures, performance, and security
Fixes ~95 issues from deep audit across 12 categories in 82 files:

- Crash prevention: double-resume in PhotoMetadataExtractor, force unwraps in
  DateRangePicker, array bounds checks in polls/achievements, ProGate hit-test
  bypass, Dictionary(uniqueKeysWithValues:) → uniquingKeysWith in 4 files
- Silent failure elimination: all 34 try? sites replaced with do/try/catch +
  logging (SavedTrip, TripDetailView, CanonicalSyncService, BootstrapService,
  CanonicalModels, CKModels, SportsTimeApp, and more)
- Performance: cached DateFormatters (7 files), O(1) team lookups via
  AppDataProvider, achievement definition dictionary, AnimatedBackground
  consolidated from 19 Tasks to 1, task cancellation in SharePreviewView
- Concurrency: UIKit drawing → MainActor.run, background fetch timeout guard,
  @MainActor on ThemeManager/AppearanceManager, SyncLogger read/write race fix
- Planning engine: game end time in travel feasibility, state-aware city
  normalization, exact city matching, DrivingConstraints parameter propagation
- IAP: unknown subscription states → expired, unverified transaction logging,
  entitlements updated before paywall dismiss, restore visible to all users
- Security: API key to Info.plist lookup, filename sanitization in PDF export,
  honest User-Agent, removed stale "Feels" analytics super properties
- Navigation: consolidated competing navigationDestination, boolean → value-based
- Testing: 8 sleep() → waitForExistence, duplicates extracted, Swift 6 compat
- Service bugs: infinite retry cap, duplicate achievement prevention, TOCTOU vote
  fix, PollVote.odg → voterId rename, deterministic placeholder IDs, parallel
  MKDirections, Sendable-safe POI struct

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-27 17:03:09 -06:00

180 lines
6.0 KiB
Swift

//
// PDFAssetPrefetcher.swift
// SportsTime
//
// Orchestrates parallel prefetching of all assets needed for PDF generation.
//
import Foundation
import UIKit
import os
private let logger = Logger(subsystem: "com.88oakapps.SportsTime", category: "PDFAssetPrefetcher")
actor PDFAssetPrefetcher {
// MARK: - Types
struct PrefetchedAssets {
let routeMap: UIImage?
let cityMaps: [String: UIImage]
let teamLogos: [String: UIImage]
let stadiumPhotos: [String: UIImage]
let cityPOIs: [String: [POISearchService.POI]]
var isEmpty: Bool {
routeMap == nil && cityMaps.isEmpty && teamLogos.isEmpty && stadiumPhotos.isEmpty && cityPOIs.isEmpty
}
}
struct PrefetchProgress {
var routeMapComplete: Bool = false
var cityMapsComplete: Bool = false
var logosComplete: Bool = false
var photosComplete: Bool = false
var poisComplete: Bool = false
var percentComplete: Double {
let completedSteps = [routeMapComplete, cityMapsComplete, logosComplete, photosComplete, poisComplete]
.filter { $0 }.count
return Double(completedSteps) / 5.0
}
var currentStep: String {
if !routeMapComplete { return "Generating route map..." }
if !cityMapsComplete { return "Generating city maps..." }
if !logosComplete { return "Downloading team logos..." }
if !photosComplete { return "Downloading stadium photos..." }
if !poisComplete { return "Finding nearby attractions..." }
return "Complete"
}
}
// MARK: - Properties
private let mapService = MapSnapshotService()
private let imageService = RemoteImageService()
private let poiService = POISearchService()
// MARK: - Public Methods
/// Prefetch all assets needed for PDF generation
/// - Parameters:
/// - trip: The trip to generate PDF for
/// - games: Map of game IDs to RichGame objects
/// - progressCallback: Optional callback for progress updates
/// - Returns: All prefetched assets
func prefetchAssets(
for trip: Trip,
games: [String: RichGame],
progressCallback: (@Sendable (PrefetchProgress) async -> Void)? = nil
) async -> PrefetchedAssets {
var progress = PrefetchProgress()
// Collect unique teams and stadiums from games
var teams: [Team] = []
var stadiums: [Stadium] = []
var seenTeamIds: Set<String> = []
var seenStadiumIds: Set<String> = []
for (_, richGame) in games {
if !seenTeamIds.contains(richGame.homeTeam.id) {
teams.append(richGame.homeTeam)
seenTeamIds.insert(richGame.homeTeam.id)
}
if !seenTeamIds.contains(richGame.awayTeam.id) {
teams.append(richGame.awayTeam)
seenTeamIds.insert(richGame.awayTeam.id)
}
if !seenStadiumIds.contains(richGame.stadium.id) {
stadiums.append(richGame.stadium)
seenStadiumIds.insert(richGame.stadium.id)
}
}
// Create immutable copies for concurrent access
let teamsToFetch = teams
let stadiumsToFetch = stadiums
// Run all fetches in parallel
async let routeMapTask = fetchRouteMap(stops: trip.stops)
async let cityMapsTask = fetchCityMaps(stops: trip.stops)
async let logosTask = imageService.fetchTeamLogos(teams: teamsToFetch)
async let photosTask = imageService.fetchStadiumPhotos(stadiums: stadiumsToFetch)
async let poisTask = poiService.findPOIsForCities(stops: trip.stops, limit: 5)
// Await each result and update progress
let routeMap = await routeMapTask
progress.routeMapComplete = true
await progressCallback?(progress)
let cityMaps = await cityMapsTask
progress.cityMapsComplete = true
await progressCallback?(progress)
let teamLogos = await logosTask
progress.logosComplete = true
await progressCallback?(progress)
let stadiumPhotos = await photosTask
progress.photosComplete = true
await progressCallback?(progress)
let cityPOIs = await poisTask
progress.poisComplete = true
await progressCallback?(progress)
return PrefetchedAssets(
routeMap: routeMap,
cityMaps: cityMaps,
teamLogos: teamLogos,
stadiumPhotos: stadiumPhotos,
cityPOIs: cityPOIs
)
}
// MARK: - Private Methods
private func fetchRouteMap(stops: [TripStop]) async -> UIImage? {
do {
// PDF page is 612 wide, minus margins
let mapSize = CGSize(width: 512, height: 350)
return try await mapService.generateRouteMap(stops: stops, size: mapSize)
} catch {
logger.error("Failed to generate route map for PDF: \(error.localizedDescription)")
return nil
}
}
private func fetchCityMaps(stops: [TripStop]) async -> [String: UIImage] {
var results: [String: UIImage] = [:]
let mapSize = CGSize(width: 250, height: 200)
await withTaskGroup(of: (String, UIImage?).self) { group in
// Deduplicate cities
var seenCities: Set<String> = []
for stop in stops {
guard !seenCities.contains(stop.city) else { continue }
seenCities.insert(stop.city)
group.addTask {
do {
let map = try await self.mapService.generateCityMap(stop: stop, size: mapSize)
return (stop.city, map)
} catch {
return (stop.city, nil)
}
}
}
for await (city, map) in group {
if let map = map {
results[city] = map
}
}
}
return results
}
}