Trey t
c94e373e33
fix: comprehensive codebase hardening — crashes, silent failures, performance, and security
...
Fixes ~95 issues from deep audit across 12 categories in 82 files:
- Crash prevention: double-resume in PhotoMetadataExtractor, force unwraps in
DateRangePicker, array bounds checks in polls/achievements, ProGate hit-test
bypass, Dictionary(uniqueKeysWithValues:) → uniquingKeysWith in 4 files
- Silent failure elimination: all 34 try? sites replaced with do/try/catch +
logging (SavedTrip, TripDetailView, CanonicalSyncService, BootstrapService,
CanonicalModels, CKModels, SportsTimeApp, and more)
- Performance: cached DateFormatters (7 files), O(1) team lookups via
AppDataProvider, achievement definition dictionary, AnimatedBackground
consolidated from 19 Tasks to 1, task cancellation in SharePreviewView
- Concurrency: UIKit drawing → MainActor.run, background fetch timeout guard,
@MainActor on ThemeManager/AppearanceManager, SyncLogger read/write race fix
- Planning engine: game end time in travel feasibility, state-aware city
normalization, exact city matching, DrivingConstraints parameter propagation
- IAP: unknown subscription states → expired, unverified transaction logging,
entitlements updated before paywall dismiss, restore visible to all users
- Security: API key to Info.plist lookup, filename sanitization in PDF export,
honest User-Agent, removed stale "Feels" analytics super properties
- Navigation: consolidated competing navigationDestination, boolean → value-based
- Testing: 8 sleep() → waitForExistence, duplicates extracted, Swift 6 compat
- Service bugs: infinite retry cap, duplicate achievement prevention, TOCTOU vote
fix, PollVote.odg → voterId rename, deterministic placeholder IDs, parallel
MKDirections, Sendable-safe POI struct
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-02-27 17:03:09 -06:00
Trey t
d63d311cab
feat: add WCAG AA accessibility app-wide, fix CloudKit container config, remove debug logs
...
- Add VoiceOver labels, hints, and element grouping across all 60+ views
- Add Reduce Motion support (Theme.Animation.prefersReducedMotion) to all animations
- Replace fixed font sizes with semantic Dynamic Type styles
- Hide decorative elements from VoiceOver with .accessibilityHidden(true)
- Add .minimumHitTarget() modifier ensuring 44pt touch targets
- Add AccessibilityAnnouncer utility for VoiceOver announcements
- Improve color contrast values in Theme.swift for WCAG AA compliance
- Extract CloudKitContainerConfig for explicit container identity
- Remove PostHog debug console log from AnalyticsManager
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-02-11 09:27:23 -06:00
