admin/Sportstime
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: resolve travel anchor ID collision for repeat city pairs

Browse Source 
Include segment index in travel anchor IDs ("travel:INDEX:from->to")
so Follow Team trips visiting the same city pair multiple times get
unique, independently addressable travel segments. Prevents override
dictionary collisions and incorrect validDayRange lookups.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Trey t
2026-02-11 10:57:53 -06:00
parent 633f7d883f
commit ff6f4b6c2c
12 changed files with 291 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
SportsTimeTests/Features/Trip/ItineraryRowFlatteningTests.swift
View File

@@ -170,10 +170,11 @@ final class ItineraryRowFlatteningTests: XCTestCase {
XCTAssertEqual(item.id, "games:2")
}
func test_itineraryRowItem_travel_hasLowercaseId() {
func test_itineraryRowItem_travel_hasStableId() {
let segment = H.makeTravelSegment(from: "Chicago", to: "Detroit")
let item = ItineraryRowItem.travel(segment, dayNumber: 1)
XCTAssertEqual(item.id, "travel:chicago->detroit", "Travel ID should be lowercase")
XCTAssertTrue(item.id.hasPrefix("travel:"), "Travel ID should start with 'travel:'")
XCTAssertTrue(item.id.contains(segment.id.uuidString), "Travel ID should contain segment UUID")
}
func test_itineraryRowItem_customItem_hasUuidId() {