fix: comprehensive codebase hardening — crashes, silent failures, performance, and security

Fixes ~95 issues from deep audit across 12 categories in 82 files:

- Crash prevention: double-resume in PhotoMetadataExtractor, force unwraps in
  DateRangePicker, array bounds checks in polls/achievements, ProGate hit-test
  bypass, Dictionary(uniqueKeysWithValues:) → uniquingKeysWith in 4 files
- Silent failure elimination: all 34 try? sites replaced with do/try/catch +
  logging (SavedTrip, TripDetailView, CanonicalSyncService, BootstrapService,
  CanonicalModels, CKModels, SportsTimeApp, and more)
- Performance: cached DateFormatters (7 files), O(1) team lookups via
  AppDataProvider, achievement definition dictionary, AnimatedBackground
  consolidated from 19 Tasks to 1, task cancellation in SharePreviewView
- Concurrency: UIKit drawing → MainActor.run, background fetch timeout guard,
  @MainActor on ThemeManager/AppearanceManager, SyncLogger read/write race fix
- Planning engine: game end time in travel feasibility, state-aware city
  normalization, exact city matching, DrivingConstraints parameter propagation
- IAP: unknown subscription states → expired, unverified transaction logging,
  entitlements updated before paywall dismiss, restore visible to all users
- Security: API key to Info.plist lookup, filename sanitization in PDF export,
  honest User-Agent, removed stale "Feels" analytics super properties
- Navigation: consolidated competing navigationDestination, boolean → value-based
- Testing: 8 sleep() → waitForExistence, duplicates extracted, Swift 6 compat
- Service bugs: infinite retry cap, duplicate achievement prevention, TOCTOU vote
  fix, PollVote.odg → voterId rename, deterministic placeholder IDs, parallel
  MKDirections, Sendable-safe POI struct

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

SportsTime/Features/Trip/Views/AddItem/POIDetailSheet.swift

@@ -101,7 +101,7 @@ struct POIDetailSheet: View {
                         highlight: true
                     )
 
-                    if let url = poi.mapItem?.url {
+                    if let url = poi.url {
                         Link(destination: url) {
                             metadataRow(icon: "globe", text: url.host ?? "Website", isLink: true)
                         }
@@ -133,19 +133,17 @@ struct POIDetailSheet: View {
                 .tint(Theme.warmOrange)
                 .accessibilityLabel("Add \(poi.name) to Day \(day)")
 
-                if poi.mapItem != nil {
-                    Button {
-                        poi.mapItem?.openInMaps()
-                    } label: {
-                        Label("Open in Apple Maps", systemImage: "map.fill")
-                            .font(.body.weight(.medium))
-                            .frame(maxWidth: .infinity)
-                            .padding(.vertical, Theme.Spacing.md)
-                    }
-                    .buttonStyle(.bordered)
-                    .tint(Theme.textSecondary(colorScheme))
-                    .accessibilityLabel("Open \(poi.name) in Apple Maps")
+                Button {
+                    poi.openInMaps()
+                } label: {
+                    Label("Open in Apple Maps", systemImage: "map.fill")
+                        .font(.body.weight(.medium))
+                        .frame(maxWidth: .infinity)
+                        .padding(.vertical, Theme.Spacing.md)
                 }
+                .buttonStyle(.bordered)
+                .tint(Theme.textSecondary(colorScheme))
+                .accessibilityLabel("Open \(poi.name) in Apple Maps")
             }
         }
         .padding(Theme.Spacing.lg)

SportsTime/Features/Trip/Views/AddItem/PlaceSearchSheet.swift

@@ -346,15 +346,17 @@ struct PlaceSearchSheet: View {
 
         let search = MKLocalSearch(request: request)
         search.start { response, error in
-            isSearching = false
+            Task { @MainActor in
+                isSearching = false
 
-            if let error {
-                searchError = error.localizedDescription
-                return
-            }
+                if let error {
+                    searchError = error.localizedDescription
+                    return
+                }
 
-            if let response {
-                searchResults = response.mapItems
+                if let response {
+                    searchResults = response.mapItems
+                }
             }
         }
     }