fix: comprehensive codebase hardening — crashes, silent failures, performance, and security

Fixes ~95 issues from deep audit across 12 categories in 82 files:

- Crash prevention: double-resume in PhotoMetadataExtractor, force unwraps in
  DateRangePicker, array bounds checks in polls/achievements, ProGate hit-test
  bypass, Dictionary(uniqueKeysWithValues:) → uniquingKeysWith in 4 files
- Silent failure elimination: all 34 try? sites replaced with do/try/catch +
  logging (SavedTrip, TripDetailView, CanonicalSyncService, BootstrapService,
  CanonicalModels, CKModels, SportsTimeApp, and more)
- Performance: cached DateFormatters (7 files), O(1) team lookups via
  AppDataProvider, achievement definition dictionary, AnimatedBackground
  consolidated from 19 Tasks to 1, task cancellation in SharePreviewView
- Concurrency: UIKit drawing → MainActor.run, background fetch timeout guard,
  @MainActor on ThemeManager/AppearanceManager, SyncLogger read/write race fix
- Planning engine: game end time in travel feasibility, state-aware city
  normalization, exact city matching, DrivingConstraints parameter propagation
- IAP: unknown subscription states → expired, unverified transaction logging,
  entitlements updated before paywall dismiss, restore visible to all users
- Security: API key to Info.plist lookup, filename sanitization in PDF export,
  honest User-Agent, removed stale "Feels" analytics super properties
- Navigation: consolidated competing navigationDestination, boolean → value-based
- Testing: 8 sleep() → waitForExistence, duplicates extracted, Swift 6 compat
- Service bugs: infinite retry cap, duplicate achievement prevention, TOCTOU vote
  fix, PollVote.odg → voterId rename, deterministic placeholder IDs, parallel
  MKDirections, Sendable-safe POI struct

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

SportsTime/Features/Progress/ViewModels/ProgressViewModel.swift

@@ -183,15 +183,15 @@ final class ProgressViewModel {
         stadiumVisitStatus = statusMap
 
         // Pre-compute sport progress fractions for SportSelectorGrid
-        var sportCounts: [Sport: Int] = [:]
+        var uniqueStadiumIdsBySport: [Sport: Set<String>] = [:]
         for visit in visits {
             if let sport = visit.sportEnum {
-                sportCounts[sport, default: 0] += 1
+                uniqueStadiumIdsBySport[sport, default: []].insert(visit.stadiumId)
             }
         }
         sportProgressFractions = Dictionary(uniqueKeysWithValues: Sport.supported.map { sport in
             let total = LeagueStructure.stadiumCount(for: sport)
-            let visited = min(sportCounts[sport] ?? 0, total)
+            let visited = min(uniqueStadiumIdsBySport[sport]?.count ?? 0, total)
             return (sport, total > 0 ? Double(visited) / Double(total) : 0)
         })