fix: comprehensive codebase hardening — crashes, silent failures, performance, and security

Fixes ~95 issues from deep audit across 12 categories in 82 files:

- Crash prevention: double-resume in PhotoMetadataExtractor, force unwraps in
  DateRangePicker, array bounds checks in polls/achievements, ProGate hit-test
  bypass, Dictionary(uniqueKeysWithValues:) → uniquingKeysWith in 4 files
- Silent failure elimination: all 34 try? sites replaced with do/try/catch +
  logging (SavedTrip, TripDetailView, CanonicalSyncService, BootstrapService,
  CanonicalModels, CKModels, SportsTimeApp, and more)
- Performance: cached DateFormatters (7 files), O(1) team lookups via
  AppDataProvider, achievement definition dictionary, AnimatedBackground
  consolidated from 19 Tasks to 1, task cancellation in SharePreviewView
- Concurrency: UIKit drawing → MainActor.run, background fetch timeout guard,
  @MainActor on ThemeManager/AppearanceManager, SyncLogger read/write race fix
- Planning engine: game end time in travel feasibility, state-aware city
  normalization, exact city matching, DrivingConstraints parameter propagation
- IAP: unknown subscription states → expired, unverified transaction logging,
  entitlements updated before paywall dismiss, restore visible to all users
- Security: API key to Info.plist lookup, filename sanitization in PDF export,
  honest User-Agent, removed stale "Feels" analytics super properties
- Navigation: consolidated competing navigationDestination, boolean → value-based
- Testing: 8 sleep() → waitForExistence, duplicates extracted, Swift 6 compat
- Service bugs: infinite retry cap, duplicate achievement prevention, TOCTOU vote
  fix, PollVote.odg → voterId rename, deterministic placeholder IDs, parallel
  MKDirections, Sendable-safe POI struct

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

SportsTime/Features/Polls/Views/PollCreationView.swift

@@ -11,6 +11,7 @@ struct PollCreationView: View {
     @Environment(\.dismiss) private var dismiss
     @Environment(\.colorScheme) private var colorScheme
     @State private var viewModel = PollCreationViewModel()
+    @State private var showError = false
 
     let trips: [Trip]
     var onPollCreated: ((TripPoll) -> Void)?
@@ -74,7 +75,7 @@ struct PollCreationView: View {
                         .background(.ultraThinMaterial)
                 }
             }
-            .alert("Error", isPresented: .constant(viewModel.error != nil)) {
+            .alert("Error", isPresented: $showError) {
                 Button("OK") {
                     viewModel.error = nil
                 }
@@ -83,6 +84,9 @@ struct PollCreationView: View {
                     Text(error.localizedDescription)
                 }
             }
+            .onChange(of: viewModel.error != nil) { _, hasError in
+                showError = hasError
+            }
             .onChange(of: viewModel.createdPoll) { _, newPoll in
                 if let poll = newPoll {
                     onPollCreated?(poll)