fix: comprehensive codebase hardening — crashes, silent failures, performance, and security

Fixes ~95 issues from deep audit across 12 categories in 82 files:

- Crash prevention: double-resume in PhotoMetadataExtractor, force unwraps in
  DateRangePicker, array bounds checks in polls/achievements, ProGate hit-test
  bypass, Dictionary(uniqueKeysWithValues:) → uniquingKeysWith in 4 files
- Silent failure elimination: all 34 try? sites replaced with do/try/catch +
  logging (SavedTrip, TripDetailView, CanonicalSyncService, BootstrapService,
  CanonicalModels, CKModels, SportsTimeApp, and more)
- Performance: cached DateFormatters (7 files), O(1) team lookups via
  AppDataProvider, achievement definition dictionary, AnimatedBackground
  consolidated from 19 Tasks to 1, task cancellation in SharePreviewView
- Concurrency: UIKit drawing → MainActor.run, background fetch timeout guard,
  @MainActor on ThemeManager/AppearanceManager, SyncLogger read/write race fix
- Planning engine: game end time in travel feasibility, state-aware city
  normalization, exact city matching, DrivingConstraints parameter propagation
- IAP: unknown subscription states → expired, unverified transaction logging,
  entitlements updated before paywall dismiss, restore visible to all users
- Security: API key to Info.plist lookup, filename sanitization in PDF export,
  honest User-Agent, removed stale "Feels" analytics super properties
- Navigation: consolidated competing navigationDestination, boolean → value-based
- Testing: 8 sleep() → waitForExistence, duplicates extracted, Swift 6 compat
- Service bugs: infinite retry cap, duplicate achievement prevention, TOCTOU vote
  fix, PollVote.odg → voterId rename, deterministic placeholder IDs, parallel
  MKDirections, Sendable-safe POI struct

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

SportsTime/Export/Services/RemoteImageService.swift

@@ -114,10 +114,11 @@ actor RemoteImageService {
     /// Fetch team logos by team ID
     func fetchTeamLogos(teams: [Team]) async -> [String: UIImage] {
         let urlToTeam: [URL: String] = Dictionary(
-            uniqueKeysWithValues: teams.compactMap { team in
+            teams.compactMap { team in
                 guard let logoURL = team.logoURL else { return nil }
                 return (logoURL, team.id)
-            }
+            },
+            uniquingKeysWith: { _, last in last }
         )
 
         let images = await fetchImages(from: Array(urlToTeam.keys))
@@ -135,10 +136,11 @@ actor RemoteImageService {
     /// Fetch stadium photos by stadium ID
     func fetchStadiumPhotos(stadiums: [Stadium]) async -> [String: UIImage] {
         let urlToStadium: [URL: String] = Dictionary(
-            uniqueKeysWithValues: stadiums.compactMap { stadium in
+            stadiums.compactMap { stadium in
                 guard let imageURL = stadium.imageURL else { return nil }
                 return (imageURL, stadium.id)
-            }
+            },
+            uniquingKeysWith: { _, last in last }
         )
 
         let images = await fetchImages(from: Array(urlToStadium.keys))