fix: comprehensive codebase hardening — crashes, silent failures, performance, and security

Fixes ~95 issues from deep audit across 12 categories in 82 files:

- Crash prevention: double-resume in PhotoMetadataExtractor, force unwraps in
  DateRangePicker, array bounds checks in polls/achievements, ProGate hit-test
  bypass, Dictionary(uniqueKeysWithValues:) → uniquingKeysWith in 4 files
- Silent failure elimination: all 34 try? sites replaced with do/try/catch +
  logging (SavedTrip, TripDetailView, CanonicalSyncService, BootstrapService,
  CanonicalModels, CKModels, SportsTimeApp, and more)
- Performance: cached DateFormatters (7 files), O(1) team lookups via
  AppDataProvider, achievement definition dictionary, AnimatedBackground
  consolidated from 19 Tasks to 1, task cancellation in SharePreviewView
- Concurrency: UIKit drawing → MainActor.run, background fetch timeout guard,
  @MainActor on ThemeManager/AppearanceManager, SyncLogger read/write race fix
- Planning engine: game end time in travel feasibility, state-aware city
  normalization, exact city matching, DrivingConstraints parameter propagation
- IAP: unknown subscription states → expired, unverified transaction logging,
  entitlements updated before paywall dismiss, restore visible to all users
- Security: API key to Info.plist lookup, filename sanitization in PDF export,
  honest User-Agent, removed stale "Feels" analytics super properties
- Navigation: consolidated competing navigationDestination, boolean → value-based
- Testing: 8 sleep() → waitForExistence, duplicates extracted, Swift 6 compat
- Service bugs: infinite retry cap, duplicate achievement prevention, TOCTOU vote
  fix, PollVote.odg → voterId rename, deterministic placeholder IDs, parallel
  MKDirections, Sendable-safe POI struct

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

SportsTime/Export/Services/POISearchService.swift

@@ -13,14 +13,14 @@ actor POISearchService {
 
     // MARK: - Types
 
-    struct POI: Identifiable, Hashable, @unchecked Sendable {
+    struct POI: Identifiable, Hashable, Sendable {
         let id: UUID
         let name: String
         let category: POICategory
         let coordinate: CLLocationCoordinate2D
         let distanceMeters: Double
         let address: String?
-        let mapItem: MKMapItem?
+        let url: URL?
 
         var formattedDistance: String {
             let miles = distanceMeters * 0.000621371
@@ -32,6 +32,15 @@ actor POISearchService {
             }
         }
 
+        /// Open this POI's location in Apple Maps
+        @MainActor
+        func openInMaps() {
+            let placemark = MKPlacemark(coordinate: coordinate)
+            let mapItem = MKMapItem(placemark: placemark)
+            mapItem.name = name
+            mapItem.openInMaps()
+        }
+
         // Hashable conformance for CLLocationCoordinate2D
         func hash(into hasher: inout Hasher) {
             hasher.combine(id)
@@ -218,7 +227,7 @@ actor POISearchService {
                 coordinate: itemCoordinate,
                 distanceMeters: distance,
                 address: formatAddress(item),
-                mapItem: item
+                url: item.url
             )
         }