fix: comprehensive codebase hardening — crashes, silent failures, performance, and security

Fixes ~95 issues from deep audit across 12 categories in 82 files:

- Crash prevention: double-resume in PhotoMetadataExtractor, force unwraps in
  DateRangePicker, array bounds checks in polls/achievements, ProGate hit-test
  bypass, Dictionary(uniqueKeysWithValues:) → uniquingKeysWith in 4 files
- Silent failure elimination: all 34 try? sites replaced with do/try/catch +
  logging (SavedTrip, TripDetailView, CanonicalSyncService, BootstrapService,
  CanonicalModels, CKModels, SportsTimeApp, and more)
- Performance: cached DateFormatters (7 files), O(1) team lookups via
  AppDataProvider, achievement definition dictionary, AnimatedBackground
  consolidated from 19 Tasks to 1, task cancellation in SharePreviewView
- Concurrency: UIKit drawing → MainActor.run, background fetch timeout guard,
  @MainActor on ThemeManager/AppearanceManager, SyncLogger read/write race fix
- Planning engine: game end time in travel feasibility, state-aware city
  normalization, exact city matching, DrivingConstraints parameter propagation
- IAP: unknown subscription states → expired, unverified transaction logging,
  entitlements updated before paywall dismiss, restore visible to all users
- Security: API key to Info.plist lookup, filename sanitization in PDF export,
  honest User-Agent, removed stale "Feels" analytics super properties
- Navigation: consolidated competing navigationDestination, boolean → value-based
- Testing: 8 sleep() → waitForExistence, duplicates extracted, Swift 6 compat
- Service bugs: infinite retry cap, duplicate achievement prevention, TOCTOU vote
  fix, PollVote.odg → voterId rename, deterministic placeholder IDs, parallel
  MKDirections, Sendable-safe POI struct

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

SportsTime/Export/Services/MapSnapshotService.swift

@@ -62,14 +62,16 @@ actor MapSnapshotService {
         let snapshotter = MKMapSnapshotter(options: options)
         let snapshot = try await snapshotter.start()
 
-        // Draw route and markers on snapshot
-        let image = drawRouteOverlay(
-            on: snapshot,
-            coordinates: coordinates,
-            stops: stops,
-            routeColor: routeColor,
-            size: size
-        )
+        // Draw route and markers on snapshot (UIKit drawing must run on main thread)
+        let image = await MainActor.run {
+            drawRouteOverlay(
+                on: snapshot,
+                coordinates: coordinates,
+                stops: stops,
+                routeColor: routeColor,
+                size: size
+            )
+        }
 
         return image
     }
@@ -105,13 +107,15 @@ actor MapSnapshotService {
         let snapshotter = MKMapSnapshotter(options: options)
         let snapshot = try await snapshotter.start()
 
-        // Draw stadium marker
-        let image = drawStadiumMarker(
-            on: snapshot,
-            coordinate: coordinate,
-            cityName: stop.city,
-            size: size
-        )
+        // Draw stadium marker (UIKit drawing must run on main thread)
+        let image = await MainActor.run {
+            drawStadiumMarker(
+                on: snapshot,
+                coordinate: coordinate,
+                cityName: stop.city,
+                size: size
+            )
+        }
 
         return image
     }
@@ -149,7 +153,7 @@ actor MapSnapshotService {
     }
 
     /// Draw route line and numbered markers on snapshot
-    private func drawRouteOverlay(
+    private nonisolated func drawRouteOverlay(
         on snapshot: MKMapSnapshotter.Snapshot,
         coordinates: [CLLocationCoordinate2D],
         stops: [TripStop],
@@ -196,7 +200,7 @@ actor MapSnapshotService {
     }
 
     /// Draw stadium marker on city map
-    private func drawStadiumMarker(
+    private nonisolated func drawStadiumMarker(
         on snapshot: MKMapSnapshotter.Snapshot,
         coordinate: CLLocationCoordinate2D,
         cityName: String,
@@ -247,7 +251,7 @@ actor MapSnapshotService {
     }
 
     /// Draw a numbered circular marker
-    private func drawNumberedMarker(
+    private nonisolated func drawNumberedMarker(
         at point: CGPoint,
         number: Int,
         color: UIColor,